Re: [PATCH v2 04/10] isar-boot-strap: Add option to keep cache

[Henning Schild <henning.schild@siemens.com>]

Am Thu, 11 Oct 2018 18:52:59 +0200
schrieb "Maxim Yu. Osipov" <mosipov@ilbers.de>:

> From: Alexander Smirnov <asmirnov@ilbers.de>
> 
> The default ISAR behavior assumes to remove all the packages
> from apt cache, but we need them to put into base-apt.
> 
> Signed-off-by: Alexander Smirnov <asmirnov@ilbers.de>
> ---
>  meta/classes/isar-bootstrap-helper.bbclass | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/meta/classes/isar-bootstrap-helper.bbclass
> b/meta/classes/isar-bootstrap-helper.bbclass index f046216..b7cd64a
> 100644 --- a/meta/classes/isar-bootstrap-helper.bbclass
> +++ b/meta/classes/isar-bootstrap-helper.bbclass
> @@ -70,6 +70,7 @@ setup_root_file_system() {
>          --fstab) FSTAB=$2; shift ;;
>          --host-arch) ROOTFS_ARCH=${HOST_ARCH} ;;
>          --host-distro) ROOTFS_DISTRO=${HOST_DISTRO} ;;
> +        --keep-apt-cache) KEEP_APT_CACHE=1 ;;
>          -*) bbfatal "$0: invalid option specified: $1" ;;
>          *) break ;;
>          esac
> @@ -131,6 +132,11 @@ setup_root_file_system() {
>              /usr/bin/apt-get purge --yes $pkg
>      done
>      if [ ${CLEAN} ]; then
> +        if [ ${KEEP_APT_CACHE} ]; then
> +            mkdir -p ${WORKDIR}/apt_cache
> +            sudo mv $(find $ROOTFSDIR/var/cache/apt -name '*.deb')
> ${WORKDIR}/apt_cache
> +            sudo chown $USER ${WORKDIR}/apt_cache/*

In my build USER is not set. So we fail with 

>> chown: invalid user:
>> '/out/build/tmp/work/debian-stretch-amd64/isar-image-base/apt_cache/adduser_3.115_all.deb'

Where adduser is the first of *. Should be `whoami`.

Henning

> +        fi
>          sudo -E chroot "$ROOTFSDIR" \
>              /usr/bin/apt-get autoremove --purge --yes
>          sudo -E chroot "$ROOTFSDIR" \