public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
* [PATCH] isar-bootstrap-helper: don't use USER environment variable
@ 2018-10-26 11:08 Maxim Yu. Osipov
  2018-10-29 11:28 ` chombourger
  0 siblings, 1 reply; 2+ messages in thread
From: Maxim Yu. Osipov @ 2018-10-26 11:08 UTC (permalink / raw)
  To: isar-users

In some build environments USER variable is not set.
Use `whoami` instead.

Suggested-by: Henning Schild <henning.schild@siemens.com>
Signed-off-by: Maxim Yu. Osipov <mosipov@ilbers.de>
---
 meta/classes/isar-bootstrap-helper.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/isar-bootstrap-helper.bbclass b/meta/classes/isar-bootstrap-helper.bbclass
index a316fe8..1ac39db 100644
--- a/meta/classes/isar-bootstrap-helper.bbclass
+++ b/meta/classes/isar-bootstrap-helper.bbclass
@@ -140,7 +140,7 @@ setup_root_file_system() {
         if [ ${KEEP_APT_CACHE} -eq 1 ]; then
             mkdir -p ${WORKDIR}/apt_cache
             sudo mv $(find $ROOTFSDIR/var/cache/apt -name '*.deb') ${WORKDIR}/apt_cache
-            sudo chown $USER ${WORKDIR}/apt_cache/*
+            sudo chown `whoami` ${WORKDIR}/apt_cache/*
         fi
         sudo -E chroot "$ROOTFSDIR" \
             /usr/bin/apt-get autoremove --purge --yes
-- 
2.11.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] isar-bootstrap-helper: don't use USER environment variable
  2018-10-26 11:08 [PATCH] isar-bootstrap-helper: don't use USER environment variable Maxim Yu. Osipov
@ 2018-10-29 11:28 ` chombourger
  0 siblings, 0 replies; 2+ messages in thread
From: chombourger @ 2018-10-29 11:28 UTC (permalink / raw)
  To: isar-users

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]


> diff --git a/meta/classes/isar-bootstrap-helper.bbclass b/meta/classes/isar-bootstrap-helper.bbclass
> index a316fe8..1ac39db 100644
> --- a/meta/classes/isar-bootstrap-helper.bbclass
> +++ b/meta/classes/isar-bootstrap-helper.bbclass
> @@ -140,7 +140,7 @@ setup_root_file_system() {
>          if [ ${KEEP_APT_CACHE} -eq 1 ]; then
>              mkdir -p ${WORKDIR}/apt_cache
>              sudo mv $(find $ROOTFSDIR/var/cache/apt -name '*.deb') ${WORKDIR}/apt_cache
> -            sudo chown $USER ${WORKDIR}/apt_cache/*
> +            sudo chown `whoami` ${WORKDIR}/apt_cache/*

Consider using the new-style syntax $(whoami) instead

>          fi
>          sudo -E chroot "$ROOTFSDIR" \
>              /usr/bin/apt-get autoremove --purge --yes
> -- 
> 2.11.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-10-29 11:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-26 11:08 [PATCH] isar-bootstrap-helper: don't use USER environment variable Maxim Yu. Osipov
2018-10-29 11:28 ` chombourger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox