Re: [PATCH] buildchroot: build debian packages as "builder" not "root"

[Henning Schild <henning.schild@siemens.com>]

Am Mon, 29 Oct 2018 11:54:02 +0100
schrieb Baurzhan Ismagulov <ibr@radix50.net>:

> On Fri, Oct 26, 2018 at 12:49:14PM +0200, Henning Schild wrote:
> > We used to build packages as "root" and now do that as a regular
> > user. Not building as "root" allows us to find mistakes in
> > debian/rules where privileged operations are used while they should
> > not (a sudo was found in a rules-file). Further some build steps
> > might actually expect to not run as root (seen in openssl test
> > suite).
> > 
> > Not building as root should increase overall quality and brings us
> > closer to how debian packages are build by others.  
> 
> Thanks, a good step.
> 
> 
> > +su - builder -c "cd $1; dpkg-buildpackage -a$target_arch -d
> > --source-option=-I"  
> 
> I suggest adding -rfakeroot to satisfy the cases below.

"-rfakeroot" is the default and can be omitted ... it is already in
there. Unless the defaults are different in the various versions we
support.

Henning

> https://www.debian.org/doc/debian-policy/ch-files.html#permissions-and-owners
> https://www.debian.org/doc/debian-policy/ch-controlfields.html#s-f-rules-requires-root
> 
> 
> With kind regards,
> Baurzhan.
>