public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: "Jan Kiszka" <jan.kiszka@siemens.com>
Cc: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH 01/10] meta: builchroot: Preserve environment when calling dpkg-buildpackage
Date: Mon, 5 Nov 2018 11:05:36 +0100	[thread overview]
Message-ID: <20181105110536.3de6e135@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <18dfabd13a9701da5182e41bb12840c315fcc0b8.1541400730.git.jan.kiszka@siemens.com>

Am Mon, 5 Nov 2018 07:52:01 +0100
schrieb "Jan Kiszka" <jan.kiszka@siemens.com>:

> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> This is required in order to allow recipes to pass variables down to
> the rules file. E.g., u-boot-custom.inc makes use of this.
> 
> Fixes: be291cd991bd ("buildchroot: build debian packages as "builder"
> not "root"") Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  meta/recipes-devtools/buildchroot/files/build.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/buildchroot/files/build.sh
> b/meta/recipes-devtools/buildchroot/files/build.sh index
> d98eb2e..5855f29 100644 ---
> a/meta/recipes-devtools/buildchroot/files/build.sh +++
> b/meta/recipes-devtools/buildchroot/files/build.sh @@ -17,4 +17,4 @@
> done # Build the package as user "builder"
>  chown -R builder:builder $1 # the sources
>  chown builder:builder $1/.. # the output
> -su - builder -c "cd $1; dpkg-buildpackage -a$target_arch -d
> --source-option=-I" +su - builder -p -c "cd $1; dpkg-buildpackage
> -a$target_arch -d --source-option=-I"

I guess the "-" ("-l") should be dropped as well once at it. We need
those features tested inside Isar!

Henning

  parent reply	other threads:[~2018-11-05 10:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-05  6:52 [PATCH 00/10] HiKey and DE0 Nano SoC boards, further improvements and cleanups Jan Kiszka
2018-11-05  6:52 ` [PATCH 01/10] meta: builchroot: Preserve environment when calling dpkg-buildpackage Jan Kiszka
2018-11-05  9:41   ` Henning Schild
2018-11-05  9:46     ` Jan Kiszka
2018-11-05 10:05   ` Henning Schild [this message]
2018-11-05 10:16     ` [PATCH v2 " Jan Kiszka
2018-11-05 14:15     ` [PATCH " Baurzhan Ismagulov
2018-11-05 14:25       ` Jan Kiszka
2018-11-05 15:36       ` Henning Schild
2018-11-06 10:53         ` Baurzhan Ismagulov
2018-11-05  6:52 ` [PATCH 02/10] meta-isar: Remove remaining wheezy traces Jan Kiszka
2018-11-09 14:22   ` Baurzhan Ismagulov
2018-11-05  6:52 ` [PATCH 03/10] meta-isar: linux: Update mainline recipe to 4.19 Jan Kiszka
2018-11-05  6:52 ` [PATCH 04/10] meta-isar: example-module: Only disable cross-compilation for Debian kernels Jan Kiszka
2018-11-05  6:52 ` [PATCH 05/10] meta-isar: Add Terasic DE0-Nano-SoC as demonstration board Jan Kiszka
2018-11-05  6:52 ` [PATCH 06/10] meta-isar: Add LeMaker HiKey board Jan Kiszka
2018-11-05  6:52 ` [PATCH 07/10] meta: linux-module: Fix arm64 cross-build Jan Kiszka
2018-11-05  6:52 ` [PATCH 08/10] wic: bootimg-efi-isar: Avoid append "None" to kernel command line Jan Kiszka
2018-11-05  6:52 ` [PATCH 09/10] wic: bootimg-efi-isar: Make agnostic to partition order Jan Kiszka
2018-11-05  6:52 ` [PATCH 10/10] image: Add install_image_deps to cache_base_repo dependencies Jan Kiszka
2018-11-06  9:59 ` [PATCH 00/10] HiKey and DE0 Nano SoC boards, further improvements and cleanups Maxim Yu. Osipov
2018-11-06 10:49   ` Baurzhan Ismagulov
2018-11-06 10:51     ` Jan Kiszka
2018-11-07 13:11 ` Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181105110536.3de6e135@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox