From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6617812835611181056 X-Received: by 2002:a17:906:6899:: with SMTP id n25-v6mr564783ejr.11.1541664797122; Thu, 08 Nov 2018 00:13:17 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:b7b1:: with SMTP id h46-v6ls354847ede.14.gmail; Thu, 08 Nov 2018 00:13:16 -0800 (PST) X-Google-Smtp-Source: AJdET5dN8122je+ZPdbdKszvWTbiB/G4cKI1/ZBoGe+HRaVJA9AnxUdzpsLGbenGAPK8ArvzQ1iZ X-Received: by 2002:a50:b361:: with SMTP id r30-v6mr602089edd.2.1541664796702; Thu, 08 Nov 2018 00:13:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1541664796; cv=none; d=google.com; s=arc-20160816; b=VLzbfzLe1rkRyAwNADV6kzeSUdOtLRVFJHgFXmOzZ6uH/oK8n8LX2aYjyUnq4YGFds HyIdvaZtWjdeZDrKAtKnu8Fg+GvtKNiNXTrp0tk0nGLY7epFEHGmRR1y4dYrDYE9OgDr KQ6VqlZpKWBYyy6YE9iPhG6CHWDgV3O6eRUxxWcCtBTNAjereOQbMrRFiuZ5nhbEb+b7 3Uly3ab4y+BUBtcTykiWZ97LXlnNB0egFUzc6BwW6dliiZZU+2kFXEkIS0zqj9Y+LIe/ bRNS/JzbJaTx9U3udYSTnUxxUXNK8qXQkG0Wrrnl4v/8X70x9AzkcOM13AZv3nyCuqo5 03uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=FAVfvoMaYcxHvNWhsGLTXoBlvGpKjGydA/jBBO91dNY=; b=qi/KvUGOyPUFJHxb2gvx6wI8MrP/+/NV9QQiX+F7Ik5wbPuVV90oOWAwhed36IqeQl /8GUQAh8HuvLVYMrs7OOsMYQIfN7njYL85Mz0g2hj/4Q6JU4ePl3HOK57lc6nQvgkZcX eRhTr9ZxOJ/FTJY1t5leHoNGHChd8WCYJE5WnWDO69PQOrlryVdgrER7I7djifoMu3dq OvS1QwlKJMM0azBTUcRDJnvsq/+wZRyQr2UDSZgFccf3geYNkBG8FyznSYhkvGTojMHx GYEjId4/31q1iLP3E3GRlwDCNRw+qm075P/Dj/wgWHUa1FwzZ67ZV9ZulyVJ0X57u/ca /A9A== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id b56-v6si70823eda.4.2018.11.08.00.13.16 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Nov 2018 00:13:16 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id wA88DF9H012490 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 8 Nov 2018 09:13:15 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.68.200]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id wA88DEVN004843; Thu, 8 Nov 2018 09:13:14 +0100 Date: Thu, 8 Nov 2018 09:13:12 +0100 From: Henning Schild To: Cedric Hombourger Cc: Cedric Hombourger , Subject: Re: [PATCH v3 2/2] isar-image: refactor do_rootfs() Message-ID: <20181108091312.1b3eef10@md1za8fc.ad001.siemens.net> In-Reply-To: References: <57847f7a-9b85-65ef-b11e-8952bf532e0f@siemens.com> <20181101101302.8674-1-Cedric_Hombourger@mentor.com> <20181101101302.8674-2-Cedric_Hombourger@mentor.com> <20181107194531.17356c59@md1za8fc.ad001.siemens.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 2IRuQipdCKWB Am Wed, 7 Nov 2018 21:16:08 +0100 schrieb Cedric Hombourger : > Hi again, > > My test build on a machine _without_ a direct Internet connection has > completed. > Any idea how I can reproduce your issue? or help troubleshoot? > > Note: tested with HEAD = 60db83cdcae60bdca6d3e3ed2cc7c44712d4dd91 False alarm. Last night several machines had issues fetching files in debootstrap (with and without proxies), must have been a temporary server-side issue. Henning > Cedric > > On Wed, 7 Nov 2018 at 20:46, Cedric Hombourger > wrote: > > > Hi Henning, > > > > I apologize if that's the case. On my side, the proxy appears to be > > used just fine. I have added a trace in isar_image_gen_rootfs() and > > I can see: > > > > DEBUG: Executing python function do_rootfs > > DEBUG: Executing shell function root_cleandirs > > DEBUG: Shell function root_cleandirs finished > > DEBUG: Executing shell function isar_image_gen_fstab > > DEBUG: Shell function isar_image_gen_fstab finished > > DEBUG: Executing shell function isar_image_gen_rootfs > > ######## http_proxy=http://127.0.0.1:3142 ########## > > > > I also checked my apt-cacher-ng and I saw a bunch of requests > > coming in while do_rootfs was executing. > > Will double-check on a machine that does not have direct access to > > the Internet to make sure. > > > > Cedric > > > > On Wed, 7 Nov 2018 at 19:45, Henning Schild > > wrote: > > > >> Am Thu, 1 Nov 2018 11:13:02 +0100 > >> schrieb Cedric Hombourger : > >> > >> > Split the do_rootfs() shell function into four (smaller) shell > >> > functions to generate the fstab file (isar_image_gen_fstab), > >> > populate the root file-system (isar_image_gen_rootfs), configure > >> > it (isar_image_conf_rootfs) and perform some house-keeping > >> > (isar_image_cleanup). do_rootfs is now a python function and > >> > sequentially calls the helper functions listed above. > >> > > >> > Signed-off-by: Cedric Hombourger > >> > --- > >> > meta/classes/isar-image.bbclass | 15 ++++++++++++++- > >> > 1 file changed, 14 insertions(+), 1 deletion(-) > >> > > >> > diff --git a/meta/classes/isar-image.bbclass > >> > b/meta/classes/isar-image.bbclass index ec2b9e3..e0508be 100644 > >> > --- a/meta/classes/isar-image.bbclass > >> > +++ b/meta/classes/isar-image.bbclass > >> > @@ -21,7 +21,7 @@ ISAR_RELEASE_CMD ?= > >> > "${ISAR_RELEASE_CMD_DEFAULT}" do_rootfs[root_cleandirs] = > >> > "${IMAGE_ROOTFS} \ ${IMAGE_ROOTFS}/isar-apt" > >> > > >> > -do_rootfs() { > >> > +isar_image_gen_fstab() { > >> > cat > ${WORKDIR}/fstab << EOF > >> > # Begin /etc/fstab > >> > /dev/root / auto > >> > defaults 0 0 @@ -33,11 +33,15 @@ > >> > devtmpfs /dev devtmpfs > >> > mode=0755,nosuid 0 0 # End /etc/fstab > >> > EOF > >> > +} > >> > > >> > +isar_image_gen_rootfs() { > >> > setup_root_file_system --clean --keep-apt-cache \ > >> > --fstab "${WORKDIR}/fstab" \ > >> > "${IMAGE_ROOTFS}" ${IMAGE_PREINSTALL} ${IMAGE_INSTALL} > >> > +} > >> > > >> > +isar_image_conf_rootfs() { > >> > # Configure root filesystem > >> > if [ -n "${DISTRO_CONFIG_SCRIPT}" ]; then > >> > sudo install -m 755 "${WORKDIR}/${DISTRO_CONFIG_SCRIPT}" > >> > "${IMAGE_ROOTFS}" @@ -45,7 +49,9 @@ EOF > >> > > >> "${BAUDRATE_TTY}" > >> > sudo rm "${IMAGE_ROOTFS}/${DISTRO_CONFIG_SCRIPT}" > >> > fi > >> > +} > >> > > >> > +isar_image_cleanup() { > >> > # Cleanup > >> > sudo rm > >> > "${IMAGE_ROOTFS}/etc/apt/sources.list.d/isar-apt.list" test ! -e > >> > "${IMAGE_ROOTFS}/usr/share/doc/qemu-user-static" && \ @@ -57,3 > >> > +63,10 @@ EOF sudo umount -l ${IMAGE_ROOTFS}/proc > >> > sudo rm -f > >> > "${IMAGE_ROOTFS}/etc/apt/apt.conf.d/55isar-fallback.conf" } > >> > + > >> > +python do_rootfs() { > >> > + bb.build.exec_func("isar_image_gen_fstab", d) > >> > + bb.build.exec_func("isar_image_gen_rootfs", d) > >> > + bb.build.exec_func("isar_image_conf_rootfs", d) > >> > + bb.build.exec_func("isar_image_cleanup", d) > >> > +} > >> > >> I am loosing my proxies somewhere in current next ... i suspect > >> this guy but did not confirm yet. > >> > >> Henning > >> > >> -- > >> You received this message because you are subscribed to a topic in > >> the Google Groups "isar-users" group. > >> To unsubscribe from this topic, visit > >> https://groups.google.com/d/topic/isar-users/Pzt7vsbc8VE/unsubscribe. > >> To unsubscribe from this group and all its topics, send an email to > >> isar-users+unsubscribe@googlegroups.com. > >> To post to this group, send email to isar-users@googlegroups.com. > >> To view this discussion on the web visit > >> https://groups.google.com/d/msgid/isar-users/20181107194531.17356c59%40md1za8fc.ad001.siemens.net > >> . > >> For more options, visit https://groups.google.com/d/optout. > >> > >