From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6622940919445323776 X-Received: by 2002:a19:5619:: with SMTP id k25-v6mr115811lfb.12.1542030386397; Mon, 12 Nov 2018 05:46:26 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:12ce:: with SMTP id 75-v6ls674870ljs.22.gmail; Mon, 12 Nov 2018 05:46:25 -0800 (PST) X-Google-Smtp-Source: AJdET5d1GL34hgfbrvgcgSciboSQFZoIH8Z5UNH6TqnM0k/+Wegg7tVzRVJweTDd/lej9eQwASiv X-Received: by 2002:a2e:42ce:: with SMTP id h75-v6mr126415ljf.27.1542030385882; Mon, 12 Nov 2018 05:46:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542030385; cv=none; d=google.com; s=arc-20160816; b=zaaFHs0+PFdABe5YcU1qeeMRJMXOZFkAGATzKweCvHZJVI0OYtfKAUXwbWQ7nafJ1q f1HD7PdPR0UvNZgPzqvs9tlhn+/eRwBndnFsxePXBuf+bHttX5+7mjxd2Sh4LpEqP8w1 O1nv2BTMTR1COFBLjrdasu/QzggkM7XSfbiuDaP7/RZrl/5Oco6vfzkqk/ONBW6cPwlo EcgdiRSZ3jLtfrrZGHConHu9M2W5tDSZe/Kh3ZGqK0RCVbNSWI2wtOluzzRJCMjw2cBH tQGX/U6Q3W8x5QU4x7eC/be/YRtzIF6HHtrsAUdNBG+5Pr6fyX/VCVqoYO9eUD0SsyTh jfSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:to:from:date; bh=uBhEnp6adRbCKBSt7gJ/uITwVC4JzF4S8Dj3Udzc0qA=; b=UaEBT1xRSmpmbcMOIFrsnTtxoPw/WTxGmQ0oSWv1bmEK49PD1XinsLBXX6mbhDYDGN OdRMt5nGs6G/0Ue0JKOzX30nKlGzQeWh1BX7Nf3V5HAAmqvkRhsD7UckKHQhx/emfEXq ipTI3iNlcYF3ykaaCWqUITZuRt4pAtyDXGFOPpYGeef4x+d4+XzKFZEefoHL13z9atJ7 8LbcHyfANMvmwGM9Q4oOlf1Ndy4s++S9clgZlgrMkoFCRLJC8Cxm2QwdVifk65ZGhabV MwxPYAvreEcwPJBhg4qHqFeFLs8Roi3RblFYTKvMI+Kru85maVSw6yycR7T2NJWGuFb/ 6GUA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id a192si282326lfa.4.2018.11.12.05.46.25 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Nov 2018 05:46:25 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id wACDkOoF004956 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 12 Nov 2018 14:46:25 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.69.119]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id wACDkOPp010578 for ; Mon, 12 Nov 2018 14:46:24 +0100 Date: Mon, 12 Nov 2018 14:46:24 +0100 From: Henning Schild To: isar-users Subject: Re: [PATCH] buildchroot: chown the whole WORKDIR to builder:builder Message-ID: <20181112144624.0cd92d18@md1za8fc.ad001.siemens.net> In-Reply-To: <20181112115315.17647-1-henning.schild@siemens.com> References: <20181112115315.17647-1-henning.schild@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 2U45mPvotgft This is truly wrong, because now we chown temp/ and other bitbake owned files. The real fix probably is reverting 624b7c484bf5, will send another patch. Henning Am Mon, 12 Nov 2018 12:53:15 +0100 schrieb Henning Schild : > The initial idea was to chown as little as possible, but there is a > "chown -R" in do_unpack that we need to work against when rebuilding a > package. > > Fixes: be291cd991bd ("buildchroot: build debian packages as "builder" > not "root"") Signed-off-by: Henning Schild > --- > meta/recipes-devtools/buildchroot/files/build.sh | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/meta/recipes-devtools/buildchroot/files/build.sh > b/meta/recipes-devtools/buildchroot/files/build.sh index > 66b1a77..112aac3 100644 --- > a/meta/recipes-devtools/buildchroot/files/build.sh +++ > b/meta/recipes-devtools/buildchroot/files/build.sh @@ -15,6 +15,5 @@ > for i in configure aclocal.m4 Makefile.am Makefile.in; do done > > # Build the package as user "builder" > -chown -R builder:builder $1 # the sources > -chown builder:builder $1/.. # the output > +chown -R builder:builder $1/.. # the whole WORKDIR > su builder -c "cd $1; dpkg-buildpackage -a$target_arch -d > --source-option=-I"