Re: [PATCH v3 1/2] buildchroot+bootstrap: use rbinds for /dev and /proc

[Henning Schild <henning.schild@siemens.com>]

Am Mon, 12 Nov 2018 20:59:32 -0800
schrieb Cedric Hombourger <Cedric_Hombourger@mentor.com>:

> Bind mount the entire hierarchy for /dev and /proc as recommended in
> Gentoo's chroot setup guide.
> 
> Suggested-by: Henning Schild <henning.schild@siemens.com>
> Signed-off-by: Cedric Hombourger <Cedric_Hombourger@mentor.com>
> ---
>  meta/classes/buildchroot.bbclass                    | 6 ++++--
>  meta/classes/isar-bootstrap-helper.bbclass          | 6 ++++--
>  meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 6 ++++--
>  3 files changed, 12 insertions(+), 6 deletions(-)
> 
> diff --git a/meta/classes/buildchroot.bbclass
> b/meta/classes/buildchroot.bbclass index 870d27c..26d5e80 100644
> --- a/meta/classes/buildchroot.bbclass
> +++ b/meta/classes/buildchroot.bbclass
> @@ -27,7 +27,9 @@ buildchroot_do_mounts() {
>          if ! grep -q ${BUILDCHROOT_DIR}/isar-apt /proc/mounts; then
>              mount --bind ${REPO_ISAR_DIR}/${DISTRO}
> ${BUILDCHROOT_DIR}/isar-apt mount --bind ${DL_DIR}
> ${BUILDCHROOT_DIR}/downloads
> -            mount -t devtmpfs -o mode=0755,nosuid devtmpfs
> ${BUILDCHROOT_DIR}/dev
> -            mount -t proc none ${BUILDCHROOT_DIR}/proc
> +            mount --rbind /dev ${BUILDCHROOT_DIR}/dev
> +            mount --make-rslave ${BUILDCHROOT_DIR}/dev
> +            mount --rbind /proc ${BUILDCHROOT_DIR}/proc
> +            mount --make-rslave ${BUILDCHROOT_DIR}/proc

/proc should be mounted as it was before.

Henning

>          fi'
>  }
> diff --git a/meta/classes/isar-bootstrap-helper.bbclass
> b/meta/classes/isar-bootstrap-helper.bbclass index 1ac39db..62c0839
> 100644 --- a/meta/classes/isar-bootstrap-helper.bbclass
> +++ b/meta/classes/isar-bootstrap-helper.bbclass
> @@ -103,8 +103,10 @@ setup_root_file_system() {
>          sudo mount --bind ${REPO_BASE_DIR} ${ROOTFSDIR}/base-apt
>      fi
>  
> -    sudo mount -t devtmpfs -o mode=0755,nosuid devtmpfs
> $ROOTFSDIR/dev
> -    sudo mount -t proc none $ROOTFSDIR/proc
> +    sudo mount --rbind /dev ${ROOTFSDIR}/dev
> +    sudo mount --make-rslave ${ROOTFSDIR}/dev
> +    sudo mount --rbind /proc ${ROOTFSDIR}/proc
> +    sudo mount --make-rslave ${ROOTFSDIR}/proc
>  
>      # Install packages:
>      E="${@ bb.utils.export_proxies(d)}"
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index
> 592d042..cd93f6c 100644 ---
> a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++
> b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -241,8
> +241,10 @@ isar_bootstrap() { "${ROOTFSDIR}/chroot-setup.sh" "setup"
> "${ROOTFSDIR}" 
>              # update APT
> -            mount -t devtmpfs -o mode=0755,nosuid devtmpfs
> ${ROOTFSDIR}/dev
> -            mount -t proc none ${ROOTFSDIR}/proc
> +	    mount --rbind /dev ${BUILDCHROOT_DIR}/dev
> +	    mount --make-rslave ${BUILDCHROOT_DIR}/dev
> +	    mount --rbind /proc ${BUILDCHROOT_DIR}/proc
> +	    mount --make-rslave ${BUILDCHROOT_DIR}/proc
>  
>              export DEBIAN_FRONTEND=noninteractive
>              chroot "${ROOTFSDIR}" /usr/bin/apt-get update -y