From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6621956091070644224 X-Received: by 2002:a17:906:6899:: with SMTP id n25-v6mr2380634ejr.11.1542110768219; Tue, 13 Nov 2018 04:06:08 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:69cd:: with SMTP id g13-v6ls631474ejs.0.gmail; Tue, 13 Nov 2018 04:06:07 -0800 (PST) X-Google-Smtp-Source: AJdET5eXAlAhyw7WDa+Zmz13XzMcdUbRaiVpYc7iAav4So5KkKPnFHWlbuocFd1QdDNHIlKEh5BN X-Received: by 2002:a17:906:31d9:: with SMTP id f25-v6mr12779ejf.0.1542110767805; Tue, 13 Nov 2018 04:06:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542110767; cv=none; d=google.com; s=arc-20160816; b=KN0kCwjKlyiTbCOA+i6JXPwgBNikj80+gcbJ1YGlTwGRrPKY2GgojzxUqNWThqulhJ WmJ/KdNyYRHTkrazvLA1mzYWBEo8I93m47d4zgNPzDSJDaFKX07TgkQQ8ejQP7tvc7qG sDND1GOBHxbS6cH5oTXyc3Iuge0vHKD6fSYs3vb6B+z2z+cFKQ/lLmn2jjmA66OsMNb3 E2wSKTEu91qRSJqIwYxkVJi+v6PNSt4ONnDp0S/xRpENOhmbk098wmlFToa6R9I2LJw1 AW3ktDjd5xZTQKL41jxx7QOft6Fb9ILNNK7OuSajNzLUgycDl/GTFStxjFsSXFQOrP2r 1DHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=XbtLvikNCP705Gf70KgBIKRL1hyWt1NtZHC8XRJQv6w=; b=obYU362VxQuv20Y8+RzHd5/aqWoPUIe2D6DoxHH3aVNinxZj1PS6hd3uIXd1y4w+4W GjL7e7N4m5wExAVyMxMiU7FfvPrBLVLd5JMZNCX87Mnw+J245VIpP9nDO0gHGwx3Rl/r TUv0iTbfgG9NPvYnOkptpMtn7smV7fJEyOKA1FuWGeLzNW9zQydXCLDQjqr2DQgNVoac XmeGrW1JnjvlNlWjFGWUDm8WXKi8psgyieHUheHWgvhiqbcLQlihIy+9JgcB/osXRBZU /oj59pfdwKLmxnufF/4ByeM5sQXugwO2FcW6YVd4oyI2Yjqu6nvSmeBxg8L8XMDn8fD5 BfOA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id n20-v6si600111edt.3.2018.11.13.04.06.07 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Nov 2018 04:06:07 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id wADC67t8014880 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Nov 2018 13:06:07 +0100 Received: from md1za8fc.ad001.siemens.net ([144.145.12.226]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id wADC666k032150; Tue, 13 Nov 2018 13:06:07 +0100 Date: Tue, 13 Nov 2018 13:06:04 +0100 From: Henning Schild To: Cedric Hombourger Cc: Subject: Re: [PATCH v3 1/2] buildchroot+bootstrap: use rbinds for /dev and /proc Message-ID: <20181113130604.603e058e@md1za8fc.ad001.siemens.net> In-Reply-To: <1542085173-650-1-git-send-email-Cedric_Hombourger@mentor.com> References: <20181112103125.6884a9af@md1za8fc.ad001.siemens.net> <1542085173-650-1-git-send-email-Cedric_Hombourger@mentor.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: XYAh27IohCW2 Am Mon, 12 Nov 2018 20:59:32 -0800 schrieb Cedric Hombourger : > Bind mount the entire hierarchy for /dev and /proc as recommended in > Gentoo's chroot setup guide. > > Suggested-by: Henning Schild > Signed-off-by: Cedric Hombourger > --- > meta/classes/buildchroot.bbclass | 6 ++++-- > meta/classes/isar-bootstrap-helper.bbclass | 6 ++++-- > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 6 ++++-- > 3 files changed, 12 insertions(+), 6 deletions(-) > > diff --git a/meta/classes/buildchroot.bbclass > b/meta/classes/buildchroot.bbclass index 870d27c..26d5e80 100644 > --- a/meta/classes/buildchroot.bbclass > +++ b/meta/classes/buildchroot.bbclass > @@ -27,7 +27,9 @@ buildchroot_do_mounts() { > if ! grep -q ${BUILDCHROOT_DIR}/isar-apt /proc/mounts; then > mount --bind ${REPO_ISAR_DIR}/${DISTRO} > ${BUILDCHROOT_DIR}/isar-apt mount --bind ${DL_DIR} > ${BUILDCHROOT_DIR}/downloads > - mount -t devtmpfs -o mode=0755,nosuid devtmpfs > ${BUILDCHROOT_DIR}/dev > - mount -t proc none ${BUILDCHROOT_DIR}/proc > + mount --rbind /dev ${BUILDCHROOT_DIR}/dev > + mount --make-rslave ${BUILDCHROOT_DIR}/dev > + mount --rbind /proc ${BUILDCHROOT_DIR}/proc > + mount --make-rslave ${BUILDCHROOT_DIR}/proc /proc should be mounted as it was before. Henning > fi' > } > diff --git a/meta/classes/isar-bootstrap-helper.bbclass > b/meta/classes/isar-bootstrap-helper.bbclass index 1ac39db..62c0839 > 100644 --- a/meta/classes/isar-bootstrap-helper.bbclass > +++ b/meta/classes/isar-bootstrap-helper.bbclass > @@ -103,8 +103,10 @@ setup_root_file_system() { > sudo mount --bind ${REPO_BASE_DIR} ${ROOTFSDIR}/base-apt > fi > > - sudo mount -t devtmpfs -o mode=0755,nosuid devtmpfs > $ROOTFSDIR/dev > - sudo mount -t proc none $ROOTFSDIR/proc > + sudo mount --rbind /dev ${ROOTFSDIR}/dev > + sudo mount --make-rslave ${ROOTFSDIR}/dev > + sudo mount --rbind /proc ${ROOTFSDIR}/proc > + sudo mount --make-rslave ${ROOTFSDIR}/proc > > # Install packages: > E="${@ bb.utils.export_proxies(d)}" > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index > 592d042..cd93f6c 100644 --- > a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -241,8 > +241,10 @@ isar_bootstrap() { "${ROOTFSDIR}/chroot-setup.sh" "setup" > "${ROOTFSDIR}" > # update APT > - mount -t devtmpfs -o mode=0755,nosuid devtmpfs > ${ROOTFSDIR}/dev > - mount -t proc none ${ROOTFSDIR}/proc > + mount --rbind /dev ${BUILDCHROOT_DIR}/dev > + mount --make-rslave ${BUILDCHROOT_DIR}/dev > + mount --rbind /proc ${BUILDCHROOT_DIR}/proc > + mount --make-rslave ${BUILDCHROOT_DIR}/proc > > export DEBIAN_FRONTEND=noninteractive > chroot "${ROOTFSDIR}" /usr/bin/apt-get update -y