From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6621956091070644224 X-Received: by 2002:adf:b3d3:: with SMTP id x19-v6mr119810wrd.12.1542181497784; Tue, 13 Nov 2018 23:44:57 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:7ec2:: with SMTP id z185-v6ls2690927wmc.26.gmail; Tue, 13 Nov 2018 23:44:57 -0800 (PST) X-Google-Smtp-Source: AJdET5duEAam+DZUQNhu5Gr89Qfgh4GHGcQ6L8r11VbsK3AAx7MMi84vx/dbtwpD29GrU9kqLVF4 X-Received: by 2002:a1c:c48d:: with SMTP id u135-v6mr160035wmf.4.1542181497394; Tue, 13 Nov 2018 23:44:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542181497; cv=none; d=google.com; s=arc-20160816; b=HbR3zWEtoJ0aTSzOOkZjE+A9JbV6azRJqRmdJbbGdfVcL3O0SZelK7I1+GoZToQA01 YymJnuFV8YsitjK5J3Y8E22/OiehDwfJu1Vq8L6j4qMXkj4YHobcVhJYBOFq+1+4aGIJ XcbxwM6i/z2VaHptfEl0M4LoxQidG1WM8gMXw/QrUo5fprUpCAGXfHLbspkPz3afJr+e cHVE03aoPZ0Zs1gstBlQcUCvonjHWosVGJVyKOXb44tvnljMlBIXzICxf+LAfIfrI5bL 0dsUoYQxY1h56/2JLyqKZoICfmnrl8CdIjIpHr9wyZJgvEdXk8Lx/UC9OP9TEYdMgmT5 LKdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=G/0A/AFCmHvo+EkBXC3MDJBntobqRuf5aWIp/83F3Wk=; b=D7YfEWMTG1h1e7DSI/p8gHndCwa3R7ghJwbvKCSOzJUc9Kd0AFnT1FiYjK3nit1Q3G UwiztFuue4meYvEPFQlTvrvBxMXOKUqhgT0tsBdxtlgOSx4GGhoOZSlKhjVMFnGeeviI sW4X9e+kv1ExqYqlaOFGO/x8umMca0mi9Ci82tjrSwzM1Dr639FznO9d2DGFbVgJMEZE MGK6nRk6qq2iygrGz2Go2vYr5OJCHkdBk7TrJfZHMpQyg3q1Rky2rM03gTYD0Lyb94I5 02m5g1BISjJLAShUZbvbeUK+Bu7T/tIHSOZlvRvM6aw5FJ3+rbT2m8VTB4XfhNmck9H4 hZHw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id b12-v6si449409wme.1.2018.11.13.23.44.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Nov 2018 23:44:57 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id wAE7iu9R024536 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 14 Nov 2018 08:44:57 +0100 Received: from md1za8fc.ad001.siemens.net ([167.87.40.82]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id wAE7iuVh008458; Wed, 14 Nov 2018 08:44:56 +0100 Date: Wed, 14 Nov 2018 08:44:55 +0100 From: Henning Schild To: Cedric Hombourger Cc: Subject: Re: [PATCH v3 2/2] buildchroot: add sysfs mount since expected by some packages Message-ID: <20181114084455.2f46bf86@md1za8fc.ad001.siemens.net> In-Reply-To: <1542085173-650-2-git-send-email-Cedric_Hombourger@mentor.com> References: <20181112103125.6884a9af@md1za8fc.ad001.siemens.net> <1542085173-650-1-git-send-email-Cedric_Hombourger@mentor.com> <1542085173-650-2-git-send-email-Cedric_Hombourger@mentor.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: jtIz4WoV1GX+ Two more things to double-check. 1. Do the umount hooks we have in place clean up all the recursiveness? 2. Once we rbind mount sys the chroot will probably be allowed to mess with cgroups, tracing etc. Does a debootstrap change anything there, i.e. by installing systemd, libvirt, or perf? Henning Am Mon, 12 Nov 2018 20:59:33 -0800 schrieb Cedric Hombourger : > Some packages look for /sys when they configure, build or test > themselves (for instance golang-google-grpc). > > Signed-off-by: Cedric Hombourger > --- > meta/classes/buildchroot.bbclass | 2 ++ > meta/classes/image.bbclass | 1 + > meta/classes/isar-bootstrap-helper.bbclass | 3 +++ > meta/classes/isar-image.bbclass | 1 + > 4 files changed, 7 insertions(+) > > diff --git a/meta/classes/buildchroot.bbclass > b/meta/classes/buildchroot.bbclass index 26d5e80..d2f138f 100644 > --- a/meta/classes/buildchroot.bbclass > +++ b/meta/classes/buildchroot.bbclass > @@ -31,5 +31,7 @@ buildchroot_do_mounts() { > mount --make-rslave ${BUILDCHROOT_DIR}/dev > mount --rbind /proc ${BUILDCHROOT_DIR}/proc > mount --make-rslave ${BUILDCHROOT_DIR}/proc > + mount --rbind /sys ${BUILDCHROOT_DIR}/sys > + mount --make-rslave ${BUILDCHROOT_DIR}/sys > fi' > } > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index d033cf5..5806a59 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -110,6 +110,7 @@ do_populate_sdk() { > > sudo umount ${SDKCHROOT_DIR}/rootfs/dev || true > sudo umount ${SDKCHROOT_DIR}/rootfs/proc || true > + sudo umount ${SDKCHROOT_DIR}/rootfs/sys || true > > # Create SDK archive > sudo tar -C ${SDKCHROOT_DIR} > --transform="s|^rootfs|sdk-${DISTRO}-${DISTRO_ARCH}|" \ diff --git > a/meta/classes/isar-bootstrap-helper.bbclass > b/meta/classes/isar-bootstrap-helper.bbclass index 62c0839..7b2ddf3 > 100644 --- a/meta/classes/isar-bootstrap-helper.bbclass +++ > b/meta/classes/isar-bootstrap-helper.bbclass @@ -107,6 +107,9 @@ > setup_root_file_system() { sudo mount --make-rslave ${ROOTFSDIR}/dev > sudo mount --rbind /proc ${ROOTFSDIR}/proc > sudo mount --make-rslave ${ROOTFSDIR}/proc > + sudo install -m 755 -d ${ROOTFSDIR}/sys > + sudo mount --rbind /sys ${ROOTFSDIR}/sys > + sudo mount --make-rslave ${ROOTFSDIR}/sys > > # Install packages: > E="${@ bb.utils.export_proxies(d)}" > diff --git a/meta/classes/isar-image.bbclass > b/meta/classes/isar-image.bbclass index e0508be..356c97a 100644 > --- a/meta/classes/isar-image.bbclass > +++ b/meta/classes/isar-image.bbclass > @@ -61,6 +61,7 @@ isar_image_cleanup() { > sudo rmdir ${IMAGE_ROOTFS}/isar-apt > sudo umount -l ${IMAGE_ROOTFS}/dev > sudo umount -l ${IMAGE_ROOTFS}/proc > + sudo umount -l ${IMAGE_ROOTFS}/sys > sudo rm -f > "${IMAGE_ROOTFS}/etc/apt/apt.conf.d/55isar-fallback.conf" } >