From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6623002413686063104 X-Received: by 2002:ac2:4316:: with SMTP id l22mr199119lfh.4.1542204701804; Wed, 14 Nov 2018 06:11:41 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:554c:: with SMTP id j73-v6ls1311724ljb.4.gmail; Wed, 14 Nov 2018 06:11:41 -0800 (PST) X-Google-Smtp-Source: AJdET5dX+1Nk5AiV3uY2ktMHeheFqR2rl2aDyhUFgQZOpYXdzlJ2kcWISR/G+Ybluc6LUoRqa8lr X-Received: by 2002:a2e:5bdc:: with SMTP id m89-v6mr221949lje.14.1542204701343; Wed, 14 Nov 2018 06:11:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542204701; cv=none; d=google.com; s=arc-20160816; b=Pwb2IeJ2SauiQ+Su1qvDYG4RUKE1YRtyFxjJFddPDCcEofkfRq3L3bA6+yrhj1zdDl 2Fywbs1jMK8dOemunOhoMuN2Nz6sGdyguM6IJRbyoQnRsdjM3sUQuA6WZaVMH6ELYxge 2bygLIk8CdXJjrrkSVEMfdM9dTGmd5Sp3cKkwYbijnAI+IuhdhIkACilMB0z+xWR95Zz 07AAijRKZVSNWXxOatVttCGowsrJ3BhTrEhkSiFVU1qX3o47MfhYtmw98RN+wdoICdOS q/7WrF/r7tRqKgEbcdECnMD7Ghb49UF59acEsed2jhN47Z3+SFvHwB55DSllu5ClB2Os 477Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=ZOZns4OK0+KtLNr0tiNIDEP5b8QJ66bOQSoFVBnzzY4=; b=bYTIqgXek2aAvwxem2a80iYSKBZmae1nuLqJScjLVqfxz2r3ig3rA9ttuM+mA+o6Xe QEp0Pe8C70r9YjhufdkI8dl5YXltOzYit7Rmus9/Tv0JdXfIoqxUM7TfxCSZ0W9a+fPd dZApqu747j0tGb61IDjRe7624qXtFLlKFbR/0M/42nvcHFSYMydqbZeZClfnyiPTXHhP sbLpwPvjanVzgUPLX2OW6XDeKJJPrUXNOLMQ5YLr5ZAD0FPMqGGKZxxRYZsSzf4MmlhD 2r5uWG0wUitGkJSt9VnVd1RRlsks8a7QYCO4omWgEAvC6BLeoaK3lSBgwvwf5o7pfWdw glLw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id 205si701207lfb.2.2018.11.14.06.11.41 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Nov 2018 06:11:41 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id wAEEBeK8010187 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 14 Nov 2018 15:11:40 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.0.37]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id wAEEBeDT028283; Wed, 14 Nov 2018 15:11:40 +0100 Date: Wed, 14 Nov 2018 15:11:39 +0100 From: Henning Schild To: Jan Kiszka Cc: isar-users Subject: Re: [PATCH 2/3] Revert "Change ownership of WORKDIR prior to unpacking" Message-ID: <20181114151139.6ff01f5a@md1za8fc.ad001.siemens.net> In-Reply-To: <1b49699a-e4a5-83fb-f631-de56c7ee266a@siemens.com> References: <20181112155149.24215-1-henning.schild@siemens.com> <20181112155149.24215-3-henning.schild@siemens.com> <6852a6f3-79a6-7320-abae-5a168fcada59@siemens.com> <06ac3f88-0104-6bd0-711c-f75fec4e4a6f@siemens.com> <1b49699a-e4a5-83fb-f631-de56c7ee266a@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-TUID: XBmQbHQGegSh Am Wed, 14 Nov 2018 14:58:57 +0100 schrieb Jan Kiszka : > On 14.11.18 14:23, Jan Kiszka wrote: > > On 14.11.18 14:10, Jan Kiszka wrote: =20 > >> On 12.11.18 16:51, Henning Schild wrote: =20 > >>> We do not build as root anymore and the non-root uid/gid are now > >>> in sync between inside and outside the chroot. > >>> > >>> This reverts commit 624b7c484bf59940ac2a4114018f7d56892dc05e. > >>> --- > >>> =C2=A0=C2=A0 meta/classes/base.bbclass | 5 ----- > >>> =C2=A0=C2=A0 1 file changed, 5 deletions(-) > >>> > >>> diff --git a/meta/classes/base.bbclass b/meta/classes/base.bbclass > >>> index fce1084..d4082de 100644 > >>> --- a/meta/classes/base.bbclass > >>> +++ b/meta/classes/base.bbclass > >>> @@ -120,17 +120,12 @@ do_unpack[stamp-extra-info] =3D > >>> "${DISTRO}-${DISTRO_ARCH}" # Unpack package and put it into > >>> working directory python do_unpack() { > >>> -=C2=A0=C2=A0=C2=A0 import subprocess > >>> - > >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 src_uri =3D (d.getVar('SRC_URI',= True) or "").split() > >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if len(src_uri) =3D=3D 0: > >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return > >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rootdir =3D d.getVar('WORKDIR', = True) > >>> -=C2=A0=C2=A0=C2=A0 uid =3D str(os.getuid()) > >>> -=C2=A0=C2=A0=C2=A0 subprocess.call('sudo chown -R ' + uid + ' ' + ro= otdir, > >>> shell=3DTrue) - > >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 try: > >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 fetcher = =3D bb.fetch2.Fetch(src_uri, d) > >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 fetcher.= unpack(rootdir) > >>> =20 > >> > >> This possibly causes this regression: > >> > >> ERROR: expand-on-first-boot-1.0-r0 do_install: Function failed: > >> do_install (log file is located at=20 > >> /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/log.d= o_install.263)=20 > >> > >> ERROR: Logfile of failure stored in:=20 > >> /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/log.d= o_install.263=20 > >> > >> Log data follows: > >> | DEBUG: Executing shell function do_install > >> | install: cannot remove=20 > >> '/work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/image//li= b/systemd/system/expand-on-first-boot.service':=20 > >> Permission denied > >> | WARNING: exit code 1 from a shell command. > >> | ERROR: Function failed: do_install (log file is located at=20 > >> /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/log.d= o_install.263)=20 > >> > >> =20 > >=20 > > OK, that wasn't a "clean" re-build (rather a rebuild after the Isar > > update). Retesting with the same Isar version for build 1 and 2. > > =20 Arghh ... on a side-note. I have a few Isar-CI partial rebuild patches in a queue, they target both dpkg and dpkg-raw. > It persists, at least for dpkg-raw, and that is likely because of the > chroot we do for that package. Yes. > How does normal dpkg get away without chroot now and still produce > the right ownership when installing a package? Can we adopt that? Probably fakeroot, i will look into using that for creating the raw package. Henning > Jan >=20