From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6623741503488393216 X-Received: by 2002:a7b:cd90:: with SMTP id y16mr452884wmj.19.1542209997199; Wed, 14 Nov 2018 07:39:57 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:e452:: with SMTP id t18-v6ls4263301wrm.11.gmail; Wed, 14 Nov 2018 07:39:56 -0800 (PST) X-Google-Smtp-Source: AJdET5fUbONyWbLrgEI0XzuyjfPYSqf6NY8yrJ5w5XSfE834oxNGWkGq772ULJGPJn022IVMQTR2 X-Received: by 2002:adf:e948:: with SMTP id m8-v6mr461685wrn.6.1542209996779; Wed, 14 Nov 2018 07:39:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542209996; cv=none; d=google.com; s=arc-20160816; b=l6aPx7RBA6TNp33CeSXqpVG4XUgBjDlDJXaZGQsUG2EJ5pzuwT0KTIE/F5PafKlwHs 7vkiHGnFNd1t7AJ6hTDUoaXfUGBnIAehBeiihP+GxLdPJDe+4hF4cxra6LpIRksu0PD8 CgHy/mNBA4UQIPSicqJUCt57rDrBYIFjsnaL6fTh2yr0j4QfW8atOLAZQTQl32ri058c UoyK3ED9Ov+sXyH0ga0CCt5/HJumB/UXHe3xUw+gt2LcpCV3+t2O+kX9KlDDo2W1FW0n LSrbvZzZ0whkHC4uaVpzlED4jBeO6kQWoOAFTblUCQdxSt8+JgCDEyh/FEfd6X4DoYiH Nctg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=A1kgE3OkUExNZKKuXg7MMbf5e2oeWSeghi1V38P6zHQ=; b=xeS/yEmeQgQ+YZ+WLdlHP9uPtOntpvWIUrZNTX+NRWqPK7W0mmfzcELIH62/ert3nl Hsbsv4Dizn+z+TrOXt9q/i0CVha9npgsrmh/oxL54iE6MjzI9Y3Qs3b0WDAkl99MrCmD JEKqQfdpemubdTFJkqng0q2YbUpGx/Gt+6NxbBXjeaHABf/HRT6gd6iOBhBa7InNkOtq aQI0zRs2/LwZr5ObCD06pYHNR5tqJjA3LprvW0OtMOgzMeGewnf8+/FXOPrWfBoyskrR 5joJhV4nB96QC8+4ZypM9uG68Ls6Qw90FIrx7x3zDAcJ+rFLujNL/gdMA/qWiPZdEEIY Hx+w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id h137-v6si626060wmd.1.2018.11.14.07.39.56 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Nov 2018 07:39:56 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id wAEFduhE015682 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 14 Nov 2018 16:39:56 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.0.37]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id wAEFduNF018419; Wed, 14 Nov 2018 16:39:56 +0100 From: Henning Schild To: isar-users Cc: Jan Kiszka , Henning Schild Subject: [PATCH] meta/dpkg-raw: do_install into a fresh directory every time Date: Wed, 14 Nov 2018 16:39:55 +0100 Message-Id: <20181114153955.13232-1-henning.schild@siemens.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: ceFi4BGfkfG5 Permission problems revealed that we always packaged the sum of possibly many rebuilds and maybe recipe versions. do_install should always start working on an empty $D to ensure that the package only contains output of the current build. Reported-by: Jan Kiszka Signed-off-by: Henning Schild --- meta/classes/dpkg-raw.bbclass | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/meta/classes/dpkg-raw.bbclass b/meta/classes/dpkg-raw.bbclass index d662422..968e28d 100644 --- a/meta/classes/dpkg-raw.bbclass +++ b/meta/classes/dpkg-raw.bbclass @@ -8,13 +8,21 @@ MAINTAINER ?= "FIXME Unknown maintainer" D = "${WORKDIR}/image/" +# make sure we start with a fresh ${D} every single time +do_fresh_image() { + sudo rm -rf ${D} +} + +do_fresh_image[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" +addtask fresh_image after do_unpack before do_install + # Populate folder that will be picked up as package do_install() { bbnote "Put your files for this package in ${D}" } do_install[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" -addtask install after do_unpack before do_prepare_build +addtask install after do_fresh_image before do_prepare_build deb_package_prepare() { sudo rm -rf ${D}/DEBIAN -- 2.19.1