From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6623002413686063104 X-Received: by 2002:a2e:165c:: with SMTP id 28-v6mr650489ljw.25.1542270519199; Thu, 15 Nov 2018 00:28:39 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9691:: with SMTP id q17-v6ls100961lji.2.gmail; Thu, 15 Nov 2018 00:28:38 -0800 (PST) X-Google-Smtp-Source: AJdET5fu2xjPyLYRuXSaguzcJr5qyxByZbJMvg1cpyWzgYwVCrHBOdO7dkCOMH+w9WUHmxH5+cGp X-Received: by 2002:a2e:8199:: with SMTP id e25-v6mr655712ljg.15.1542270518721; Thu, 15 Nov 2018 00:28:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542270518; cv=none; d=google.com; s=arc-20160816; b=chQLCn1u7j813+y+L7lmAFXoPNyZCnmWtCRjmxEpBGU09BqbxUnqWLghgWgmvCgeln WPpJVHU0DAsJgWEVMVvsupsB4OfYKuc2V+I4btCRYHaH18/tSqa8Pkxa4Q7otpm9ZTEB wU0XGOiNob5Ykk32AdnmosTxZHvMjmApPmGUCriI3wM5HMuNLEtrR38RHD03dKJPHQss 2DAZ6zQ+/1A3/cUpv4TQfKVRBmNGH5j8092rH/KpRbckO4e8iVX0DXr3/7e3u6fl72I/ AHn0R0r9fBHPzaKpls9unu29Kv4h/S7dITjDh9INNLsnjKG6bZMkSZS1ZJsOFk+Jon7P V+Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=xdTeYEv1zlHA31huxZ0Q9Iebcv9RalyAiD3atBxd1Xc=; b=nlh4+d6fayrwo00Qox7p4cPscXHe0vjnQRaSSMQCnsyAZWLM+9p96sKFakCMctDUPP 9YT5fLHyPQ3GC7SOGIGRP1R2g82OSVh4eIFSEqpoRXlPptVpL58rKWNh8ZEMoGbkFSDl G54dX7AgqreANrNcK/TkkdzwFCV4tGQDRGpXLBLCGhwtYHh7oKwQysE+HSdWdPcPuEy/ 3zVWkH2oH/27GQzj6/3xig6/zih0Rb3gFzzRiZ409mT91bcJWsOIAiQ7u1V54ZcAlbjW d3pdBBxriGg9eKIVzTBNm/hp906fU9ZWob6FtQnUZ68Z7mhsQby2GRckIFo7VG5ZOz+v DDQQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id y66-v6si664285lje.0.2018.11.15.00.28.38 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Nov 2018 00:28:38 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id wAF8ScwG030799 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 15 Nov 2018 09:28:38 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.0.37]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id wAF8SbCv002998; Thu, 15 Nov 2018 09:28:37 +0100 Date: Thu, 15 Nov 2018 09:28:37 +0100 From: Henning Schild To: Jan Kiszka Cc: isar-users Subject: Re: [PATCH 2/3] Revert "Change ownership of WORKDIR prior to unpacking" Message-ID: <20181115092837.5e61f393@md1za8fc.ad001.siemens.net> In-Reply-To: <40092afd-a891-0b0e-4dd2-9752f16f59f1@siemens.com> References: <20181112155149.24215-1-henning.schild@siemens.com> <20181112155149.24215-3-henning.schild@siemens.com> <6852a6f3-79a6-7320-abae-5a168fcada59@siemens.com> <06ac3f88-0104-6bd0-711c-f75fec4e4a6f@siemens.com> <1b49699a-e4a5-83fb-f631-de56c7ee266a@siemens.com> <20181114151139.6ff01f5a@md1za8fc.ad001.siemens.net> <20181114164355.742be0bd@md1za8fc.ad001.siemens.net> <40092afd-a891-0b0e-4dd2-9752f16f59f1@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-TUID: kiN4oECzFwV5 Am Wed, 14 Nov 2018 16:45:36 +0100 schrieb Jan Kiszka : > On 14.11.18 16:43, Henning Schild wrote: > > Am Wed, 14 Nov 2018 15:11:39 +0100 > > schrieb "[ext] Henning Schild" : > > =20 > >> Am Wed, 14 Nov 2018 14:58:57 +0100 > >> schrieb Jan Kiszka : > >> =20 > >>> On 14.11.18 14:23, Jan Kiszka wrote: =20 > >>>> On 14.11.18 14:10, Jan Kiszka wrote: =20 > >>>>> On 12.11.18 16:51, Henning Schild wrote: =20 > >>>>>> We do not build as root anymore and the non-root uid/gid are > >>>>>> now in sync between inside and outside the chroot. > >>>>>> > >>>>>> This reverts commit 624b7c484bf59940ac2a4114018f7d56892dc05e. > >>>>>> --- > >>>>>> =C2=A0=C2=A0 meta/classes/base.bbclass | 5 ----- > >>>>>> =C2=A0=C2=A0 1 file changed, 5 deletions(-) > >>>>>> > >>>>>> diff --git a/meta/classes/base.bbclass > >>>>>> b/meta/classes/base.bbclass index fce1084..d4082de 100644 > >>>>>> --- a/meta/classes/base.bbclass > >>>>>> +++ b/meta/classes/base.bbclass > >>>>>> @@ -120,17 +120,12 @@ do_unpack[stamp-extra-info] =3D > >>>>>> "${DISTRO}-${DISTRO_ARCH}" # Unpack package and put it into > >>>>>> working directory python do_unpack() { > >>>>>> -=C2=A0=C2=A0=C2=A0 import subprocess > >>>>>> - > >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 src_uri =3D (d.getVar('SRC_U= RI', True) or "").split() > >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if len(src_uri) =3D=3D 0: > >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 retu= rn > >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 rootdir =3D d.getVar('WORKDI= R', True) > >>>>>> -=C2=A0=C2=A0=C2=A0 uid =3D str(os.getuid()) > >>>>>> -=C2=A0=C2=A0=C2=A0 subprocess.call('sudo chown -R ' + uid + ' ' += rootdir, > >>>>>> shell=3DTrue) - > >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 try: > >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 fetc= her =3D bb.fetch2.Fetch(src_uri, d) > >>>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 fetc= her.unpack(rootdir) > >>>>>> =20 > >>>>> > >>>>> This possibly causes this regression: > >>>>> > >>>>> ERROR: expand-on-first-boot-1.0-r0 do_install: Function failed: > >>>>> do_install (log file is located at > >>>>> /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/lo= g.do_install.263) > >>>>> > >>>>> ERROR: Logfile of failure stored in: > >>>>> /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/lo= g.do_install.263 > >>>>> > >>>>> Log data follows: > >>>>> | DEBUG: Executing shell function do_install > >>>>> | install: cannot remove > >>>>> '/work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/image/= /lib/systemd/system/expand-on-first-boot.service': > >>>>> Permission denied > >>>>> | WARNING: exit code 1 from a shell command. > >>>>> | ERROR: Function failed: do_install (log file is located at > >>>>> /work/build/tmp/work/ebsy-arm64/expand-on-first-boot-1.0-r0/temp/lo= g.do_install.263) > >>>>> > >>>>> =20 > >>>> > >>>> OK, that wasn't a "clean" re-build (rather a rebuild after the > >>>> Isar update). Retesting with the same Isar version for build 1 > >>>> and 2. =20 > >> > >> Arghh ... on a side-note. I have a few Isar-CI partial rebuild > >> patches in a queue, they target both dpkg and dpkg-raw. > >> =20 > >>> It persists, at least for dpkg-raw, and that is likely because of > >>> the chroot we do for that package. =20 > >> > >> Yes. =20 > >=20 > > That actually revealed that we kept collecting changes in ${D} and > > never cleaned it before install. I just sent a patch fixing that. > >=20 > > Next step will probably be to make the raw class use standard > > debian/rules and just take the long dpkg-buildpkg route. Should not > > be too hard to just write a debian/ folder that just does "make > > install". Will look into that ... > > =20 >=20 > Thanks, looking forward to test everything. I have a working prototype of the idea, where dpkg-raw is basically dpkg with a debianization step in front of it. Still looking into the details because we now have a lot of debhelpers enforcing quality standards. And the debianization looks like it could make it into a general lib that could be reused to debianize random sources. Henning > Jan >=20