From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6623741503488393216 X-Received: by 2002:adf:9d83:: with SMTP id p3-v6mr313270wre.31.1542301045428; Thu, 15 Nov 2018 08:57:25 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:e8d1:: with SMTP id k17ls2364257wrn.6.gmail; Thu, 15 Nov 2018 08:57:25 -0800 (PST) X-Google-Smtp-Source: AFSGD/WGqKFvpLIuPvm/AC3/UOEknIvZ+283jwDSz0t1ZKI/iu3KgIlp8MYlAFFADrzaTBCqolyz X-Received: by 2002:adf:fa82:: with SMTP id h2-v6mr308488wrr.18.1542301045025; Thu, 15 Nov 2018 08:57:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542301045; cv=none; d=google.com; s=arc-20160816; b=rAew4u2B2C0HlVu2yl91wkB1eerHZnIX6baz4pCn2N/QqvN7MrahBDplj/jT1NNbOC tLPooGXzJKTOaz5CIn1B2GaldH/yhAniX5n//K/HlAYROmaaBmhLp99+rEhkIsmE5eOY 3r5T3omtJPNmSgwNqWuFeB6cWj8yTUTc9howMpvAmds25Wkq9TVHEWYvuprs+0OLzUH/ NxPKuZmKw3D5de8ynEB8nLPou5B5WM5/4tZjxaEO7ZnTOughzgRbA2zhby35BxwN9M0R qYhgw7JTKEQlLDSNKVSJPy/ieVx5dVxwpnBHvp0xfPw7mq6yO3GO6m287rkUOgKPeA6n kOfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=fp1yK/MzS2r3mUZ2c4HZ9YFTZ82UZxW6/p7BWiPZQGQ=; b=L3p4IGEy3C+Ootc0CTXV3ue2mWcSbUdKoSmjr75aytffOxPvoNiyXzSgSGflNaZ95b iSYy7fda//6kpG9rLTFNTR0W0sxgKdX9EGafgZUzxAkVCpGa1PSdSn95fnfgLevQMvNn dWLSqmderYmKfETg5/QgKMF6i+rHVMyGLEYLuJ3p7JpXybZPaGZdbK/6Bn600pZAjrwC uIghEPTvIK1U1GxAgKe8ghrhi7IpErGnyK9YouGESP1F36IuxmZmIheWMJw/TvA7DURa x/2pP7Mn+kwnmrxXpc39Ysvko4n8buDkC8YBwR1Jcw1RTeRF5syvl3R66yX6CAx0DUmc 1xuA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id u13-v6si910847wrn.3.2018.11.15.08.57.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Nov 2018 08:57:25 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id wAFGvOia008685 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 15 Nov 2018 17:57:24 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.0.37]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id wAFGvOoP012044; Thu, 15 Nov 2018 17:57:24 +0100 From: Henning Schild To: isar-users Cc: Jan Kiszka , Henning Schild Subject: [PATCH v2] meta/dpkg-raw: do_install into a fresh directory every time Date: Thu, 15 Nov 2018 17:57:23 +0100 Message-Id: <20181115165723.11192-1-henning.schild@siemens.com> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181114153955.13232-1-henning.schild@siemens.com> References: <20181114153955.13232-1-henning.schild@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: OdnMhszo0482 Permission problems revealed that we always packaged the sum of possibly many rebuilds and maybe recipe versions. do_install should always start working on an empty $D to ensure that the package only contains output of the current build. Reported-by: Jan Kiszka Signed-off-by: Henning Schild --- Changes in v2: - use prefunc instead of a bitbake task meta/classes/dpkg-raw.bbclass | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/meta/classes/dpkg-raw.bbclass b/meta/classes/dpkg-raw.bbclass index d662422..b2bea60 100644 --- a/meta/classes/dpkg-raw.bbclass +++ b/meta/classes/dpkg-raw.bbclass @@ -8,11 +8,18 @@ MAINTAINER ?= "FIXME Unknown maintainer" D = "${WORKDIR}/image/" +# make sure we start with a fresh ${D} on a rebuild +remove_old_image() { + sudo rm -rf ${D} + mkdir -p ${D} +} + # Populate folder that will be picked up as package do_install() { bbnote "Put your files for this package in ${D}" } +do_install[prefuncs] = 'remove_old_image' do_install[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" addtask install after do_unpack before do_prepare_build -- 2.19.1