From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6621956091070644224 X-Received: by 2002:a17:906:d212:: with SMTP id w18-v6mr116873ejz.15.1542619525263; Mon, 19 Nov 2018 01:25:25 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:46ce:: with SMTP id k14-v6ls121060ejs.5.gmail; Mon, 19 Nov 2018 01:25:24 -0800 (PST) X-Google-Smtp-Source: AJdET5fptFwLXdTejyfqNXsM1IIRCdYXFgt/alNWZEPeZurT5cSf06nGfBtCfsHpNLzDCSOdhwBe X-Received: by 2002:a17:906:2445:: with SMTP id a5-v6mr2034113ejb.8.1542619524785; Mon, 19 Nov 2018 01:25:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542619524; cv=none; d=google.com; s=arc-20160816; b=0cB1aYOPvvn9CjHJCT6MInCv4HF6mQnpo78oaSFB5GB3Lp4dtQbMqJ/BCXbehKZ+b5 ML9VCOuX6Fljj+oNNl0Q8XICu6+UV1QmwT+Pjq2w1N4uBBN17zmHucdt2KYhbqbXO6u7 vEuzxgcj7ZrZIwEueNoUGJ4iTDkvXHEq+RWsQEIF6wFUEbTL9VJfHy20GKy5lG34jQXV XHkI+/vrM/3iMjluoetV0zjLep+2L9jE83TOHsGKmxPF2cbMm2b9mjjUDDBooV3cLvZN gPHLCoEd9BRPxhMxhBZWsQLk3TNeSOUyL8IE5Y4aPL4k1IkVEld1tN9bn0KOWcSkUq2t wO1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=e/m7Koz8S+pKXQMcbMyzpBjrKd91IZbU9/Y1gi9nR9U=; b=OKYw+f7N7AirPvSU2Dlq3/e+77sQAUiduf6WfBadmxzvrCYNEN/KsD6q8wIKw/8neO 088Gan17YBLfdlcFW88phl6tXkeuJ1ivwQ+TAEFc9MH/ZsbFkwcpynP2CfiZdUO/tY+w A0JQGlyo1GchujEL7njlCmRQl9iJU4e1CYdWYWh0Z9cDnCa4j4F/So8u+vgK32MzMaG5 1VNGUe25UxSTq7b6Kms5/mxa2SHhbJR+RUauuAKGYmhByYvxFvDK1bMdhXE+FLMmEwzL D5QjoiKPeKLWT6d2lr04Le0SnjHDGbboVp6O6JmrRomLYg2mtDAz9LbjtwE/Oia4qBVg aSyQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id k25si96021edd.1.2018.11.19.01.25.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Nov 2018 01:25:24 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id wAJ9POXP013075 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Nov 2018 10:25:24 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.68.180]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id wAJ9PO4a031699; Mon, 19 Nov 2018 10:25:24 +0100 Date: Mon, 19 Nov 2018 10:25:22 +0100 From: Henning Schild To: Cedric Hombourger Cc: Subject: Re: [PATCH v5 1/2] buildchroot+bootstrap: rbind mount for /dev Message-ID: <20181119102522.5606900d@md1za8fc.ad001.siemens.net> In-Reply-To: <1542466619-1689-2-git-send-email-Cedric_Hombourger@mentor.com> References: <1542385896-879-3-git-send-email-Cedric_Hombourger@mentor.com> <1542466619-1689-1-git-send-email-Cedric_Hombourger@mentor.com> <1542466619-1689-2-git-send-email-Cedric_Hombourger@mentor.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: D3MkvwXMwzWw Am Sat, 17 Nov 2018 15:56:58 +0100 schrieb Cedric Hombourger : > Bind mount the entire hierarchy for /dev as recommended in Gentoo's > chroot setup guide. > > Suggested-by: Henning Schild > Signed-off-by: Cedric Hombourger > --- > meta/classes/buildchroot.bbclass | 3 ++- > meta/classes/image.bbclass | 2 +- > meta/classes/isar-bootstrap-helper.bbclass | 3 ++- > meta/classes/isar-image.bbclass | 2 +- > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 5 +++-- > 5 files changed, 9 insertions(+), 6 deletions(-) > > diff --git a/meta/classes/buildchroot.bbclass > b/meta/classes/buildchroot.bbclass index 34b7f59..a8964c6 100644 > --- a/meta/classes/buildchroot.bbclass > +++ b/meta/classes/buildchroot.bbclass > @@ -27,7 +27,8 @@ buildchroot_do_mounts() { > if ! grep -q ${BUILDCHROOT_DIR}/isar-apt /proc/mounts; then > mount --bind ${REPO_ISAR_DIR}/${DISTRO} > ${BUILDCHROOT_DIR}/isar-apt mount --bind ${DL_DIR} > ${BUILDCHROOT_DIR}/downloads > - mount -t devtmpfs -o mode=0755,nosuid devtmpfs > ${BUILDCHROOT_DIR}/dev > + mount --rbind /dev ${BUILDCHROOT_DIR}/dev > + mount --make-rslave ${BUILDCHROOT_DIR}/dev > mount -t proc none ${BUILDCHROOT_DIR}/proc > fi > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass > index d033cf5..01e045d 100644 > --- a/meta/classes/image.bbclass > +++ b/meta/classes/image.bbclass > @@ -108,7 +108,7 @@ do_populate_sdk() { > # Purge apt cache to make image slimmer > sudo rm -rf ${SDKCHROOT_DIR}/rootfs/var/cache/apt/* > > - sudo umount ${SDKCHROOT_DIR}/rootfs/dev || true > + sudo umount -R ${SDKCHROOT_DIR}/rootfs/dev || true > sudo umount ${SDKCHROOT_DIR}/rootfs/proc || true > > # Create SDK archive > diff --git a/meta/classes/isar-bootstrap-helper.bbclass > b/meta/classes/isar-bootstrap-helper.bbclass index e6a46ce..1d3e5f6 > 100644 --- a/meta/classes/isar-bootstrap-helper.bbclass > +++ b/meta/classes/isar-bootstrap-helper.bbclass > @@ -103,7 +103,8 @@ setup_root_file_system() { > sudo mount --bind ${REPO_BASE_DIR} ${ROOTFSDIR}/base-apt > fi > > - sudo mount -t devtmpfs -o mode=0755,nosuid devtmpfs > $ROOTFSDIR/dev > + sudo mount --rbind /dev ${ROOTFSDIR}/dev > + sudo mount --make-rslave ${ROOTFSDIR}/dev > sudo mount -t proc none $ROOTFSDIR/proc > > # Refresh /etc/resolv.conf > diff --git a/meta/classes/isar-image.bbclass > b/meta/classes/isar-image.bbclass index e0508be..703b3e7 100644 > --- a/meta/classes/isar-image.bbclass > +++ b/meta/classes/isar-image.bbclass > @@ -59,7 +59,7 @@ isar_image_cleanup() { > -maxdepth 1 -name 'qemu-*-static' -type f -delete > sudo umount -l ${IMAGE_ROOTFS}/isar-apt > sudo rmdir ${IMAGE_ROOTFS}/isar-apt > - sudo umount -l ${IMAGE_ROOTFS}/dev > + sudo umount -R -l ${IMAGE_ROOTFS}/dev > sudo umount -l ${IMAGE_ROOTFS}/proc > sudo rm -f > "${IMAGE_ROOTFS}/etc/apt/apt.conf.d/55isar-fallback.conf" } > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index > 21454b0..dfd649e 100644 --- > a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -183,7 > +183,7 @@ isar_bootstrap() { set -e > if [ ! -e "${DEPLOY_ISAR_BOOTSTRAP}" ]; then > if [ -e "${ROOTFSDIR}" ]; then > - umount -l "${ROOTFSDIR}/dev" || true > + umount -R -l "${ROOTFSDIR}/dev" || true > umount -l "${ROOTFSDIR}/proc" || true > rm -rf "${ROOTFSDIR}" umount -R ${ROOTFSDIR} ? Maybe as a third patch on top. Henning > fi > @@ -243,7 +243,8 @@ isar_bootstrap() { > "${ROOTFSDIR}/chroot-setup.sh" "setup" "${ROOTFSDIR}" > > # update APT > - mount -t devtmpfs -o mode=0755,nosuid devtmpfs > ${ROOTFSDIR}/dev > + mount --rbind /dev ${BUILDCHROOT_DIR}/dev > + mount --make-rslave ${BUILDCHROOT_DIR}/dev > mount -t proc none ${ROOTFSDIR}/proc > > export DEBIAN_FRONTEND=noninteractive