public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Cedric Hombourger <Cedric_Hombourger@mentor.com>
Cc: <isar-users@googlegroups.com>
Subject: Re: [PATCH v5 0/2] rbind mounts for /dev and /sys
Date: Mon, 19 Nov 2018 10:27:25 +0100	[thread overview]
Message-ID: <20181119102725.10e8b13e@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <1542466619-1689-1-git-send-email-Cedric_Hombourger@mentor.com>

Looking at how many places we have to change to get the mounts right,
we most likely want all that logic in a function. I recently had issues
with an imager class in a layer, that also carries mounting logic.

But i guess that would be a cleanup step on top.

Henning

Am Sat, 17 Nov 2018 15:56:57 +0100
schrieb Cedric Hombourger <Cedric_Hombourger@mentor.com>:

> Some of the packages I have been rebuilding within Isar require /sys
> mounted. For instance, golang-google-grpc runs some package tests
> after it builds itself and reads properties from /sys/class/dmi.
> 
> The initial version of this patch series only added a mount of /sys.
> Henning then suggested that we follow Gentoo's guidelines for
> chroots. As such, this patch series is now mounting /dev and /sys as
> rbind mounts but leaves /proc as a regular procfs mount (like Gentoo
> does).
> 
> ChangeLog:
> 
> v5: cover letter added as suggested by Jan (private e-mail)
> v4: limit rbind mounts to /dev and /sys, leave /proc as a regular
> mount v3: rbind mounts for /dev, /proc and /sys, add explicit umount
> calls v2: create /sys directory
> v1: initial submission, simply mount /sys
> 
> Cedric Hombourger (2):
>   buildchroot+bootstrap: rbind mount for /dev
>   buildchroot: add sysfs mount since expected by some packages
> 
>  meta/classes/buildchroot.bbclass                    | 5 ++++-
>  meta/classes/image.bbclass                          | 3 ++-
>  meta/classes/isar-bootstrap-helper.bbclass          | 6 +++++-
>  meta/classes/isar-image.bbclass                     | 3 ++-
>  meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 8 ++++++--
>  5 files changed, 19 insertions(+), 6 deletions(-)
> 


  parent reply	other threads:[~2018-11-19  9:27 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-09 20:11 [PATCH] buildchroot: add sysfs mount since expected by some packages Cedric Hombourger
2018-11-10  7:15 ` [PATCH v2] " Cedric Hombourger
2018-11-12  9:31   ` Henning Schild
2018-11-13  4:59     ` [PATCH v3 1/2] buildchroot+bootstrap: use rbinds for /dev and /proc Cedric Hombourger
2018-11-13  4:59       ` [PATCH v3 2/2] buildchroot: add sysfs mount since expected by some packages Cedric Hombourger
2018-11-13 10:43         ` chombourger
2018-11-13 10:59           ` Jan Kiszka
2018-11-13 12:07         ` Henning Schild
2018-11-13 12:37           ` Hombourger, Cedric
2018-11-13 12:59             ` Jan Kiszka
2018-11-14  7:44         ` Henning Schild
2018-11-16 16:29           ` chombourger
2018-11-16 16:31             ` [PATCH v4 1/2] buildchroot+bootstrap: rbind mount for /dev Cedric Hombourger
2018-11-16 16:31               ` [PATCH v3 1/2] buildchroot+bootstrap: use rbinds for /dev and /proc Cedric Hombourger
2018-11-16 16:31               ` [PATCH v4 2/2] buildchroot: add sysfs mount since expected by some packages Cedric Hombourger
2018-11-17 14:56                 ` [PATCH v5 0/2] rbind mounts for /dev and /sys Cedric Hombourger
2018-11-17 14:56                   ` [PATCH v5 1/2] buildchroot+bootstrap: rbind mount for /dev Cedric Hombourger
2018-11-19  9:25                     ` Henning Schild
2018-11-20 12:36                       ` chombourger
2018-11-17 14:56                   ` [PATCH v5 2/2] buildchroot: add sysfs mount since expected by some packages Cedric Hombourger
2018-11-19  9:24                     ` Henning Schild
2018-11-20 12:40                       ` [PATCH v6 0/2] rbind mounts for /dev and /sys Cedric Hombourger
2018-11-20 12:40                         ` [PATCH v6 1/2] buildchroot+bootstrap: rbind mount for /dev Cedric Hombourger
2018-11-20 12:40                         ` [PATCH v6 2/2] buildchroot: add sysfs mount since expected by some packages Cedric Hombourger
2018-11-22 16:08                           ` chombourger
2018-11-23 14:13                         ` [PATCH v6 0/2] rbind mounts for /dev and /sys Maxim Yu. Osipov
2018-11-27 14:45                         ` Maxim Yu. Osipov
2018-11-27 14:48                           ` Hombourger, Cedric
2018-11-29  8:22                             ` Maxim Yu. Osipov
2018-11-29  8:28                               ` Hombourger, Cedric
2018-11-29  8:48                                 ` Maxim Yu. Osipov
2018-11-29 10:00                                 ` Baurzhan Ismagulov
2018-11-29  9:54                             ` Henning Schild
2018-11-19  9:27                   ` Henning Schild [this message]
2018-11-19  9:30                     ` [PATCH v5 " Hombourger, Cedric
2018-11-13 12:06       ` [PATCH v3 1/2] buildchroot+bootstrap: use rbinds for /dev and /proc Henning Schild
2018-11-12  9:46   ` [PATCH v2] buildchroot: add sysfs mount since expected by some packages Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181119102725.10e8b13e@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=Cedric_Hombourger@mentor.com \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox