From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6621956091070644224 X-Received: by 2002:a1c:5fc1:: with SMTP id t184-v6mr2048629wmb.8.1542619647936; Mon, 19 Nov 2018 01:27:27 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:c90:: with SMTP id 138-v6ls3659473wmm.13.gmail; Mon, 19 Nov 2018 01:27:27 -0800 (PST) X-Google-Smtp-Source: AFSGD/VRxPAPSlD1KdwSwFJ+9YIQKK2xP5PrgFyBvsZ6+2jSwdmGBefZQFivBrNLTuSjhnwJ9Oeq X-Received: by 2002:a1c:1592:: with SMTP id 140-v6mr2026512wmv.25.1542619647526; Mon, 19 Nov 2018 01:27:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542619647; cv=none; d=google.com; s=arc-20160816; b=qLeQ6Hokjwwi0uDhfobbzFQNp1AfLX9TJgcCZaLHyHM1RQqhlG2wdYBoPyrh652b1n xj5NEZtWuK9MO4MVw5vXTm6VxAD0gQRJc4DUlfDQj2zRkOcy2OCHbBn7/mZKAqr2NiaD 6RdJuK5A1pm0AWDqL2yQvwBXcP4iAddeHuxdxYaH9kSxtBGwppRvna3GFb01i6GZdBH8 X5NP3qslV2bS+IiPXVRzr8ZZv8g1Vx2IqgR2DE31i7pG/6Qkgrwx0acLbEposXgKD6jq FUzwF4at3dEXA+1qEOMA/m+bpDZPn9j0E2Csyhwqq3245dIb8hQrLQzIpmByplC3vxlU 8Uaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=u/u0LrrXHk2P69MJns2BF+WlvKsKN1eOboqTFIzoVr4=; b=gh74QdOZnNtq0iBf5Gt1mn8ZigOA/DyW8bFxTO27A9xAw7Bg0nX82WWC8vmYc2qfty X6aZeRUBAJXkHuD7o35vwT3w9oFsr0ur5XBE7o1xyvL1FSazmugTzZvddl1VPU15x5ve 1k3ceWmlQeBOF/sYcrnXyfm6vbtnITsJO9yxoeTBbzrl/N3bqUqXxdbE2ShdWtgf3U5V p2RIa8jEAv36R39XexXvk6TQ9O2FHViLF2TW/wvI7uggjOmsGFoWaDCxcYcMHXB+M+Jg G/GgeeNIlFUDi8eVtcX8zSo05zs61cQIQjL6F/pgGcNboiJgcVK/lUdXi6fveuDwsCZF ltjw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id n9-v6si1262481wmh.2.2018.11.19.01.27.27 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Nov 2018 01:27:27 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id wAJ9RQsl027283 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 19 Nov 2018 10:27:27 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.68.180]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id wAJ9RQMS022507; Mon, 19 Nov 2018 10:27:26 +0100 Date: Mon, 19 Nov 2018 10:27:25 +0100 From: Henning Schild To: Cedric Hombourger Cc: Subject: Re: [PATCH v5 0/2] rbind mounts for /dev and /sys Message-ID: <20181119102725.10e8b13e@md1za8fc.ad001.siemens.net> In-Reply-To: <1542466619-1689-1-git-send-email-Cedric_Hombourger@mentor.com> References: <1542385896-879-3-git-send-email-Cedric_Hombourger@mentor.com> <1542466619-1689-1-git-send-email-Cedric_Hombourger@mentor.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: LLNFyE43fFNq Looking at how many places we have to change to get the mounts right, we most likely want all that logic in a function. I recently had issues with an imager class in a layer, that also carries mounting logic. But i guess that would be a cleanup step on top. Henning Am Sat, 17 Nov 2018 15:56:57 +0100 schrieb Cedric Hombourger : > Some of the packages I have been rebuilding within Isar require /sys > mounted. For instance, golang-google-grpc runs some package tests > after it builds itself and reads properties from /sys/class/dmi. > > The initial version of this patch series only added a mount of /sys. > Henning then suggested that we follow Gentoo's guidelines for > chroots. As such, this patch series is now mounting /dev and /sys as > rbind mounts but leaves /proc as a regular procfs mount (like Gentoo > does). > > ChangeLog: > > v5: cover letter added as suggested by Jan (private e-mail) > v4: limit rbind mounts to /dev and /sys, leave /proc as a regular > mount v3: rbind mounts for /dev, /proc and /sys, add explicit umount > calls v2: create /sys directory > v1: initial submission, simply mount /sys > > Cedric Hombourger (2): > buildchroot+bootstrap: rbind mount for /dev > buildchroot: add sysfs mount since expected by some packages > > meta/classes/buildchroot.bbclass | 5 ++++- > meta/classes/image.bbclass | 3 ++- > meta/classes/isar-bootstrap-helper.bbclass | 6 +++++- > meta/classes/isar-image.bbclass | 3 ++- > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 8 ++++++-- > 5 files changed, 19 insertions(+), 6 deletions(-) >