From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6623741503488393216 X-Received: by 2002:a1c:2088:: with SMTP id g130mr1975946wmg.6.1542966416541; Fri, 23 Nov 2018 01:46:56 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:ffc5:: with SMTP id x5ls3816981wrs.16.gmail; Fri, 23 Nov 2018 01:46:56 -0800 (PST) X-Google-Smtp-Source: AFSGD/XVMj8yLzELmfuLo3p0gR708fULDRof+aJcXTT9aKuKSX3ZXZHHZJGLDd2cqK8n3Ladixny X-Received: by 2002:a5d:554d:: with SMTP id g13mr879917wrw.23.1542966416014; Fri, 23 Nov 2018 01:46:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542966415; cv=none; d=google.com; s=arc-20160816; b=NE417at8JgzRrBeQFE7q+PlAM9g6DcW4ZwGmUa4q2LNayZkmSg1FA4/2oLIbQdcZfj tWIj3JkRF48oIIdpuQwKpTqXbhlwauvUsOyWUrtDkMt39qYhHO7tnzX2xdlYXt2UpjyY xWQFBjfFcglbs4z5dtVF/Y2bxo8FecCZTACcumcm0ehLU9xrNsL/nwFoaLk5E+nTXsP7 MFKiZ6HadAinH079o7j6/47yB29BS6jTbqaugsL5RzZpJZ62oituAsGu3KOo9GkJ4HRw ADHNW0G/JpTOXr/0K//09chouRKtIb5Whf3OUM9o5XOrBislCNG8BZ0KaKpRAGbTbjR3 EOvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:to:from:date; bh=v7eaGTANaMW8fNtKKvkUtJftZppWI051phQLzlRXw6A=; b=nQ1hyy8RMUwGGksPZFKefjAsmkJpNshtPrzHmF0mFr18DW4ebQqslyR5B6M9MscuMY ZHcFNIknoVE9Wz4RKEMCFlRcRwPbZnKAnZlnvQou13f5MBvBC1WDV/pzbFn+jeMJ/GOI Dh9Euu9UFuzgM0RZaNZNRn0jQb+RhSoi0YHqTgF7tSk7HgX+MvzYwk77RzpMHt+ntXNg zOLKtgRNlnZ/03oAUljQ5MaoyLbGNeu205fsa/trbKKTFjRndengcDG9pb6P4+D9KoB6 eS9kPpBjHmACsNmSI6B18vRE8g4d5AXEQQiq5lSl3J6/3gZ07qLIu59Fti0xTFcBV4+F YpZw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id z15-v6si156956wmd.2.2018.11.23.01.46.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Nov 2018 01:46:55 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id wAN9ktNU019358 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 23 Nov 2018 10:46:55 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.69.187]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id wAN9ktbd006057 for ; Fri, 23 Nov 2018 10:46:55 +0100 Date: Fri, 23 Nov 2018 10:46:54 +0100 From: Henning Schild To: isar-users Subject: Re: [PATCH] meta/dpkg-raw: do_install into a fresh directory every time Message-ID: <20181123104654.2040b532@md1za8fc.ad001.siemens.net> In-Reply-To: <20181114153955.13232-1-henning.schild@siemens.com> References: <20181114153955.13232-1-henning.schild@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: bEvVZkcbgeu9 This is not needed anymore. Henning Am Wed, 14 Nov 2018 16:39:55 +0100 schrieb Henning Schild : > Permission problems revealed that we always packaged the sum of > possibly many rebuilds and maybe recipe versions. do_install should > always start working on an empty $D to ensure that the package only > contains output of the current build. > > Reported-by: Jan Kiszka > Signed-off-by: Henning Schild > --- > meta/classes/dpkg-raw.bbclass | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/meta/classes/dpkg-raw.bbclass > b/meta/classes/dpkg-raw.bbclass index d662422..968e28d 100644 > --- a/meta/classes/dpkg-raw.bbclass > +++ b/meta/classes/dpkg-raw.bbclass > @@ -8,13 +8,21 @@ MAINTAINER ?= "FIXME Unknown maintainer" > > D = "${WORKDIR}/image/" > > +# make sure we start with a fresh ${D} every single time > +do_fresh_image() { > + sudo rm -rf ${D} > +} > + > +do_fresh_image[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > +addtask fresh_image after do_unpack before do_install > + > # Populate folder that will be picked up as package > do_install() { > bbnote "Put your files for this package in ${D}" > } > > do_install[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > -addtask install after do_unpack before do_prepare_build > +addtask install after do_fresh_image before do_prepare_build > > deb_package_prepare() { > sudo rm -rf ${D}/DEBIAN