From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6628101524125908992 X-Received: by 2002:a19:fc11:: with SMTP id a17mr1832316lfi.11.1543225525025; Mon, 26 Nov 2018 01:45:25 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9c6:: with SMTP id 189-v6ls2322149ljj.8.gmail; Mon, 26 Nov 2018 01:45:24 -0800 (PST) X-Google-Smtp-Source: AFSGD/X78SPtx7ADNetFyh20QzDBKPulNpr8aa/tfet9kCq6o6hUQ2jueysr6QrFBRSyIczO6seP X-Received: by 2002:a2e:844d:: with SMTP id u13-v6mr2011704ljh.17.1543225524558; Mon, 26 Nov 2018 01:45:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543225524; cv=none; d=google.com; s=arc-20160816; b=vNDKwh91HK3VRxhMVZmqBbcLGJLWQ5ryVEQPuyxQxbx/bDFuLOsdZtbGz7vUsuOLUP TmRqNwunuZWzkNMMN6x3FkozStChLHDGZRTuDz/Udvdk7Hn1kUZyjdGs7Zx00d93tD3G JUoxcJ8kxV0gHLTPD7PfHFzVMkbvMQB4mvRk+jcpLDhECe/fT3Dgjr5rLxm3SPJz+UP5 0HzaTs2HOy04BbhTj2kmUX92GmZ6D0uu4UGeWa1LpsEO1Ea6SHciwzQo80bT7BvAUO+T GtdLC4u+o0i1MsHz+UqBZmV78qbWLAOpLeR6frKUMmJOHzn87mxTacD6fJjN4IoKmEkA aFDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=8ezvOErcdPrmUKJyrzzgt9MyiWXh2yPBYmOu5pgfMD8=; b=Ymj+W4xtk6xJymlNi6IYgsRi/u8CcvbGqsOlbZyzMhcHoFshqXtWWqhHzecB0dqMAM CVTd0yv5z7JVTmNZcdM7Kp7QqAP1zQg/+B+bOafqrqDkoZ2mmJQqllMdN3TnMgVwvVL5 LhDzDAk9UBrC6iXkcQt/6DGD5Vk1wrGoQAfeVHI4b26HJjM31rmjk+Vv8IYobZsR8pFt dwU1IHE0L6nU5cfofpe4SaV7+oGjK2FgviPqmY9BFjY4r7aSvMlaUyxNHB4JqU54FIeN EtCS6XfT9fAn6UZc+GMU88JViCJ/0WKiUnoyj3PTfDhMO8yMcfi0ZylSwKyACG1yIaO/ +Ztg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id 134si1827174lfa.1.2018.11.26.01.45.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Nov 2018 01:45:24 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id wAQ9jN5K001523 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 26 Nov 2018 10:45:23 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.69.60]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id wAQ9jNEr022449; Mon, 26 Nov 2018 10:45:23 +0100 Date: Mon, 26 Nov 2018 10:45:21 +0100 From: Henning Schild To: Jan Kiszka Cc: isar-users Subject: Re: [PATCH 2/7] wic: Remove obsolete reference to msger logger Message-ID: <20181126104521.3b4c27a9@md1za8fc.ad001.siemens.net> In-Reply-To: <3486bd6a6beda4e294fe9c03e6901f00d9093b7e.1543225142.git.jan.kiszka@siemens.com> References: <3486bd6a6beda4e294fe9c03e6901f00d9093b7e.1543225142.git.jan.kiszka@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: nhyPsQn32p/3 Is this a cherry pick of a single commit on wic? If so i am stronly against that. Bump the whole thing but do not fork it. Henning Am Mon, 26 Nov 2018 10:38:57 +0100 schrieb Jan Kiszka : > From: Jan Kiszka > > OE core commit b561292c4e7b. > > Signed-off-by: Jan Kiszka > --- > scripts/lib/wic/plugins/source/rootfs.py | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/scripts/lib/wic/plugins/source/rootfs.py > b/scripts/lib/wic/plugins/source/rootfs.py index f2e2ca8..944ec5f > 100644 --- a/scripts/lib/wic/plugins/source/rootfs.py > +++ b/scripts/lib/wic/plugins/source/rootfs.py > @@ -28,6 +28,7 @@ > import logging > import os > import shutil > +import sys > > from oe.path import copyhardlinktree > > @@ -98,7 +99,8 @@ class RootfsPlugin(SourcePlugin): > for orig_path in part.exclude_path: > path = orig_path > if os.path.isabs(path): > - msger.error("Must be relative: > --exclude-path=%s" % orig_path) > + logger.error("Must be relative: > --exclude-path=%s" % orig_path) > + sys.exit(1) > > full_path = > os.path.realpath(os.path.join(new_rootfs, path)) > @@ -106,7 +108,8 @@ class RootfsPlugin(SourcePlugin): > # because doing so could be quite disastrous (we > will delete the # directory). > if not full_path.startswith(new_rootfs): > - msger.error("'%s' points to a path outside the > rootfs" % orig_path) > + logger.error("'%s' points to a path outside the > rootfs" % orig_path) > + sys.exit(1) > > if path.endswith(os.sep): > # Delete content only.