From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6628101524125908992 X-Received: by 2002:a17:906:46c2:: with SMTP id k2-v6mr3829510ejs.7.1543226841162; Mon, 26 Nov 2018 02:07:21 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:1c0c:: with SMTP id k12-v6ls4156149ejg.1.gmail; Mon, 26 Nov 2018 02:07:20 -0800 (PST) X-Google-Smtp-Source: AFSGD/UE7NDDNFVKnWcTzVbOkhkMrJ8NA5hgTTNDzC4oFqtsdITQowAkKTImPP4ZbT8PBvS3Uq0P X-Received: by 2002:a17:906:328b:: with SMTP id 11-v6mr29191ejw.14.1543226840740; Mon, 26 Nov 2018 02:07:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543226840; cv=none; d=google.com; s=arc-20160816; b=X2hW+LgiVXZ/3MBUEb2CL62LH6OKwSBHg9O2yNo19HK7xV32Ic0obqxbVwOTxXQMOV wmgDBKsKgb7VzgvLbAHN3ZvCfIUhPJuaxVusSlP0/OLKM6N5rTy9gBTAHnJRKrGqHrPD M8II2pF0KyerXpej4REhXfe6VA7LkLucDpiP9Q4irYfJJSoRCUHKQouodyUvH/dD0Aqi mZHcZGvxi+zUtMe+iclKZt/x1AiTfD6KU/x1ZzEM6mkSX80UxKCEapN47tgrtHiAH8Ws 3CrKRCpJhKckTyCNqbqE5P/sYODTnicGnNkKIQO3a8967zXOFV88Mew7AhpqNdeuK6ml 6GqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=mCe1aucBOKTPZQuddEokpJtUK99gpkYujH8KhJPsYqw=; b=kNOYI9gMuYP6yYNeeWaSTwgX4WZGhfEjVZt8nvPEyYjxwf8Ky4tBVlxMOUnplnIQug 7sutAfb6V8RyUAZ+FV7fvPNsdeWSlLnKF4iKrIMeFYNh2OYPLA3PsfyI0dAe717grnl1 OZuSOMQO9kHhph7Kof+yo0xHhxeZfFSMgNGbWYZ7WfpgCqobfTUigCELTmq5j7+zWndv /vmLuCi4v1/ctrJTqZNA/6VHj2ao7n7hx0BhRS6QuK/Pa0j5/USsnUCB7mT/C+DJkTAE SvnHAXE5UbM2vTuzW904+wL3pI213gFyEe35qMvZ3it2MLm7p25CLml1MrrJLCKGsH+a PrlQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id k13si17244edx.2.2018.11.26.02.07.20 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Nov 2018 02:07:20 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id wAQA7JRZ012935 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Nov 2018 11:07:19 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.69.60]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id wAQA7JnU011365; Mon, 26 Nov 2018 11:07:19 +0100 Date: Mon, 26 Nov 2018 11:07:17 +0100 From: Henning Schild To: Jan Kiszka Cc: isar-users , Frank Lenormand Subject: Re: [PATCH 2/7] wic: Remove obsolete reference to msger logger Message-ID: <20181126110717.0fae7592@md1za8fc.ad001.siemens.net> In-Reply-To: References: <3486bd6a6beda4e294fe9c03e6901f00d9093b7e.1543225142.git.jan.kiszka@siemens.com> <20181126104521.3b4c27a9@md1za8fc.ad001.siemens.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: JRM2ZpAn07jZ Am Mon, 26 Nov 2018 10:50:57 +0100 schrieb Jan Kiszka : > On 26.11.18 10:45, Henning Schild wrote: > > Is this a cherry pick of a single commit on wic? If so i am stronly > > against that. Bump the whole thing but do not fork it. > > > > What is the baseline then? Where can we move to, i.e. what were you > selection criteria back then? We are currently at "131629ca6238ea05", without modification. The pick was made by Frank Lenormand in "2b164b18fd639c9c". I guess without a special reason. For a bump i would suggest whatever the latest OE release uses, just like bitbake. I already tried it once and it broke the build in a weird way ... Henning > Jan > > > Henning > > > > Am Mon, 26 Nov 2018 10:38:57 +0100 > > schrieb Jan Kiszka : > > > >> From: Jan Kiszka > >> > >> OE core commit b561292c4e7b. > >> > >> Signed-off-by: Jan Kiszka > >> --- > >> scripts/lib/wic/plugins/source/rootfs.py | 7 +++++-- > >> 1 file changed, 5 insertions(+), 2 deletions(-) > >> > >> diff --git a/scripts/lib/wic/plugins/source/rootfs.py > >> b/scripts/lib/wic/plugins/source/rootfs.py index f2e2ca8..944ec5f > >> 100644 --- a/scripts/lib/wic/plugins/source/rootfs.py > >> +++ b/scripts/lib/wic/plugins/source/rootfs.py > >> @@ -28,6 +28,7 @@ > >> import logging > >> import os > >> import shutil > >> +import sys > >> > >> from oe.path import copyhardlinktree > >> > >> @@ -98,7 +99,8 @@ class RootfsPlugin(SourcePlugin): > >> for orig_path in part.exclude_path: > >> path = orig_path > >> if os.path.isabs(path): > >> - msger.error("Must be relative: > >> --exclude-path=%s" % orig_path) > >> + logger.error("Must be relative: > >> --exclude-path=%s" % orig_path) > >> + sys.exit(1) > >> > >> full_path = > >> os.path.realpath(os.path.join(new_rootfs, path)) > >> @@ -106,7 +108,8 @@ class RootfsPlugin(SourcePlugin): > >> # because doing so could be quite disastrous (we > >> will delete the # directory). > >> if not full_path.startswith(new_rootfs): > >> - msger.error("'%s' points to a path outside the > >> rootfs" % orig_path) > >> + logger.error("'%s' points to a path outside > >> the rootfs" % orig_path) > >> + sys.exit(1) > >> > >> if path.endswith(os.sep): > >> # Delete content only. > > > >