Re: [PATCH 3/3] isar-bootstrap: Eliminate no-gpg-check option usage

[Henning Schild <henning.schild@siemens.com>]

There is no problem with disabling gpg in the debootstrap case. Because
debootstrap only works against one repo and we trust this one.

Instead of the original "if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]"
we should depend on the trusted option, which we have available in the
python code in this file. Doing this will enable people to debootstrap
from a trusted repo, no matter if that is the cache.

Henning

Am Wed, 7 Nov 2018 17:09:55 +0100
schrieb "Maxim Yu. Osipov" <mosipov@ilbers.de>:

> Marking repo as trusted eliminates this option usage.
> 
> Suggested-by: Henning Schild <henning.schild@siemens.com>
> Signed-off-by: Maxim Yu. Osipov <mosipov@ilbers.de>
> ---
>  meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
> b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index
> cc1791c..592d042 100644 ---
> a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++
> b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -178,9
> +178,6 @@ isar_bootstrap() { shift
>      done
>      debootstrap_args="--verbose --variant=minbase --include=locales "
> -    if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then
> -        debootstrap_args="$debootstrap_args --no-check-gpg"
> -    fi
>      E="${@bb.utils.export_proxies(d)}"
>      sudo -E flock "${ISAR_BOOTSTRAP_LOCK}" -c "\
>          set -e