From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6621151687620952064 X-Received: by 2002:a50:b4a1:: with SMTP id w30mr5713148edd.2.1543311822040; Tue, 27 Nov 2018 01:43:42 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a50:89cf:: with SMTP id h15ls6725085edh.7.gmail; Tue, 27 Nov 2018 01:43:41 -0800 (PST) X-Google-Smtp-Source: AFSGD/Uhn8qf8va+SEKeLBiF3ZxRohV6rNrRdK6IrN1HUeVshPSQGR+S29Ff1rsZBuUFA7e8Fab1 X-Received: by 2002:a05:6402:286:: with SMTP id l6mr2702338edv.11.1543311821650; Tue, 27 Nov 2018 01:43:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543311821; cv=none; d=google.com; s=arc-20160816; b=AwDzfZbqLlfEudY1CK0lM9nLiix4+2GWgvy4D+5SqJ8DeECMRPkd2t2JDrW9+2xeRz CqPNVITra6u73hbRL58WfqMJjbAK4xLDskpQEUjwXK7EYFiVa7mYDyFILXcac0Fl/aRe s65pB6Uzfr9jx2W/+NFGDudDUT3CovdKTKcBEcOecerQw8daIdpGwlEBG688czChiafm 6EtkK7xuPJqnIAmMsFjzKbLqGym81VNwrFMrfmQ/s4+czM/+qZyyOuetqLP7YX8ZyRTa vpXrxBwjsM4XeSzUXJXag+DtKqseGQYRYylbgtovZYZha6dd2r4RaxQoMd/tQyt6p92H 9Htg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=wvYvqLeFkLsSBFqmDQ9WmTlT7k3cZvLuPnlGGBDgBCk=; b=uLO/cMWb4PsfG/0LHZEzfslob0iO3yUA6kpT1JWs2P338XTI8R+dtoQPRCiz/FdpbL 98AJ1xvpw69BEw7t1u5s6KAjeyJpiEPTlqTLLpNVeffluzsGUjwFZ7NB9ZU5RWwPT8qb W1/9a5ldzyO/kjeTn+DiSPZ5ApwZ6PdG7DPygbbsvqYiP6xZU/Jjc00hzQVJy5BuBwNz ZX8DZUuBcGr9cOX4/tt/jyahm6qURFluVknu6lFGcexOKyvB4hxqB1v4u3qv40NCpawZ uxol/yrDhNxSttAcg5I5JTzmQ0g4j7s7Enne9j15im/wOO9InjbvWPHynT9JKQvkKmSj E6KA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id i2-v6si78361ejj.1.2018.11.27.01.43.41 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 27 Nov 2018 01:43:41 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id wAR9hfDm019800 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Nov 2018 10:43:41 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.68.176]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id wAR9hfQw018467; Tue, 27 Nov 2018 10:43:41 +0100 Date: Tue, 27 Nov 2018 10:43:38 +0100 From: Henning Schild To: "Maxim Yu. Osipov" Cc: Subject: Re: [PATCH 3/3] isar-bootstrap: Eliminate no-gpg-check option usage Message-ID: <20181127104338.4d491830@md1za8fc.ad001.siemens.net> In-Reply-To: <20181107160955.23426-4-mosipov@ilbers.de> References: <20181107160955.23426-1-mosipov@ilbers.de> <20181107160955.23426-4-mosipov@ilbers.de> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: chmefkY3lQTG There is no problem with disabling gpg in the debootstrap case. Because debootstrap only works against one repo and we trust this one. Instead of the original "if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]" we should depend on the trusted option, which we have available in the python code in this file. Doing this will enable people to debootstrap from a trusted repo, no matter if that is the cache. Henning Am Wed, 7 Nov 2018 17:09:55 +0100 schrieb "Maxim Yu. Osipov" : > Marking repo as trusted eliminates this option usage. > > Suggested-by: Henning Schild > Signed-off-by: Maxim Yu. Osipov > --- > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index > cc1791c..592d042 100644 --- > a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ > b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -178,9 > +178,6 @@ isar_bootstrap() { shift > done > debootstrap_args="--verbose --variant=minbase --include=locales " > - if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then > - debootstrap_args="$debootstrap_args --no-check-gpg" > - fi > E="${@bb.utils.export_proxies(d)}" > sudo -E flock "${ISAR_BOOTSTRAP_LOCK}" -c "\ > set -e