From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6621956091070644224 X-Received: by 2002:a17:906:328b:: with SMTP id 11-v6mr223366ejw.14.1543485297762; Thu, 29 Nov 2018 01:54:57 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:9688:: with SMTP id w8-v6ls297036ejx.9.gmail; Thu, 29 Nov 2018 01:54:57 -0800 (PST) X-Google-Smtp-Source: AFSGD/Uc5PcdXNXbMAh4PvOUna8vq32quHa/FRK5GviyWKNG7Xt7ajwEWqoTNG7rddxcEOpqtkCN X-Received: by 2002:a17:906:6899:: with SMTP id n25-v6mr219992ejr.11.1543485297388; Thu, 29 Nov 2018 01:54:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543485297; cv=none; d=google.com; s=arc-20160816; b=OY38PIxBf7A41pbb5L4yr/Mwif/p/MwcddT5BNSLUFb9iMu0W+dZ+9YDTFWzRCsrQf M8dhzy3QcvwX1ICGbE4f+HUDAB9QnYxrT72WcoryHDKa8TK8sUHsJhpg/x6KULuiOGkf WcG8An25SJPRWVafZLMg9MGGahV7fCw1eFT6qRFA4i7tXF/8MWUpzR1liyhcDlMzU8gM r1xlaVyTKeyfJRqgIz0HjdmOy/V3L5kzMt5CZQgvGil1pzP/Fh3/hzi/TdibLS2XTUci mMIDjX+DdTIPIRsW2EyydEL7bd6vwX9/F/9/pXE+NI1Hp36dLbFBDmkhlzbJiLNFjved UmuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=6xGtaFDnsxpO1AS7sWu2xDTN0ZKfpBcqDoaHeHzCa7E=; b=mDu2dHSdcatlSFXHhPRU43F/EaJmE1El13C3tihanqaPr2NGb3oKZz2OFNXcmKq6fm JhMgNVLGhtFMlNCzdpmHZAkk9cDx7pFDnIBIHvk7DRX3MCmzNw2gSbhA3yw9kVE3oqEp UUEYlMz4iuDeQ19rV66U2WAqGazn0JdR/hU4Mp8UMCshLAb5ArLZAYqO1cVW3c1FrVLf ErmJqVS7rhUR1GH6tRrL6cAWQoPHYdkCY+d88cfkUyfBuGYTCOXrXBg2oO4+Jm4MAFG6 DiH/A7d89Fu4DAqYauqhuz5OkvyEcwg8gszip8Z7rLfDRZd2miSl+aytRBKfDUYpT0KE 7Apw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id i2-v6si41200ejj.1.2018.11.29.01.54.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Nov 2018 01:54:57 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id wAT9suvT006884 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 29 Nov 2018 10:54:56 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.69.223]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id wAT9su92027830; Thu, 29 Nov 2018 10:54:56 +0100 Date: Thu, 29 Nov 2018 10:54:55 +0100 From: Henning Schild To: "Hombourger, Cedric" Cc: "Maxim Yu. Osipov" , "isar-users@googlegroups.com" Subject: Re: [PATCH v6 0/2] rbind mounts for /dev and /sys Message-ID: <20181129105455.5e8c126b@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20181119102407.0903d847@md1za8fc.ad001.siemens.net> <1542717658-157-1-git-send-email-Cedric_Hombourger@mentor.com> <59566b71-f70a-ba1a-fd63-d6ea6d24c84d@ilbers.de> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: QkkHlcK0t5TI Am Tue, 27 Nov 2018 14:48:37 +0000 schrieb "Hombourger, Cedric" : > Hi Maxim, > > We may need to revert Henning's suggestion to rbind /sys and > mount /sys as a regular mount (the chroot may not need all of the > sub-mounts from /sys) What do people think? I already expected the umount not being able to clean up, but Cedric tested that and made the umount recursive. I guess it would be a good idea to understand what is going on, and why those mounts do not get cleaned up. Maybe we still have a problem in the umounting logic and mounting less will not fix but just hide it. But we can also revert to mounting as little as needed and accept new mounts on demand, just like we did for sys. However the demand for something under sys would not be a big surprise and we might be talking about that topic again soon ... or never. I do not know. Henning > Cedric > > -----Original Message----- > From: Maxim Yu. Osipov [mailto:mosipov@ilbers.de] > Sent: Tuesday, November 27, 2018 5:45 PM > To: Hombourger, Cedric ; > isar-users@googlegroups.com Subject: Re: [PATCH v6 0/2] rbind mounts > for /dev and /sys > > Hi Cedric, > > After applying these patches I've recognized that after running > ci_build.sh script, the number of mounts significantly increases. > > On my PC it looks like that > > $ mount | wc -l > 34 > isar$ ./scripts/ci_build.sh -q -f > ... > $ mount | wc -l > 100 > > If I revert these patches the number of mount points stays the same > after running ci_build.sh script. > > This behavior significantly affects CI - builds start to fail. This > is a blocking point for CI and if we don't find a quick solution I > will have to revert these patches in 'next'. > > Thanks, > Maxim. > > On 11/20/18 3:40 PM, Cedric Hombourger wrote: > > Some of the packages I have been rebuilding within Isar > > require /sys mounted. For instance, golang-google-grpc runs some > > package tests after it builds itself and reads properties > > from /sys/class/dmi. > > > > The initial version of this patch series only added a mount > > of /sys. Henning then suggested that we follow Gentoo's guidelines > > for chroots. As such, this patch series is now mounting /dev > > and /sys as rbind mounts but leaves /proc as a regular procfs mount > > (like Gentoo does). > > > > ChangeLog: > > > > v6: remove unnecessary mkdir for /sys > > v5: cover letter added as suggested by Jan (private e-mail) > > v4: limit rbind mounts to /dev and /sys, leave /proc as a regular > > mount > > v3: rbind mounts for /dev, /proc and /sys, add explicit umount calls > > v2: create /sys directory > > v1: initial submission, simply mount /sys > > > > Cedric Hombourger (2): > > buildchroot+bootstrap: rbind mount for /dev > > buildchroot: add sysfs mount since expected by some packages > > > > meta/classes/buildchroot.bbclass | 5 ++++- > > meta/classes/image.bbclass | 3 ++- > > meta/classes/isar-bootstrap-helper.bbclass | 6 +++++- > > meta/classes/isar-image.bbclass | 3 ++- > > meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 8 ++++++-- > > 5 files changed, 19 insertions(+), 6 deletions(-) > > > > > -- > Maxim Osipov > ilbers GmbH > Maria-Merian-Str. 8 > 85521 Ottobrunn > Germany > +49 (151) 6517 6917 > mosipov@ilbers.de > http://ilbers.de/ > Commercial register Munich, HRB 214197 > General Manager: Baurzhan Ismagulov >