public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: "Maxim Yu. Osipov" <mosipov@ilbers.de>
Cc: <isar-users@googlegroups.com>
Subject: Re: [PATCH] scripts/ci: enable use of cached base repository for fast build
Date: Thu, 29 Nov 2018 13:33:37 +0100	[thread overview]
Message-ID: <20181129133337.29a0e46f@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <874c0ba5-4876-8fb9-f3c6-dd50e90c64b3@ilbers.de>

Am Thu, 29 Nov 2018 15:02:06 +0300
schrieb "Maxim Yu. Osipov" <mosipov@ilbers.de>:

> On 11/29/18 2:33 PM, Henning Schild wrote:
> > Am Thu, 29 Nov 2018 08:19:18 +0100
> > schrieb "Maxim Yu. Osipov" <mosipov@ilbers.de>:
> >   
> >> Signed-off-by: Maxim Yu. Osipov <mosipovd@ilbers.de>
> >> ---
> >>   scripts/ci_build.sh | 7 +++++++
> >>   1 file changed, 7 insertions(+)
> >>
> >> diff --git a/scripts/ci_build.sh b/scripts/ci_build.sh
> >> index 059df21..20b77b7 100755
> >> --- a/scripts/ci_build.sh
> >> +++ b/scripts/ci_build.sh
> >> @@ -86,7 +86,14 @@ fi
> >>   if [ -n "$FAST_BUILD" ]; then
> >>       # Start build for the reduced set of configurations
> >>       # Enforce cross-compilation to speed up the build
> >> +    # Enable use of cached base repository
> >>       sed -i -e 's/ISAR_CROSS_COMPILE ?= "0"/ISAR_CROSS_COMPILE ?=
> >> "1"/g' conf/local.conf
> >> +    bitbake $BB_ARGS -c cache_base_repo \
> >> +        multiconfig:qemuarm-stretch:isar-image-base \
> >> +        multiconfig:qemuarm64-stretch:isar-image-base \
> >> +        multiconfig:qemuamd64-stretch:isar-image-base
> >> +    sudo rm -rf tmp  
> > 
> > That rm is not in line with the user manual, should that be updated
> > as well?  
> 
> Yes, after commit de68185 "conf: Move base-apt to downloads directory"
> one may remove the whole tmp directory. I'll update the user manual.
> 
> >> +    sed -i -e 's/#ISAR_USE_CACHED_BASE_REPO ?=
> >> "1"/ISAR_USE_CACHED_BASE_REPO ?= "1"/g' conf/local.conf bitbake  
> > 
> > I will not propose "ifconfig down" but this here to cover cutting
> > off the network for the debian side.  
> 
> 
> > # set invalid proxy variables to enforce "offline"
> > export http_proxy=http://localhost:3128
> > export https_proxy=$http_proxy
> > export ftp_proxy=$http_proxy  
> 
> Have you tested this in your environment?

No, this is just the long version of "your patch does not actually go
offline and should not be merged".

Henning

> If yes, I'll include this in v2.
> 
> Thanks,
> Maxim.
> 
> 
> > Henning
> >   
> >> $BB_ARGS \ multiconfig:qemuarm-stretch:isar-image-base \
> >>           multiconfig:qemuarm64-stretch:isar-image-base \  
> >   
> 
> 


  reply	other threads:[~2018-11-29 12:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29  7:19 Maxim Yu. Osipov
2018-11-29  7:58 ` Jan Kiszka
2018-11-29 11:33 ` Henning Schild
2018-11-29 12:02   ` Maxim Yu. Osipov
2018-11-29 12:33     ` Henning Schild [this message]
2018-11-29 12:40       ` Jan Kiszka
2018-11-29 13:01       ` Maxim Yu. Osipov
2018-11-29 13:26 ` Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181129133337.29a0e46f@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=mosipov@ilbers.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox