From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6631443383059480576 X-Received: by 2002:a1c:f019:: with SMTP id a25mr41652wmb.2.1544003231340; Wed, 05 Dec 2018 01:47:11 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:41c5:: with SMTP id o188ls3812616wma.3.gmail; Wed, 05 Dec 2018 01:47:10 -0800 (PST) X-Google-Smtp-Source: AFSGD/X4O+GaOIr7BSBxY7ZolxrexWTURCr6PsFdU0fFIXKw2VaHCUH++ZM8Rs6uiH1nlwjscA9f X-Received: by 2002:a1c:dc82:: with SMTP id t124mr2488323wmg.0.1544003230948; Wed, 05 Dec 2018 01:47:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1544003230; cv=none; d=google.com; s=arc-20160816; b=Hq+H8OGrtv4WSKPdrSOm/P9fvNkrGrsteMu+IE71Py4lZPdjv5p6BcWJCKgG9HRFv4 bKwQvZeLHAzfYrLzEs6EXQhWZQproe0sQLPC6YL89Wk6ENdM/hSQK9vYImBZlfThbfkT Es/wzSIxe7ufqjgxm9G3A8KfRqNehEMN0Z98SGeLQt79wjUVZdjwRM7po3A+I1e3/i7k A9JWIQgHhi3R3YZC4Fkxlcu4qYqOimbFcbiFWMIfzEndD/GJOXlJ/azKi09iwcswRmNc 2loD3Hv1W3w2wV58b5SPFBYdcfZ2KdMyysAVF9M3VTIfFasrhRqNg9hDM1WJw4qmq5RC WqDA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=references:in-reply-to:message-id:date:subject:to:from; bh=YhaGyXk5b/mRJywm4ghz7j72qwgP8dDmoBdJsFi2ogQ=; b=zSM4c0vHX8NCL9tkVghcDuf8DuAAwC5U7OuUZPQmyv6qKcuN4EMW8tG2McQA0YPuKy s12qIBHrFQXqp8vfdXGI8ngxhzv1DXlybuvtjnVVMGVr0nV5eW3tgIG9jS5aUkDBOrfk HbgL7ZHraVSdYzHrs7zT9ic49Cfd6cnn5YlyY8HFN5j8zYnP1aWgK2OdAskBS6qlYKyJ 2EtKLRWZtTP0ZIobYc2Scf2VVU08Nrf1gvq/b5y/h4dIyp44GNvqMJQBNhiruNCVNsdj h3GrmPvBydtBky/dsCIayajCV1BZynIUBmczzHp2ZFajfi52B5wXOUIFGQs2tnDSG2o8 BXnw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Return-Path: Received: from aqmola.ilbers.de (aqmola.ilbers.de. [85.214.62.211]) by gmr-mx.google.com with ESMTPS id p15si613249wrm.5.2018.12.05.01.47.10 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Dec 2018 01:47:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) client-ip=85.214.62.211; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: best guess record for domain of mosipov@ilbers.de designates 85.214.62.211 as permitted sender) smtp.mailfrom=mosipov@ilbers.de Received: from azat.m.ilbers.de (host-80-81-17-52.static.customer.m-online.net [80.81.17.52]) (authenticated bits=0) by aqmola.ilbers.de (8.14.4/8.14.4/Debian-4+deb7u1) with ESMTP id wB59kx6u027966 (version=TLSv1/SSLv3 cipher=AES128-SHA256 bits=128 verify=NOT) for ; Wed, 5 Dec 2018 10:47:10 +0100 From: "Maxim Yu. Osipov" To: isar-users@googlegroups.com Subject: [PATCH 1/2] Revert "buildchroot+bootstrap: rbind mount for /dev" Date: Wed, 5 Dec 2018 10:46:58 +0100 Message-Id: <20181205094659.25029-2-mosipov@ilbers.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181205094659.25029-1-mosipov@ilbers.de> References: <20181205094659.25029-1-mosipov@ilbers.de> X-TUID: H4Q1gDHbiubX This reverts commit e0feb7d62bf0612f9bb00f2120ae26bc96fb1b91. as it causes bitbake's hangs when trying to unmount /dev. The following scenario causes hangs on Debian 9 (stretch) systems: * source isar-init-build-env * sed -i -e 's/ISAR_CROSS_COMPILE ?= "0"/ISAR_CROSS_COMPILE ?= "1"/g' conf/local.conf * bitbake -c cache_base_repo multiconfig:qemuarm-stretch:isar-image-base \ multiconfig:qemuarm64-stretch:isar-image-base multiconfig:qemuamd64-stretch:isar-image-base * sudo rm -rf tmp * sed -i -e 's/#ISAR_USE_CACHED_BASE_REPO ?= "1"/ISAR_USE_CACHED_BASE_REPO ?= "1"/g' conf/local.conf * bitbake multiconfig:qemuarm-stretch:isar-image-base \ multiconfig:qemuarm64-stretch:isar-image-base multiconfig:qemuamd64-stretch:isar-image-base The last command hangs on the last task. Signed-off-by: Maxim Yu. Osipov --- meta/classes/buildchroot.bbclass | 3 +-- meta/classes/image.bbclass | 2 +- meta/classes/isar-bootstrap-helper.bbclass | 3 +-- meta/classes/isar-image.bbclass | 2 +- meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 3 +-- 5 files changed, 5 insertions(+), 8 deletions(-) diff --git a/meta/classes/buildchroot.bbclass b/meta/classes/buildchroot.bbclass index 0d4ff4e..d7368c4 100644 --- a/meta/classes/buildchroot.bbclass +++ b/meta/classes/buildchroot.bbclass @@ -27,8 +27,7 @@ buildchroot_do_mounts() { if ! grep -q ${BUILDCHROOT_DIR}/isar-apt /proc/mounts; then mount --bind ${REPO_ISAR_DIR}/${DISTRO} ${BUILDCHROOT_DIR}/isar-apt mount --bind ${DL_DIR} ${BUILDCHROOT_DIR}/downloads - mount --rbind /dev ${BUILDCHROOT_DIR}/dev - mount --make-rslave ${BUILDCHROOT_DIR}/dev + mount -t devtmpfs -o mode=0755,nosuid devtmpfs ${BUILDCHROOT_DIR}/dev mount -t proc none ${BUILDCHROOT_DIR}/proc mount --rbind /sys ${BUILDCHROOT_DIR}/sys mount --make-rslave ${BUILDCHROOT_DIR}/sys diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass index d8fbfd5..f438f11 100644 --- a/meta/classes/image.bbclass +++ b/meta/classes/image.bbclass @@ -108,7 +108,7 @@ do_populate_sdk() { # Purge apt cache to make image slimmer sudo rm -rf ${SDKCHROOT_DIR}/rootfs/var/cache/apt/* - sudo umount -R ${SDKCHROOT_DIR}/rootfs/dev || true + sudo umount ${SDKCHROOT_DIR}/rootfs/dev || true sudo umount ${SDKCHROOT_DIR}/rootfs/proc || true sudo umount -R ${SDKCHROOT_DIR}/rootfs/sys || true diff --git a/meta/classes/isar-bootstrap-helper.bbclass b/meta/classes/isar-bootstrap-helper.bbclass index 641138a..0750a8f 100644 --- a/meta/classes/isar-bootstrap-helper.bbclass +++ b/meta/classes/isar-bootstrap-helper.bbclass @@ -103,8 +103,7 @@ setup_root_file_system() { sudo mount --bind ${REPO_BASE_DIR} ${ROOTFSDIR}/base-apt fi - sudo mount --rbind /dev ${ROOTFSDIR}/dev - sudo mount --make-rslave ${ROOTFSDIR}/dev + sudo mount -t devtmpfs -o mode=0755,nosuid devtmpfs $ROOTFSDIR/dev sudo mount -t proc none $ROOTFSDIR/proc sudo mount --rbind /sys ${ROOTFSDIR}/sys sudo mount --make-rslave ${ROOTFSDIR}/sys diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass index 23b3a99..c65b13c 100644 --- a/meta/classes/isar-image.bbclass +++ b/meta/classes/isar-image.bbclass @@ -59,7 +59,7 @@ isar_image_cleanup() { -maxdepth 1 -name 'qemu-*-static' -type f -delete sudo umount -l ${IMAGE_ROOTFS}/isar-apt sudo rmdir ${IMAGE_ROOTFS}/isar-apt - sudo umount -R -l ${IMAGE_ROOTFS}/dev + sudo umount -l ${IMAGE_ROOTFS}/dev sudo umount -l ${IMAGE_ROOTFS}/proc sudo umount -R -l ${IMAGE_ROOTFS}/sys sudo rm -f "${IMAGE_ROOTFS}/etc/apt/apt.conf.d/55isar-fallback.conf" diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc index da077d0..c19399c 100644 --- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc +++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc @@ -243,8 +243,7 @@ isar_bootstrap() { "${ROOTFSDIR}/chroot-setup.sh" "setup" "${ROOTFSDIR}" # update APT - mount --rbind /dev ${ROOTFSDIR}/dev - mount --make-rslave ${ROOTFSDIR}/dev + mount -t devtmpfs -o mode=0755,nosuid devtmpfs ${ROOTFSDIR}/dev mount -t proc none ${ROOTFSDIR}/proc mount --rbind /sys ${ROOTFSDIR}/sys mount --make-rslave ${ROOTFSDIR}/sys -- 2.11.0