[PATCH 0/2] Cleanup rbind mounting for /dev ans /sys

public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed

* [PATCH 0/2] Cleanup rbind mounting for /dev ans /sys
@ 2018-12-05  9:46 Maxim Yu. Osipov
  2018-12-05  9:46 ` [PATCH 1/2] Revert "buildchroot+bootstrap: rbind mount for /dev" Maxim Yu. Osipov
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Maxim Yu. Osipov @ 2018-12-05  9:46 UTC (permalink / raw)
  To: isar-users

Hi everybody,

This series eliminates rbind mounting for /dev and /sys 
as it causes bitbake hangs when trying to umount /dev and /sys.

This series is based on the 'next' branch with applied 
patches by Jan Kiszka: 
 * isar-image: umount base-apt when doing offline build
 * isar-bootstrap: Fix and cleanup bind mounting

Regards,
Maxim.

Maxim Yu. Osipov (2):
  Revert "buildchroot+bootstrap: rbind mount for /dev"
  meta/classes: Cleanup /sys rbind mounting

 meta/classes/buildchroot.bbclass                    | 6 ++----
 meta/classes/image.bbclass                          | 4 ++--
 meta/classes/isar-bootstrap-helper.bbclass          | 6 ++----
 meta/classes/isar-image.bbclass                     | 4 ++--
 meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 6 ++----
 5 files changed, 10 insertions(+), 16 deletions(-)

-- 
2.11.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] Revert "buildchroot+bootstrap: rbind mount for /dev"
  2018-12-05  9:46 [PATCH 0/2] Cleanup rbind mounting for /dev ans /sys Maxim Yu. Osipov
@ 2018-12-05  9:46 ` Maxim Yu. Osipov
  2018-12-05  9:46 ` [PATCH 2/2] meta/classes: Cleanup /sys rbind mounting Maxim Yu. Osipov
  2018-12-05  9:58 ` [PATCH 0/2] Cleanup rbind mounting for /dev ans /sys Jan Kiszka
  2 siblings, 0 replies; 4+ messages in thread
From: Maxim Yu. Osipov @ 2018-12-05  9:46 UTC (permalink / raw)
  To: isar-users

This reverts commit e0feb7d62bf0612f9bb00f2120ae26bc96fb1b91.
as it causes bitbake's hangs when trying to unmount /dev.

The following scenario causes hangs on Debian 9 (stretch) systems:
 * source isar-init-build-env
 * sed -i -e 's/ISAR_CROSS_COMPILE ?= "0"/ISAR_CROSS_COMPILE ?= "1"/g' conf/local.conf
 * bitbake  -c cache_base_repo multiconfig:qemuarm-stretch:isar-image-base \
   multiconfig:qemuarm64-stretch:isar-image-base multiconfig:qemuamd64-stretch:isar-image-base
 * sudo rm -rf tmp
 * sed -i -e 's/#ISAR_USE_CACHED_BASE_REPO ?= "1"/ISAR_USE_CACHED_BASE_REPO ?= "1"/g' conf/local.conf
 * bitbake multiconfig:qemuarm-stretch:isar-image-base \
   multiconfig:qemuarm64-stretch:isar-image-base multiconfig:qemuamd64-stretch:isar-image-base

The last command hangs on the last task.

Signed-off-by: Maxim Yu. Osipov <mosipov@ilbers.de>
---
 meta/classes/buildchroot.bbclass                    | 3 +--
 meta/classes/image.bbclass                          | 2 +-
 meta/classes/isar-bootstrap-helper.bbclass          | 3 +--
 meta/classes/isar-image.bbclass                     | 2 +-
 meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 3 +--
 5 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/meta/classes/buildchroot.bbclass b/meta/classes/buildchroot.bbclass
index 0d4ff4e..d7368c4 100644
--- a/meta/classes/buildchroot.bbclass
+++ b/meta/classes/buildchroot.bbclass
@@ -27,8 +27,7 @@ buildchroot_do_mounts() {
         if ! grep -q ${BUILDCHROOT_DIR}/isar-apt /proc/mounts; then
             mount --bind ${REPO_ISAR_DIR}/${DISTRO} ${BUILDCHROOT_DIR}/isar-apt
             mount --bind ${DL_DIR} ${BUILDCHROOT_DIR}/downloads
-            mount --rbind /dev ${BUILDCHROOT_DIR}/dev
-            mount --make-rslave ${BUILDCHROOT_DIR}/dev
+            mount -t devtmpfs -o mode=0755,nosuid devtmpfs ${BUILDCHROOT_DIR}/dev
             mount -t proc none ${BUILDCHROOT_DIR}/proc
             mount --rbind /sys ${BUILDCHROOT_DIR}/sys
             mount --make-rslave ${BUILDCHROOT_DIR}/sys
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index d8fbfd5..f438f11 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -108,7 +108,7 @@ do_populate_sdk() {
     # Purge apt cache to make image slimmer
     sudo rm -rf ${SDKCHROOT_DIR}/rootfs/var/cache/apt/*
 
-    sudo umount -R ${SDKCHROOT_DIR}/rootfs/dev || true
+    sudo umount ${SDKCHROOT_DIR}/rootfs/dev || true
     sudo umount ${SDKCHROOT_DIR}/rootfs/proc || true
     sudo umount -R ${SDKCHROOT_DIR}/rootfs/sys || true
 
diff --git a/meta/classes/isar-bootstrap-helper.bbclass b/meta/classes/isar-bootstrap-helper.bbclass
index 641138a..0750a8f 100644
--- a/meta/classes/isar-bootstrap-helper.bbclass
+++ b/meta/classes/isar-bootstrap-helper.bbclass
@@ -103,8 +103,7 @@ setup_root_file_system() {
         sudo mount --bind ${REPO_BASE_DIR} ${ROOTFSDIR}/base-apt
     fi
 
-    sudo mount --rbind /dev ${ROOTFSDIR}/dev
-    sudo mount --make-rslave ${ROOTFSDIR}/dev
+    sudo mount -t devtmpfs -o mode=0755,nosuid devtmpfs $ROOTFSDIR/dev
     sudo mount -t proc none $ROOTFSDIR/proc
     sudo mount --rbind /sys ${ROOTFSDIR}/sys
     sudo mount --make-rslave ${ROOTFSDIR}/sys
diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass
index 23b3a99..c65b13c 100644
--- a/meta/classes/isar-image.bbclass
+++ b/meta/classes/isar-image.bbclass
@@ -59,7 +59,7 @@ isar_image_cleanup() {
               -maxdepth 1 -name 'qemu-*-static' -type f -delete
     sudo umount -l ${IMAGE_ROOTFS}/isar-apt
     sudo rmdir ${IMAGE_ROOTFS}/isar-apt
-    sudo umount -R -l ${IMAGE_ROOTFS}/dev
+    sudo umount -l ${IMAGE_ROOTFS}/dev
     sudo umount -l ${IMAGE_ROOTFS}/proc
     sudo umount -R -l ${IMAGE_ROOTFS}/sys
     sudo rm -f "${IMAGE_ROOTFS}/etc/apt/apt.conf.d/55isar-fallback.conf"
diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
index da077d0..c19399c 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
@@ -243,8 +243,7 @@ isar_bootstrap() {
             "${ROOTFSDIR}/chroot-setup.sh" "setup" "${ROOTFSDIR}"
 
             # update APT
-            mount --rbind /dev ${ROOTFSDIR}/dev
-            mount --make-rslave ${ROOTFSDIR}/dev
+            mount -t devtmpfs -o mode=0755,nosuid devtmpfs ${ROOTFSDIR}/dev
             mount -t proc none ${ROOTFSDIR}/proc
             mount --rbind /sys ${ROOTFSDIR}/sys
             mount --make-rslave ${ROOTFSDIR}/sys
-- 
2.11.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 2/2] meta/classes: Cleanup /sys rbind mounting
  2018-12-05  9:46 [PATCH 0/2] Cleanup rbind mounting for /dev ans /sys Maxim Yu. Osipov
  2018-12-05  9:46 ` [PATCH 1/2] Revert "buildchroot+bootstrap: rbind mount for /dev" Maxim Yu. Osipov
@ 2018-12-05  9:46 ` Maxim Yu. Osipov
  2018-12-05  9:58 ` [PATCH 0/2] Cleanup rbind mounting for /dev ans /sys Jan Kiszka
  2 siblings, 0 replies; 4+ messages in thread
From: Maxim Yu. Osipov @ 2018-12-05  9:46 UTC (permalink / raw)
  To: isar-users

This patch eliminates rbind mounting introduced by commit
768908a "buildchroot: add sysfs mount since expected by some packages"
as bitbake hangs when trying to unmount /sys).

The following scenario causes hangs on Debian 9 (stretch) systems:
 * source isar-init-build-env
 * sed -i -e 's/ISAR_CROSS_COMPILE ?= "0"/ISAR_CROSS_COMPILE ?= "1"/g' conf/local.conf
 * bitbake  -c cache_base_repo multiconfig:qemuarm-stretch:isar-image-base \
   multiconfig:qemuarm64-stretch:isar-image-base multiconfig:qemuamd64-stretch:isar-image-base
 * sudo rm -rf tmp
 * sed -i -e 's/#ISAR_USE_CACHED_BASE_REPO ?= "1"/ISAR_USE_CACHED_BASE_REPO ?= "1"/g' conf/local.conf
 * bitbake multiconfig:qemuarm-stretch:isar-image-base \
   multiconfig:qemuarm64-stretch:isar-image-base multiconfig:qemuamd64-stretch:isar-image-base

The last command hangs on the last task.

Signed-off-by: Maxim Yu. Osipov <mosipov@ilbers.de>
---
 meta/classes/buildchroot.bbclass                    | 3 +--
 meta/classes/image.bbclass                          | 2 +-
 meta/classes/isar-bootstrap-helper.bbclass          | 3 +--
 meta/classes/isar-image.bbclass                     | 2 +-
 meta/recipes-core/isar-bootstrap/isar-bootstrap.inc | 3 +--
 5 files changed, 5 insertions(+), 8 deletions(-)

diff --git a/meta/classes/buildchroot.bbclass b/meta/classes/buildchroot.bbclass
index d7368c4..5a8a137 100644
--- a/meta/classes/buildchroot.bbclass
+++ b/meta/classes/buildchroot.bbclass
@@ -29,8 +29,7 @@ buildchroot_do_mounts() {
             mount --bind ${DL_DIR} ${BUILDCHROOT_DIR}/downloads
             mount -t devtmpfs -o mode=0755,nosuid devtmpfs ${BUILDCHROOT_DIR}/dev
             mount -t proc none ${BUILDCHROOT_DIR}/proc
-            mount --rbind /sys ${BUILDCHROOT_DIR}/sys
-            mount --make-rslave ${BUILDCHROOT_DIR}/sys
+            mount -t sysfs /sys ${BUILDCHROOT_DIR}/sys
         fi
 
         # Refresh /etc/resolv.conf at this chance
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index f438f11..5806a59 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -110,7 +110,7 @@ do_populate_sdk() {
 
     sudo umount ${SDKCHROOT_DIR}/rootfs/dev || true
     sudo umount ${SDKCHROOT_DIR}/rootfs/proc || true
-    sudo umount -R ${SDKCHROOT_DIR}/rootfs/sys || true
+    sudo umount ${SDKCHROOT_DIR}/rootfs/sys || true
 
     # Create SDK archive
     sudo tar -C ${SDKCHROOT_DIR} --transform="s|^rootfs|sdk-${DISTRO}-${DISTRO_ARCH}|" \
diff --git a/meta/classes/isar-bootstrap-helper.bbclass b/meta/classes/isar-bootstrap-helper.bbclass
index 0750a8f..e755e4f 100644
--- a/meta/classes/isar-bootstrap-helper.bbclass
+++ b/meta/classes/isar-bootstrap-helper.bbclass
@@ -105,8 +105,7 @@ setup_root_file_system() {
 
     sudo mount -t devtmpfs -o mode=0755,nosuid devtmpfs $ROOTFSDIR/dev
     sudo mount -t proc none $ROOTFSDIR/proc
-    sudo mount --rbind /sys ${ROOTFSDIR}/sys
-    sudo mount --make-rslave ${ROOTFSDIR}/sys
+    sudo mount -t sysfs /sys ${ROOTFSDIR}/sys
 
     # Refresh /etc/resolv.conf
     sudo cp -L /etc/resolv.conf ${ROOTFSDIR}/etc
diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass
index c65b13c..14b97dd 100644
--- a/meta/classes/isar-image.bbclass
+++ b/meta/classes/isar-image.bbclass
@@ -61,7 +61,7 @@ isar_image_cleanup() {
     sudo rmdir ${IMAGE_ROOTFS}/isar-apt
     sudo umount -l ${IMAGE_ROOTFS}/dev
     sudo umount -l ${IMAGE_ROOTFS}/proc
-    sudo umount -R -l ${IMAGE_ROOTFS}/sys
+    sudo umount -l ${IMAGE_ROOTFS}/sys
     sudo rm -f "${IMAGE_ROOTFS}/etc/apt/apt.conf.d/55isar-fallback.conf"
     if [ "${ISAR_USE_CACHED_BASE_REPO}" = "1" ]; then
         sudo umount -l ${IMAGE_ROOTFS}/base-apt
diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
index c19399c..b13ea9d 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
@@ -245,8 +245,7 @@ isar_bootstrap() {
             # update APT
             mount -t devtmpfs -o mode=0755,nosuid devtmpfs ${ROOTFSDIR}/dev
             mount -t proc none ${ROOTFSDIR}/proc
-            mount --rbind /sys ${ROOTFSDIR}/sys
-            mount --make-rslave ${ROOTFSDIR}/sys
+            mount -t sysfs /sys ${ROOTFSDIR}/sys
 
             export DEBIAN_FRONTEND=noninteractive
             chroot "${ROOTFSDIR}" /usr/bin/apt-get update -y
-- 
2.11.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] Cleanup rbind mounting for /dev ans /sys
  2018-12-05  9:46 [PATCH 0/2] Cleanup rbind mounting for /dev ans /sys Maxim Yu. Osipov
  2018-12-05  9:46 ` [PATCH 1/2] Revert "buildchroot+bootstrap: rbind mount for /dev" Maxim Yu. Osipov
  2018-12-05  9:46 ` [PATCH 2/2] meta/classes: Cleanup /sys rbind mounting Maxim Yu. Osipov
@ 2018-12-05  9:58 ` Jan Kiszka
  2 siblings, 0 replies; 4+ messages in thread
From: Jan Kiszka @ 2018-12-05  9:58 UTC (permalink / raw)
  To: Maxim Yu. Osipov, isar-users

On 05.12.18 10:46, Maxim Yu. Osipov wrote:
> Hi everybody,
> 
> This series eliminates rbind mounting for /dev and /sys
> as it causes bitbake hangs when trying to umount /dev and /sys.

NACK, this still lacks real analysis. Please try my suggestions to narrow down 
the issue. Specifically use my just posted patches for that.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-12-05  9:58 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-05  9:46 [PATCH 0/2] Cleanup rbind mounting for /dev ans /sys Maxim Yu. Osipov
2018-12-05  9:46 ` [PATCH 1/2] Revert "buildchroot+bootstrap: rbind mount for /dev" Maxim Yu. Osipov
2018-12-05  9:46 ` [PATCH 2/2] meta/classes: Cleanup /sys rbind mounting Maxim Yu. Osipov
2018-12-05  9:58 ` [PATCH 0/2] Cleanup rbind mounting for /dev ans /sys Jan Kiszka

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox