From: "Hosgor, Tolga (CT RDA DS EU TR MTS)" <tlghosgor@gmail.com>
To: isar-users@googlegroups.com
Subject: [PATCH v2 2/2] isar-bootstrap: simplified distro source functions
Date: Mon, 17 Dec 2018 14:45:18 +0300 [thread overview]
Message-ID: <20181217114518.17995-3-tolga.hosgor@siemens.com> (raw)
In-Reply-To: <20181217114518.17995-1-tolga.hosgor@siemens.com>
- distro sources are created with a generator
- debian-buster.list begins with a 'deb-src' to test
the parser works correctly
Signed-off-by: Hosgor, Tolga (CT RDA DS EU TR MTS) <tolga.hosgor@siemens.com>
---
meta-isar/conf/distro/debian-buster.list | 1 +
.../isar-bootstrap/isar-bootstrap.inc | 22 ++++++++-----------
2 files changed, 10 insertions(+), 13 deletions(-)
diff --git a/meta-isar/conf/distro/debian-buster.list b/meta-isar/conf/distro/debian-buster.list
index 92d20e1..7828671 100644
--- a/meta-isar/conf/distro/debian-buster.list
+++ b/meta-isar/conf/distro/debian-buster.list
@@ -1,3 +1,4 @@
+deb-src http://ftp.de.debian.org/debian buster main contrib non-free
deb http://ftp.de.debian.org/debian buster main contrib non-free
deb https://debian.inf.tu-dresden.de/debian buster main contrib non-free
deb http://ftp.de.debian.org/debian buster-updates main contrib non-free
diff --git a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
index d868bb6..6dc1888 100644
--- a/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
+++ b/meta/recipes-core/isar-bootstrap/isar-bootstrap.inc
@@ -117,7 +117,7 @@ def get_aptsources_list(d, is_host=False):
apt_sources_list = (d.getVar("DISTRO_APT_SOURCES", True) or "").split()
return apt_sources_list
-def get_distro_primary_source_entry(d, is_host=False):
+def generate_distro_sources(d, is_host=False):
apt_sources_list = get_aptsources_list(d, is_host)
for entry in apt_sources_list:
entry_real = bb.parse.resolve_file(entry, d)
@@ -126,21 +126,17 @@ def get_distro_primary_source_entry(d, is_host=False):
parsed = parse_aptsources_list_line(line)
if parsed:
parsed = get_apt_source_mirror(d, parsed)
- if parsed[0] == "deb":
- return parsed[2:]
+ yield parsed
+
+def get_distro_primary_source_entry(d, is_host=False):
+ apt_sources_list = get_aptsources_list(d, is_host)
+ for source in generate_distro_sources(d, is_host):
+ if source[0] == "deb":
+ return source[2:]
return ["", "", ""]
def get_distro_have_https_source(d, is_host=False):
- for entry in get_aptsources_list(d, is_host):
- entry_real = bb.parse.resolve_file(entry, d)
- with open(entry_real, "r") as in_fd:
- for line in in_fd:
- parsed = parse_aptsources_list_line(line)
- if parsed:
- parsed = get_apt_source_mirror(d, parsed)
- if parsed[2].startswith("https://"):
- return True
- return False
+ return any(source[2].startswith("https://") for source in generate_distro_sources(d, is_host))
def get_distro_needs_https_support(d, is_host=False):
if get_distro_have_https_source(d, is_host):
--
2.19.2
next prev parent reply other threads:[~2018-12-17 11:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 11:45 [PATCH v2 0/2] isar-bootstrap: debootstrap https support Hosgor, Tolga (CT RDA DS EU TR MTS)
2018-12-17 11:45 ` [PATCH v2 1/2] " Hosgor, Tolga (CT RDA DS EU TR MTS)
2018-12-18 13:20 ` Claudius Heine
2018-12-19 6:52 ` Tolga Hoşgör
2018-12-17 11:45 ` Hosgor, Tolga (CT RDA DS EU TR MTS) [this message]
2018-12-17 11:55 ` [PATCH v2 2/2] isar-bootstrap: simplified distro source functions Claudius Heine
2018-12-17 18:11 ` Tolga Hoşgör
2018-12-18 8:20 ` Claudius Heine
2019-01-17 14:08 ` [PATCH v2 0/2] isar-bootstrap: debootstrap https support Henning Schild
2019-01-17 14:21 ` Claudius Heine
2019-01-23 13:39 ` Maxim Yu. Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217114518.17995-3-tolga.hosgor@siemens.com \
--to=tlghosgor@gmail.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox