Re: [PATCH 1/7] dpkg-raw: Respect file permissions defined by recipe

[Henning Schild <henning.schild@siemens.com>]

Am Wed, 2 Jan 2019 12:34:11 +0100
schrieb Jan Kiszka <jan.kiszka@siemens.com>:

> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> dh_fixperms overwrites the permissions do_install defined carefully.
> Skip this step to avoid that.
> 
> Fixes: f301ccb2b5b1 ("meta/dpkg-raw: build raw packages like all
> others") CC: Henning Schild <henning.schild@siemens.com>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  meta/classes/dpkg-raw.bbclass | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/classes/dpkg-raw.bbclass
> b/meta/classes/dpkg-raw.bbclass index 8d11433..10fb1b9 100644
> --- a/meta/classes/dpkg-raw.bbclass
> +++ b/meta/classes/dpkg-raw.bbclass
> @@ -56,9 +56,11 @@ EOF
>  deb_create_rules() {
>  	cat << EOF > ${S}/debian/rules
>  #!/usr/bin/make -f
> +
> +override_dh_fixperms:
> +
>  %:
>  	dh \$@
> -

I think it is not a good idea to do that in general. While you might
have found an example where dh_fixperms caused problems, there are
probably many where it helps. Say people use "cp" to fill ${D} or
"echo" to fill ${D}/bin/

Henning

>  EOF
>  	chmod +x ${S}/debian/rules
>  }