From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6641861376070385664 X-Received: by 2002:a1c:c789:: with SMTP id x131mr996475wmf.3.1546870801663; Mon, 07 Jan 2019 06:20:01 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:3581:: with SMTP id c123ls132202wma.9.gmail; Mon, 07 Jan 2019 06:20:01 -0800 (PST) X-Google-Smtp-Source: ALg8bN5NtBtnEnN4y0Qv2TqN0ZHJyskJfmD5k/pavT2bqxtw1Y3iS8GydVE3L/AKTGid9Zdk1Q3j X-Received: by 2002:a1c:c91:: with SMTP id 139mr1078908wmm.9.1546870801243; Mon, 07 Jan 2019 06:20:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546870801; cv=none; d=google.com; s=arc-20160816; b=cFQM9ff6+ciYWkIKJJxLBISC3kd9b80aNIJrs2aApzUiW9kcctq/E+ua+vJdy+OMvM byHDJiRZ6/K9E21BEEa8Xxu8PHpPOqbkMUXZBX8TN4eiaD/KAjYH4zBic7kQCk4/FJqp kZgohSTCr33ihpUmh+pxJzoLMk65IQW00/0XENbfVppVLaYCcV+n5wkIwfit7Xo2gUEC NiT9qTRBsuZDsujPJOOixrFPprdIU3t6rasy+5bMLoICLDeEe7r+8qrWY17Cl0v8AlE/ PmToqc8XxivKYargrTFwCnMUV+ZR4sKGCXczGBN6sVGeBo9sE2C8c3/+9Y+EKN40pqOI YHYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=7VFbQvLgzVsL0DEsSmMKPo3suuoJgIYovd+tyVmpC5Y=; b=p+B5MBmLC/wuAZeyUd2fevSSWJx694CCeohk+yOqtn2G/MDC+izHTkyzo1tC+LqBdz W07sTCTPk88pw3RjFrkfd5udmjALsFH7LUUyMUM4K3Dvp1a69FIPw+t8ep/1nKQIELeb aJ8amocMmic3ZS3T2ozM0d1cXWQzX7LeNEx7kLJLKmKkm2M+g+99VNTH6zfO6lLH/OP4 l0ZsQgeZlPgUZ16Hk36+45WBZOM4SoQypHPj9GyPAJ1gGEoaS36u9xXHDcQFotnYbhxQ lTypO7J3Z8rAFj3iyD/K04cdjPVICr3OLNdIk1wowNce5hXgZ8JcGg3g9MyuZ7m1WkXp 3mZg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id f6si478391wmj.0.2019.01.07.06.20.01 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Jan 2019 06:20:01 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x07EK0v3012201 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 7 Jan 2019 15:20:00 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.69.158]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x07EK0qF024802; Mon, 7 Jan 2019 15:20:00 +0100 Date: Mon, 7 Jan 2019 15:19:59 +0100 From: Henning Schild To: Jan Kiszka Cc: isar-users Subject: Re: [PATCH 1/7] dpkg-raw: Respect file permissions defined by recipe Message-ID: <20190107151959.2627fcd8@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20190107142049.0c5426a3@md1za8fc.ad001.siemens.net> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: VjWFKHz5qOVU Am Mon, 7 Jan 2019 14:28:47 +0100 schrieb Jan Kiszka : > On 07.01.19 14:20, Henning Schild wrote: > > Am Wed, 2 Jan 2019 12:34:11 +0100 > > schrieb Jan Kiszka : > > > >> From: Jan Kiszka > >> > >> dh_fixperms overwrites the permissions do_install defined > >> carefully. Skip this step to avoid that. > >> > >> Fixes: f301ccb2b5b1 ("meta/dpkg-raw: build raw packages like all > >> others") CC: Henning Schild > >> Signed-off-by: Jan Kiszka > >> --- > >> meta/classes/dpkg-raw.bbclass | 4 +++- > >> 1 file changed, 3 insertions(+), 1 deletion(-) > >> > >> diff --git a/meta/classes/dpkg-raw.bbclass > >> b/meta/classes/dpkg-raw.bbclass index 8d11433..10fb1b9 100644 > >> --- a/meta/classes/dpkg-raw.bbclass > >> +++ b/meta/classes/dpkg-raw.bbclass > >> @@ -56,9 +56,11 @@ EOF > >> deb_create_rules() { > >> cat << EOF > ${S}/debian/rules > >> #!/usr/bin/make -f > >> + > >> +override_dh_fixperms: > >> + > >> %: > >> dh \$@ > >> - > > > > I think it is not a good idea to do that in general. While you might > > have found an example where dh_fixperms caused problems, there are > > probably many where it helps. Say people use "cp" to fill ${D} or > > "echo" to fill ${D}/bin/ > > I'm open for better suggestions. The suggestion is to do that in the one recipe that you need it for, and not touch the general case. Henning > Jan >