From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6644847399572340736 X-Received: by 2002:a5d:45c5:: with SMTP id b5mr429944wrs.24.1547124097697; Thu, 10 Jan 2019 04:41:37 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:dc04:: with SMTP id t4ls1560188wmg.12.gmail; Thu, 10 Jan 2019 04:41:37 -0800 (PST) X-Google-Smtp-Source: ALg8bN6/rfSmAvzV/YMH63OUEgJvLbHjdK5DLBKCqCbW06P9Ml2bZM4+8tunA3r68WE8qI34w/Xf X-Received: by 2002:a1c:e308:: with SMTP id a8mr511623wmh.14.1547124097312; Thu, 10 Jan 2019 04:41:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547124097; cv=none; d=google.com; s=arc-20160816; b=TfmCrALCyQl1pV7p24HEgxWyexkMWUFOc6vO/BENQFnsrIsmJmKLmiBZ/8y7gUA9AR sP9ekzGwk758LyjLlL6/yKje3lmHIAoYlgyHvsdS3ZKolxf/yyCZ0Ta/iHgcYxZ06hWQ BAmAXTA4XGJoOMK0UiLxoWuyQDhw3dSKouhkczqsg2B46EFXOagpB9rRGw7TXk22a/N5 IIL4Bg1fVhhtEdd92VRQvo6WVvIaiZZRAJuuUDIUAqNPhv+jS6Bafxpw4tBUUu2GCqYK k6wYLL7IvRgHHPcU57MkL+k08aUqz11QfHPRLMGmJVY8ZEGyxAaA/22+3K5vTGIzBvLa ktGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=T8f4cjMQbZC4kkDC0kyMnje1XZq0GW2iGKixTpWSYYQ=; b=r+0SaVDlUhnQY0+kfFBujHkXpmFcOng8QwpUSh1f1LT9IC0eiw+eNwhKbVusZcapzU hQwdyblGut/9tDo6XMy4dhc4zgeLDYZYh5+kFHaM/stysfpC91/7cjah221SKaaYT/Ol fNkmrxAVT82LzOTfdUKUHsB2DgeepiS2keoYgumyb4N2E1K3t0U7kypnOqpzRNWVgZM5 O1AyirvXWg8yLEyAwhEAj9LYMGA9ajQipdvkxwcsukrpK2x+R9gSGear8FwaDWoEUJ5C HMKh6Kp/y9kAU5IoAYBAQYJzo+FLhluzENTAXI+mFojfs84NGv38daGgPCxmy0KrCeBp 2iUQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id 20si148147wmy.2.2019.01.10.04.41.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Jan 2019 04:41:37 -0800 (PST) Received-SPF: pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Received: from mail2.siemens.de (mail2.siemens.de [139.25.208.11]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x0ACfaHl005760 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 10 Jan 2019 13:41:36 +0100 Received: from localhost.localdomain (golem.ppmd.siemens.net [139.25.69.17]) by mail2.siemens.de (8.15.2/8.15.2) with ESMTP id x0ACfatU009140; Thu, 10 Jan 2019 13:41:36 +0100 From: "Andreas J. Reichel" To: isar-users@googlegroups.com Cc: Andreas Reichel Subject: [PATCH] Fix wrong inline python in isar-image.bbclass Date: Thu, 10 Jan 2019 13:33:15 +0100 Message-Id: <20190110123315.7647-1-andreas.reichel.ext@siemens.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: jHR1mTuMSNVD From: Andreas Reichel The inline python string used a mixture of python and shell, which failed while parsing recipes with: The URL: '${@' is invalid and cannot be interpreted Problem is that in SRC_URI += "${@ 'file://${DISTRO_CONFIG_SCRIPT}' if '${DISTRO_CONFIG_SCRIPT}' else '' }" ${DISTRO_CONFIG_SCRIPT} is not interpreted correctly. Use d.getVar instead. Signed-off-by: Andreas Reichel --- meta/classes/isar-image.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass index 754e896..b6f8848 100644 --- a/meta/classes/isar-image.bbclass +++ b/meta/classes/isar-image.bbclass @@ -7,7 +7,7 @@ inherit image inherit isar-bootstrap-helper FILESPATH =. "${LAYERDIR_isar}/conf/distro:" -SRC_URI += "${@ 'file://${DISTRO_CONFIG_SCRIPT}' if '${DISTRO_CONFIG_SCRIPT}' else '' }" +SRC_URI += "${@ d.getVar('DISTRO_CONFIG_SCRIPT', True) or '' }" DEPENDS += "${IMAGE_INSTALL} ${IMAGE_TRANSIENT_PACKAGES}" -- 2.20.1