From: Andreas Reichel <andreas.reichel.ext@siemens.com>
To: Henning Schild <henning.schild@siemens.com>
Cc: isar-users@googlegroups.com
Subject: Re: [PATCH] Fix wrong inline python in isar-image.bbclass
Date: Thu, 10 Jan 2019 14:45:08 +0100 [thread overview]
Message-ID: <20190110134508.GA19146@iiotirae> (raw)
In-Reply-To: <20190110143156.6c9d61a4@md1za8fc.ad001.siemens.net>
On Thu, Jan 10, 2019 at 02:31:56PM +0100, Henning Schild wrote:
> Am Thu, 10 Jan 2019 13:33:15 +0100
> schrieb "[ext] Andreas J. Reichel" <andreas.reichel.ext@siemens.com>:
>
> > From: Andreas Reichel <andreas.reichel.ext@siemens.com>
> >
> > The inline python string used a mixture of python
> > and shell, which failed while parsing recipes with:
> >
> > The URL: '${@' is invalid and cannot be interpreted
> >
> > Problem is that in
> >
> > SRC_URI += "${@ 'file://${DISTRO_CONFIG_SCRIPT}' if
> > '${DISTRO_CONFIG_SCRIPT}' else '' }"
> >
> > ${DISTRO_CONFIG_SCRIPT} is not interpreted correctly.
> > Use d.getVar instead.
> >
> > Signed-off-by: Andreas Reichel <andreas.reichel.ext@siemens.com>
> > ---
> > meta/classes/isar-image.bbclass | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/isar-image.bbclass
> > b/meta/classes/isar-image.bbclass index 754e896..b6f8848 100644
> > --- a/meta/classes/isar-image.bbclass
> > +++ b/meta/classes/isar-image.bbclass
> > @@ -7,7 +7,7 @@ inherit image
> > inherit isar-bootstrap-helper
> >
> > FILESPATH =. "${LAYERDIR_isar}/conf/distro:"
> > -SRC_URI += "${@ 'file://${DISTRO_CONFIG_SCRIPT}' if
> > '${DISTRO_CONFIG_SCRIPT}' else '' }" +SRC_URI += "${@
> > d.getVar('DISTRO_CONFIG_SCRIPT', True) or '' }"
> > DEPENDS += "${IMAGE_INSTALL} ${IMAGE_TRANSIENT_PACKAGES}"
>
> Where did the file:// go, or is it not needed?
>
Thanks I just saw that because I got a new error. Sorry. I am fixing
that. Before it was deployed and therefore it did not warn nor error.
> Henning
>
--
Andreas Reichel
Dipl.-Phys. (Univ.)
Software Consultant
Andreas.Reichel@tngtech.com, +49-174-3180074
TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring
Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller
Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082
prev parent reply other threads:[~2019-01-10 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-10 12:33 Andreas J. Reichel
2019-01-10 13:31 ` Henning Schild
2019-01-10 13:45 ` Andreas Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110134508.GA19146@iiotirae \
--to=andreas.reichel.ext@siemens.com \
--cc=henning.schild@siemens.com \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox