From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6644847399572340736 X-Received: by 2002:adf:fb84:: with SMTP id a4mr472225wrr.1.1547128399701; Thu, 10 Jan 2019 05:53:19 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:e919:: with SMTP id q25ls1654386wmc.6.gmail; Thu, 10 Jan 2019 05:53:19 -0800 (PST) X-Google-Smtp-Source: ALg8bN6O2NjbPvsC4VqES9Q2p0lUy70euNsCdlIGcdfg1kAtx34+MdNlU8dApRvZDhjXyBEX2V33 X-Received: by 2002:a1c:96d2:: with SMTP id y201mr527882wmd.3.1547128399338; Thu, 10 Jan 2019 05:53:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547128399; cv=none; d=google.com; s=arc-20160816; b=ebDAo525Mib9UWeGpToXpecGEbCpLgbVqM3yecEOItEJL0w22wlVfKaHp0l+s7kg8G lBSu64Bk0rFnNBXrBTFfXss2ESJicasBMNqzkjdxHRXjjdrnl2ZYStEs7AVOztSAUNU5 e+T18dWmTLByDhhzZ3QJGlNPSwkGrIwwEIarS7oJHLPJ89vDHvUY8C0XNFxjsbSBHTwv tvijBcnatvgQBoQcPuLXYSPisW8mTHLcrORa0mucyrL9eIje+8m5KzKiVR5WvfMb/V2Z +paqp1JhV//BgJ/f7EC50/xJwZjdCv750AJX6HaIcl0Y7tVe9KLdbKiTHkpoguMTj+6d cDvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:content-description :mime-version:references:message-id:subject:cc:to:from:date; bh=6eoh/M62rOTSkQDAIa1dLIMeI5t5rUKhqRhVjo9YJ/I=; b=r7YAi/6sIA9eIeyekxT82dyOBWyOcDW7vwIjJ77u0b9fAWXrrneYS2ieX9TvA8hk/W t7KTxqUzoltIzHESfjp1ROKyAVG1bqdw3GN/M1Zufbk8k5z1aEXHC/Y9JEe9Awtc1onD N2DvrauJIiuaX2H9xHzwNFV1XqrE+0zYJNnqHfEYb1KZzrioSjvr3brSUS6W+d0C7QD9 OdcA4pnrpJgAMQ0sjur9XML4ijHko5IUBiaprhQeU0ZRjzQ2PqS9R8eegKdZpzam8GFi J8dVNL8cW0onx1qiSul0PySc+t65aN3ffxQhSyRhVN0V6PadxfdfUzVicx3yH2y/oLmk Z8ng== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id 20si154188wmy.2.2019.01.10.05.53.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Jan 2019 05:53:19 -0800 (PST) Received-SPF: pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of andreas.reichel.ext@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=andreas.reichel.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x0ADrI8b016200 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 10 Jan 2019 14:53:18 +0100 Received: from iiotirae (golem.ppmd.siemens.net [139.25.69.17]) by mail1.sbs.de (8.15.2/8.15.2) with SMTP id x0ADrIJ8020301; Thu, 10 Jan 2019 14:53:18 +0100 Date: Thu, 10 Jan 2019 14:45:08 +0100 From: Andreas Reichel To: Henning Schild Cc: isar-users@googlegroups.com Subject: Re: [PATCH] Fix wrong inline python in isar-image.bbclass Message-ID: <20190110134508.GA19146@iiotirae> References: <20190110123315.7647-1-andreas.reichel.ext@siemens.com> <20190110143156.6c9d61a4@md1za8fc.ad001.siemens.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Description: message Content-Disposition: inline In-Reply-To: <20190110143156.6c9d61a4@md1za8fc.ad001.siemens.net> User-Agent: Mutt/1.11.2 (2019-01-07) X-TUID: cp7iiYBSIAg8 On Thu, Jan 10, 2019 at 02:31:56PM +0100, Henning Schild wrote: > Am Thu, 10 Jan 2019 13:33:15 +0100 > schrieb "[ext] Andreas J. Reichel" : > > > From: Andreas Reichel > > > > The inline python string used a mixture of python > > and shell, which failed while parsing recipes with: > > > > The URL: '${@' is invalid and cannot be interpreted > > > > Problem is that in > > > > SRC_URI += "${@ 'file://${DISTRO_CONFIG_SCRIPT}' if > > '${DISTRO_CONFIG_SCRIPT}' else '' }" > > > > ${DISTRO_CONFIG_SCRIPT} is not interpreted correctly. > > Use d.getVar instead. > > > > Signed-off-by: Andreas Reichel > > --- > > meta/classes/isar-image.bbclass | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/classes/isar-image.bbclass > > b/meta/classes/isar-image.bbclass index 754e896..b6f8848 100644 > > --- a/meta/classes/isar-image.bbclass > > +++ b/meta/classes/isar-image.bbclass > > @@ -7,7 +7,7 @@ inherit image > > inherit isar-bootstrap-helper > > > > FILESPATH =. "${LAYERDIR_isar}/conf/distro:" > > -SRC_URI += "${@ 'file://${DISTRO_CONFIG_SCRIPT}' if > > '${DISTRO_CONFIG_SCRIPT}' else '' }" +SRC_URI += "${@ > > d.getVar('DISTRO_CONFIG_SCRIPT', True) or '' }" > > DEPENDS += "${IMAGE_INSTALL} ${IMAGE_TRANSIENT_PACKAGES}" > > Where did the file:// go, or is it not needed? > Thanks I just saw that because I got a new error. Sorry. I am fixing that. Before it was deployed and therefore it did not warn nor error. > Henning > -- Andreas Reichel Dipl.-Phys. (Univ.) Software Consultant Andreas.Reichel@tngtech.com, +49-174-3180074 TNG Technology Consulting GmbH, Betastr. 13a, 85774 Unterfoehring Geschaeftsfuehrer: Henrik Klagges, Dr. Robert Dahlke, Gerhard Mueller Sitz: Unterfoehring * Amtsgericht Muenchen * HRB 135082