Re: [PATCH] Fix wrong inline python in isar-image.bbclass

[Henning Schild <henning.schild@siemens.com>]

Am Thu, 10 Jan 2019 13:33:15 +0100
schrieb "[ext] Andreas J. Reichel" <andreas.reichel.ext@siemens.com>:

> From: Andreas Reichel <andreas.reichel.ext@siemens.com>
> 
> The inline python string used a mixture of python
> and shell, which failed while parsing recipes with:
> 
> The URL: '${@' is invalid and cannot be interpreted
> 
> Problem is that in
> 
> SRC_URI += "${@ 'file://${DISTRO_CONFIG_SCRIPT}' if
> '${DISTRO_CONFIG_SCRIPT}' else '' }"
> 
> ${DISTRO_CONFIG_SCRIPT} is not interpreted correctly.
> Use d.getVar instead.
> 
> Signed-off-by: Andreas Reichel <andreas.reichel.ext@siemens.com>
> ---
>  meta/classes/isar-image.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/isar-image.bbclass
> b/meta/classes/isar-image.bbclass index 754e896..b6f8848 100644
> --- a/meta/classes/isar-image.bbclass
> +++ b/meta/classes/isar-image.bbclass
> @@ -7,7 +7,7 @@ inherit image
>  inherit isar-bootstrap-helper
>  
>  FILESPATH =. "${LAYERDIR_isar}/conf/distro:"
> -SRC_URI += "${@ 'file://${DISTRO_CONFIG_SCRIPT}' if
> '${DISTRO_CONFIG_SCRIPT}' else '' }" +SRC_URI += "${@
> d.getVar('DISTRO_CONFIG_SCRIPT', True) or '' }" 
>  DEPENDS += "${IMAGE_INSTALL} ${IMAGE_TRANSIENT_PACKAGES}"

Where did the file:// go, or is it not needed?

Henning