From mboxrd@z Thu Jan  1 00:00:00 1970
X-GM-THRID: 6644847399572340736
X-Received: by 2002:a1c:aac9:: with SMTP id t192mr509494wme.23.1547127117433;
        Thu, 10 Jan 2019 05:31:57 -0800 (PST)
X-BeenThere: isar-users@googlegroups.com
Received: by 2002:a1c:20c8:: with SMTP id g191ls1627699wmg.4.gmail; Thu, 10
 Jan 2019 05:31:57 -0800 (PST)
X-Google-Smtp-Source: ALg8bN59hupm7NVyV4qrZ+kSMUykgDmX6pWGKmXiBvvGIKg0M9FlSDfSreNUy825vo8uiKV9stce
X-Received: by 2002:a1c:c91:: with SMTP id 139mr582347wmm.9.1547127117013;
        Thu, 10 Jan 2019 05:31:57 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1547127117; cv=none;
        d=google.com; s=arc-20160816;
        b=sjR364D06zx0hLplbcYg7OXApea32Xy4FtOfsmTugEnmc3nXeG0YbYLAV9JHTgtz5/
         KOGrgLvudoaW2N6Ulv/D+3qlPRvKquryPw7qZ0XfD6Gdk0s+PRvd0DAPhfhI6BZE2yg2
         LmXQzZrwPZinHEcEYijD+FMV0sYW9o74ON5jWwutVpnA9U0p5t8k0pd/v9LKltcFaV9d
         rfdfQc1XwPUs6iYWgCYzcM516H9HnafSLB1F346z64t+OtMPFewsFIyHjaEeH5V9fvwv
         Hma337088UnUbRaboUZ0Jkj+TlzlxFwcP5DJSNxh0vg6BkBzQO8NUeY8bnyq6A1OvFvz
         TbKg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=content-transfer-encoding:mime-version:references:in-reply-to
         :message-id:subject:cc:to:from:date;
        bh=Bmcv0zJzuAkoa+L7lrZgP2gWUgV49x66YGQDV5YPHnY=;
        b=ogtja4S8WEQlpgPRqlPlMmgVNjccbUD7tUgp5LD0ZQJpnjjpVO+tSzToGRTRtef83H
         FiZUYxLbGPiq1KQCkJ3S2GmwvRZ+pjR5TymN9FY8df8SXtUnd6OW/lpQeMmuKto19JpW
         MTdoLfFB+fclXX4uL7RstBA5JiiLtQ6eXG9JK+F7DvgG/dBxoA+D0mGK/SPwngYBCRY4
         s+843TDjnh2pMygas22fy5mHP1f3ejW64zyRJeklP9Rm/zbRZjbgORHLMWG+yCcCVDwZ
         sd6ttvYdw40NwVa+jWqS5okwYOZnvftuxsTkHwMxEFDM09jw9pYAb6UQ4cggxIng9DCV
         D4kw==
ARC-Authentication-Results: i=1; gmr-mx.google.com;
       spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com
Return-Path: <henning.schild@siemens.com>
Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28])
        by gmr-mx.google.com with ESMTPS id 69si2016366wrb.1.2019.01.10.05.31.56
        for <isar-users@googlegroups.com>
        (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
        Thu, 10 Jan 2019 05:31:57 -0800 (PST)
Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28;
Authentication-Results: gmr-mx.google.com;
       spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com
Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35])
	by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x0ADVuMp002216
	(version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK)
	for <isar-users@googlegroups.com>; Thu, 10 Jan 2019 14:31:56 +0100
Received: from md1za8fc.ad001.siemens.net ([139.25.0.115])
	by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x0ADVuEY021696;
	Thu, 10 Jan 2019 14:31:56 +0100
Date: Thu, 10 Jan 2019 14:31:56 +0100
From: Henning Schild <henning.schild@siemens.com>
To: "[ext] Andreas J. Reichel" <andreas.reichel.ext@siemens.com>
Cc: <isar-users@googlegroups.com>
Subject: Re: [PATCH] Fix wrong inline python in isar-image.bbclass
Message-ID: <20190110143156.6c9d61a4@md1za8fc.ad001.siemens.net>
In-Reply-To: <20190110123315.7647-1-andreas.reichel.ext@siemens.com>
References: <20190110123315.7647-1-andreas.reichel.ext@siemens.com>
X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-TUID: c2o4Q3WhyX/5

Am Thu, 10 Jan 2019 13:33:15 +0100
schrieb "[ext] Andreas J. Reichel" <andreas.reichel.ext@siemens.com>:

> From: Andreas Reichel <andreas.reichel.ext@siemens.com>
> 
> The inline python string used a mixture of python
> and shell, which failed while parsing recipes with:
> 
> The URL: '${@' is invalid and cannot be interpreted
> 
> Problem is that in
> 
> SRC_URI += "${@ 'file://${DISTRO_CONFIG_SCRIPT}' if
> '${DISTRO_CONFIG_SCRIPT}' else '' }"
> 
> ${DISTRO_CONFIG_SCRIPT} is not interpreted correctly.
> Use d.getVar instead.
> 
> Signed-off-by: Andreas Reichel <andreas.reichel.ext@siemens.com>
> ---
>  meta/classes/isar-image.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/isar-image.bbclass
> b/meta/classes/isar-image.bbclass index 754e896..b6f8848 100644
> --- a/meta/classes/isar-image.bbclass
> +++ b/meta/classes/isar-image.bbclass
> @@ -7,7 +7,7 @@ inherit image
>  inherit isar-bootstrap-helper
>  
>  FILESPATH =. "${LAYERDIR_isar}/conf/distro:"
> -SRC_URI += "${@ 'file://${DISTRO_CONFIG_SCRIPT}' if
> '${DISTRO_CONFIG_SCRIPT}' else '' }" +SRC_URI += "${@
> d.getVar('DISTRO_CONFIG_SCRIPT', True) or '' }" 
>  DEPENDS += "${IMAGE_INSTALL} ${IMAGE_TRANSIENT_PACKAGES}"

Where did the file:// go, or is it not needed?

Henning