From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6646963335912751104 X-Received: by 2002:a1c:9cc2:: with SMTP id f185mr638671wme.10.1547631699743; Wed, 16 Jan 2019 01:41:39 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:5148:: with SMTP id u8ls1179182wrt.17.gmail; Wed, 16 Jan 2019 01:41:39 -0800 (PST) X-Google-Smtp-Source: ALg8bN4CA2xLCI4hNbxJUVIUoZ2h6+0ocoCKjhQPYNX72rD1RpkEJdMbO8CAW6Jm8q1OujzogjBX X-Received: by 2002:adf:f248:: with SMTP id b8mr527109wrp.9.1547631699344; Wed, 16 Jan 2019 01:41:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547631699; cv=none; d=google.com; s=arc-20160816; b=RBcIJBpRCyGNaq3NO8ikjr8mZLbB9ri7Pqx1YijUG5ersFzo6g2gaTDoC5yyMZM+ma kjBHaZs3RYty9NNbkvzSLYrFPt/nEVUR+9pNW+C4Jnllw59+k+eIDkN5CAOufob67123 wHXPZPBBD2H7BTndi27ghJqBYdZc6lJ6OJMhc5l6Ttz261kNACbvI4jwQfUN52JxkXse pDTtk2TGLJqWjRoUW3S208oC0vCKZEDvVUTzN9GmmWYsdX+hsVNhpe1jlpvRScG5ZB5J BBAOFEI1DNwZ0wgDO4sEEAwcgJCX+zfrweHt/TD9YgnjfseYoUBt55+gwo4TuxXCaXQb 1MXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=9mONZjhyIoFpA+3/9lPmaTX0vHUG/c5/q9nKk7ynMSg=; b=NY3bClWWaxEbb1UcnFrdNnf7YTOFwr3jyqDvifptFsSD+XQMoyKUIaDMHgIf+aH7Os Nik+sGXQEb2rIDKjKTybRUSlZ1NweJlJtT7Oy/tQjgoopVAo9qzVuAWHJyS07qcHbAjB wXIxOgKu2kqw3k8emve9+F7YIQB/dVKbEKzDKg7HuUgkT5j8GRb69DaCqBlgG0JZY/9q xIYo8rD60kbTawiuDVh7NBSXTJE3VCOSx1SItlqxwqzPCVsaYCuZZ3jlaTLCR4oqASvq SUsH/JAxER5XDGsqOoi9KP/iaz6JEbHQ/3QIxocxcMwtXigkkMzQnyIBWHFd6+5GffeC /0bg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id z207si1405642wmc.2.2019.01.16.01.41.39 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jan 2019 01:41:39 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x0G9fdBQ014328 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 16 Jan 2019 10:41:39 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.69.250]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x0G9fc1p030778; Wed, 16 Jan 2019 10:41:38 +0100 Date: Wed, 16 Jan 2019 10:41:38 +0100 From: Henning Schild To: Jan Kiszka Cc: isar-users Subject: Re: [PATCH v3 01/14] dpkg-raw: Respect file permissions defined by recipe if requested Message-ID: <20190116104138.356cd52c@md1za8fc.ad001.siemens.net> In-Reply-To: <97edc3d29b4aaa19dbbb067e13335beda3f74447.1547616747.git.jan.kiszka@siemens.com> References: <97edc3d29b4aaa19dbbb067e13335beda3f74447.1547616747.git.jan.kiszka@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: XZxCRMW8hoy5 Am Wed, 16 Jan 2019 06:32:14 +0100 schrieb Jan Kiszka : > From: Jan Kiszka > > dh_fixperms overwrites the permissions do_install may have defined. To > avoid that, allow the recipe write to define an exception list via the > PRESERVE_PERMS variable. > > Fixes: f301ccb2b5b1 ("meta/dpkg-raw: build raw packages like all > others") CC: Henning Schild > Signed-off-by: Jan Kiszka > --- > RECIPE-API-CHANGELOG.md | 7 +++++++ > meta/classes/dpkg-raw.bbclass | 9 ++++++++- > 2 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md > index 06a01e3..2bc1585 100644 > --- a/RECIPE-API-CHANGELOG.md > +++ b/RECIPE-API-CHANGELOG.md > @@ -124,3 +124,10 @@ updated hence recipes using them shouldn't be > impacted per se. > These packages depend on a specific kernel. Its identification is > now appended to the binary package names in the form > "-${KERNEL_NAME}". + > +### PRESERVE_PERMS needed with dpkg-raw for implicit file permission > setting + > +In order to use the same file permissions for an input file to a > dpkg-raw +package on the build machine as well as on the target, its > absolute target path +needs to be listed in the PRESERVE_PERMS > variable (space-separated list of +files). Otherwise, default > permissions are used. diff --git a/meta/classes/dpkg-raw.bbclass > b/meta/classes/dpkg-raw.bbclass index 8d11433..42276e5 100644 > --- a/meta/classes/dpkg-raw.bbclass > +++ b/meta/classes/dpkg-raw.bbclass > @@ -53,12 +53,19 @@ Description: ${DESCRIPTION} > EOF > } > > +FIXPERM_EXCLUSIONS = \ > + "${@' '.join(['-X ' + x for x in \ > + (d.getVar('PRESERVE_PERMS', False) or > '').split()])}" + > deb_create_rules() { > cat << EOF > ${S}/debian/rules > #!/usr/bin/make -f > + > +override_dh_fixperms: > + dh_fixperms ${FIXPERM_EXCLUSIONS} > + This should be done only if the variable is non-empty, to keep that code generic. Also the variable name should maybe start with DH_ or DEBIAN_. Henning > %: > dh \$@ > - > EOF > chmod +x ${S}/debian/rules > }