From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6646963333394071552 X-Received: by 2002:adf:ee51:: with SMTP id w17mr490372wro.17.1547632026842; Wed, 16 Jan 2019 01:47:06 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a5d:5088:: with SMTP id a8ls1185015wrt.14.gmail; Wed, 16 Jan 2019 01:47:06 -0800 (PST) X-Google-Smtp-Source: ALg8bN4QffjE7gqcrNnSjXn8othRhUVlfh9F8/z9Qorz/0TzmPNun/2Ps8ctUHCQZzCZWLA47LU+ X-Received: by 2002:adf:e507:: with SMTP id j7mr516944wrm.12.1547632026454; Wed, 16 Jan 2019 01:47:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547632026; cv=none; d=google.com; s=arc-20160816; b=gKoQpSiW7HFJYirWafhLcemrjFuhBFtydJDu6aynwjee/FKTKV0evJsqnub94B/B2X yr9h+xb4boKs3ncwtGYOf6gKMkljBdUGTNCsTmsnhorsIAYbEbPeVJCrNnK3avGx6OrF 6HQtTcoJ4T+KP1kUpqC7gYQ+EJJUAlkR+Vb5aQMQvX8H8UYCQu66Ix4MRjm3tTB0WUoR tNLkMBy7K8Jzh54d1YMF0DU2xkIteiGNUrxlf3VsujB/G1qwipTRsHFKdAe25YrGO1JK PBOsZQ2Z/6fh8Z0HmqRge1QnlDkVzNK3Xi+E+3p/zsyFt7ByTSIdD+29fsY+RHKwzhZ6 fRxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=Y/t+Vgo2n2S1cLbIoL/fL0jqFz8Z9VkzMPhQ/4/xhXk=; b=W3q5iEVB513Q93jz5UQCNSrDAQPPGGYFenQ4XFCOxEfgddW2nSdWzfO1h/btkNZLd6 Ue1wlfezAVG7Xq89hF2YBNRQlirX8/3YQnI3P4uAtijmEXDPbDhNeqsh5oRqtigv97At wVNUrqSDkgvRF2SKUefeUMmijL4RuVeeAXzVgD4qCsgefHnveXnD2oM7rblb7csMOP0p Ba15/lxiwhRhwSH0RarcWEaepXHR+EaCaGVjgtNaIXJiIAenyweOPIP9qDkm7dTzPcIR vLeRijzhKVYQNNRQmIKds6BilZvmqyvpueeunZ4Evoan2Nrwpc6dQeKXBs6+E2AMXDHN Rypg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id j45si1925579wre.0.2019.01.16.01.47.06 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jan 2019 01:47:06 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x0G9l6SC000717 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 16 Jan 2019 10:47:06 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.69.250]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x0G9l6Fd018270; Wed, 16 Jan 2019 10:47:06 +0100 Date: Wed, 16 Jan 2019 10:47:05 +0100 From: Henning Schild To: "[ext] Jan Kiszka" Cc: isar-users Subject: Re: [PATCH v3 08/14] bootimg-efi-isar: Fix serial console setup for grub Message-ID: <20190116104705.201f38c9@md1za8fc.ad001.siemens.net> In-Reply-To: References: X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 94ceYjh9+lm5 Am Wed, 16 Jan 2019 06:32:21 +0100 schrieb "[ext] Jan Kiszka" : > From: Jan Kiszka > > We were lacking terminal_input/output to make the serial console truly > work. > > Signed-off-by: Jan Kiszka > --- > meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py > b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py index > 1ca200f..c6a6a02 100644 --- > a/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py +++ > b/meta/scripts/lib/wic/plugins/source/bootimg-efi-isar.py @@ -65,8 > +65,10 @@ class BootimgEFIPlugin(SourcePlugin): # Create grub > configuration using parameters from wks file bootloader = > creator.ks.bootloader > - grubefi_conf = "" > - grubefi_conf += "serial --unit=0 --speed=115200 --word=8 > --parity=no --stop=1\n" > + grubefi_conf = "serial --unit=0 --speed=115200 --word=8 > --parity=no --stop=1\n" > + grubefi_conf += "terminal_input --append serial\n" > + grubefi_conf += "terminal_output --append serial\n" > + grubefi_conf += "\n" Good catch and very useful improvement! Would it help to involve grub-mkconfig into the flow and create the config from something like /etc/default/grub? Henning > grubefi_conf += "default=boot\n" > grubefi_conf += "timeout=%s\n" % bootloader.timeout > for part in creator.parts: