From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6646963335912751104 X-Received: by 2002:adf:b6ab:: with SMTP id j43mr640755wre.22.1547652261732; Wed, 16 Jan 2019 07:24:21 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:e452:: with SMTP id t18ls1445268wrm.3.gmail; Wed, 16 Jan 2019 07:24:21 -0800 (PST) X-Google-Smtp-Source: ALg8bN5T2McvMIQA/NORzgshvP+K9ZV6nv+UmV4+Z9XndX27NnCIxxcICeB+1LBGERS24tesDzzh X-Received: by 2002:adf:fdcd:: with SMTP id i13mr636178wrs.32.1547652261303; Wed, 16 Jan 2019 07:24:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547652261; cv=none; d=google.com; s=arc-20160816; b=SF+InlerApqEFwcgBH2QBjN5GoJzLe7kpadI1dYDRorfmD0qS8qcTUkHNwribyW5oa aktdbN6lmhtFHSUI+Zg5t2TTf4JGrHbOc83Vkiv0xoH3JmjlLs6mORIrxfwt8rWegew/ GwAh6EHPRY7Yflm9+RDHSmjxKwNbyrqIRGC7JBr0NpqG9Cy4PmT3dxy6+LPgmdui0X9d yhm7sfpMujUrcMl/AfRvUvrMqBDTR/gvpCAexgnMbXGNfmMMBaSWNAc1pE666DAJuzy2 jBE/qjSkCyv1TdMispQAG6Pg3fn/RDOeVv/OoiPsyloocuAeTWAXa5ivHLjDJULM5Gxp qJUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=cmm1u37RSHarC5eD46RRwcpPXmIZEwK0VYqDZ7oRpgk=; b=H0jcT9wG7mQwxpZyYkX3Qs7OnLzt8K38Ux5tN73SjWzGq9ps47FbAIe5qfUB100kf9 +CiQQP53YELewJUgZMtzkhhKD/sO/riORz0vXbdh+l9XcfzpNElPFhIhIsHtKyf01Z+m a1BC3ZHD3LTJzsowRnziCvSWDXhGIN91m0slnd0HAm59p/I9eg1h/mcuwujtEiELfUmS M52qT0bFWsGs94oBFwR7IWHzxKgaY3WVJBHsrt6LHXfs8dRW0vDEsInVTZeOdiJV7k6t UHXkgqmqHxR55ra0bjxIMFtMPX9e7oN26ZHU57/y3KxU5rhWhAzNgLRH64qRqdZzGVHx 7qcA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id x13si3295991wrn.3.2019.01.16.07.24.21 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jan 2019 07:24:21 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x0GFOKoY012053 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 16 Jan 2019 16:24:20 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.69.250]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x0GFOKb5032172; Wed, 16 Jan 2019 16:24:20 +0100 Date: Wed, 16 Jan 2019 16:24:20 +0100 From: Henning Schild To: Jan Kiszka Cc: isar-users Subject: Re: [PATCH v3 01/14] dpkg-raw: Respect file permissions defined by recipe if requested Message-ID: <20190116162420.3cadec9a@md1za8fc.ad001.siemens.net> In-Reply-To: <39793b3d-d5c5-4bc4-d16a-7aff13baaa5f@siemens.com> References: <97edc3d29b4aaa19dbbb067e13335beda3f74447.1547616747.git.jan.kiszka@siemens.com> <20190116104138.356cd52c@md1za8fc.ad001.siemens.net> <39793b3d-d5c5-4bc4-d16a-7aff13baaa5f@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: Kli3dQtpT+2G Am Wed, 16 Jan 2019 13:11:47 +0100 schrieb Jan Kiszka : > On 16.01.19 10:41, Henning Schild wrote: > > Am Wed, 16 Jan 2019 06:32:14 +0100 > > schrieb Jan Kiszka : > > > >> From: Jan Kiszka > >> > >> dh_fixperms overwrites the permissions do_install may have > >> defined. To avoid that, allow the recipe write to define an > >> exception list via the PRESERVE_PERMS variable. > >> > >> Fixes: f301ccb2b5b1 ("meta/dpkg-raw: build raw packages like all > >> others") CC: Henning Schild > >> Signed-off-by: Jan Kiszka > >> --- > >> RECIPE-API-CHANGELOG.md | 7 +++++++ > >> meta/classes/dpkg-raw.bbclass | 9 ++++++++- > >> 2 files changed, 15 insertions(+), 1 deletion(-) > >> > >> diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md > >> index 06a01e3..2bc1585 100644 > >> --- a/RECIPE-API-CHANGELOG.md > >> +++ b/RECIPE-API-CHANGELOG.md > >> @@ -124,3 +124,10 @@ updated hence recipes using them shouldn't be > >> impacted per se. > >> These packages depend on a specific kernel. Its identification is > >> now appended to the binary package names in the form > >> "-${KERNEL_NAME}". + > >> +### PRESERVE_PERMS needed with dpkg-raw for implicit file > >> permission setting + > >> +In order to use the same file permissions for an input file to a > >> dpkg-raw +package on the build machine as well as on the target, > >> its absolute target path +needs to be listed in the PRESERVE_PERMS > >> variable (space-separated list of +files). Otherwise, default > >> permissions are used. diff --git a/meta/classes/dpkg-raw.bbclass > >> b/meta/classes/dpkg-raw.bbclass index 8d11433..42276e5 100644 > >> --- a/meta/classes/dpkg-raw.bbclass > >> +++ b/meta/classes/dpkg-raw.bbclass > >> @@ -53,12 +53,19 @@ Description: ${DESCRIPTION} > >> EOF > >> } > >> > >> +FIXPERM_EXCLUSIONS = \ > >> + "${@' '.join(['-X ' + x for x in \ > >> + (d.getVar('PRESERVE_PERMS', False) or > >> '').split()])}" + > >> deb_create_rules() { > >> cat << EOF > ${S}/debian/rules > >> #!/usr/bin/make -f > >> + > >> +override_dh_fixperms: > >> + dh_fixperms ${FIXPERM_EXCLUSIONS} > >> + > > > > This should be done only if the variable is non-empty, to keep that > > code generic. Also the variable name should maybe start with DH_ or > > DEBIAN_. > > I can change the naming, but I disagree regarding your other concern: > dh_fixperms is by definition the default case if there is no > override. Therefore > > override_dh_fixperms: > dh_fixperms I would not be sure. Say a later step in some layers append would want to set an actual override would the two conflict? Henning > > would be pointless but always correct. > > Jan >