public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] linux-custom: use slightly faster make target
Date: Thu, 17 Jan 2019 11:15:23 +0100	[thread overview]
Message-ID: <20190117111523.7ef0db65@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <1dd3dcf6-b634-c349-babf-a8cd11baf0d1@siemens.com>

Am Wed, 16 Jan 2019 20:14:42 +0100
schrieb Jan Kiszka <jan.kiszka@siemens.com>:

> On 16.01.19 16:20, Henning Schild wrote:
> > From: Henning Schild <henning.schild@siemens.com>
> > 
> > Skip building the source deb package, which is not used anyways.  
> 
> Aren't we building source packages with dpkg[-raw] as well? We may
> not exploit this feature systematically yet to create source repos,
> but we will for sure in the not so far future. So I see no reason to
> apply this patch now and then revert it later on again.

Not building the source packages would save a lot of time. But the
patch is indeed inconsistent since it should also disable building
source packages for the dpkg-buildpackage case.
If we ever gain support for source package repos, building source
packages should depend on that feature and be optional. So i would
actually send a v2 this disables source package builds for the other
flow as well.

Henning

> Jan
> 
> > 
> > Signed-off-by: Henning Schild <henning.schild@siemens.com>
> > ---
> >   meta/recipes-kernel/linux/files/build-kernel.sh | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/meta/recipes-kernel/linux/files/build-kernel.sh
> > b/meta/recipes-kernel/linux/files/build-kernel.sh index
> > dbd6162..ddc9d0c 100644 ---
> > a/meta/recipes-kernel/linux/files/build-kernel.sh +++
> > b/meta/recipes-kernel/linux/files/build-kernel.sh @@ -46,7 +46,7 @@
> > if [ "${KV}" != "${PV}" ]; then fi
> >   
> >   rm -f .version
> > -KBUILD_DEBARCH=$target_arch make -j $(($(nproc) * 2)) deb-pkg
> > +KBUILD_DEBARCH=$target_arch make -j $(($(nproc) * 2)) bindeb-pkg
> >   
> >   rm -rf ${REPACK_DIR}
> >   mkdir -p ${REPACK_DIR}
> >   
> 


      reply	other threads:[~2019-01-17 10:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16 15:20 Henning Schild
2019-01-16 19:14 ` Jan Kiszka
2019-01-17 10:15   ` Henning Schild [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190117111523.7ef0db65@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@siemens.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox