public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: Henning Schild <henning.schild@siemens.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: isar-users <isar-users@googlegroups.com>
Subject: Re: [PATCH] buildchroot: Perform upgrade after build dependency installation
Date: Tue, 22 Jan 2019 18:08:30 +0100	[thread overview]
Message-ID: <20190122180830.3aa8bef1@md1za8fc.ad001.siemens.net> (raw)
In-Reply-To: <b24f09f7-3b94-a4f3-90b8-97ca9821b857@web.de>

Am Tue, 22 Jan 2019 17:22:14 +0100
schrieb Jan Kiszka <jan.kiszka@web.de>:

> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> When we partially rebuild after updating the version of a build
> dependency of another package, we do not properly upgrade that
> dependency in buildchroot. The reason is that "apt-get install"
> performs upgrades only for the explicitly listed packages. But we
> install build dependencies indirectly, we a meta package's dependency.
> 
> Resolve that be running an explicit "apt-get upgrade" after the
> build dependency installation. This will ensure pulling the latest
> versions for isar-apt.

I am not sure i fully understand the problem given your description,
but i get the idea.

The mk-build-deps calls an apt-get that will not do anything even if
builddep-0.1 has to be updated to builddep-0.2? Maybe you can address
the problem with the "-t" argument of mk-build-dep?

Henning

> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
>  meta/recipes-devtools/buildchroot/files/deps.sh | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-devtools/buildchroot/files/deps.sh
> b/meta/recipes-devtools/buildchroot/files/deps.sh index
> 4bd604f..2501f05 100644 ---
> a/meta/recipes-devtools/buildchroot/files/deps.sh +++
> b/meta/recipes-devtools/buildchroot/files/deps.sh @@ -25,3 +25,6 @@
> apt-get update \
> 
>  # Install all build deps
>  mk-build-deps $set_arch -t "${install_cmd}" -i -r debian/control
> +
> +# Upgrade any already installed packages in case we are partially
> rebuilding +apt-get upgrade -y
> --
> 2.16.4
> 


  reply	other threads:[~2019-01-22 17:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-22 16:22 Jan Kiszka
2019-01-22 17:08 ` Henning Schild [this message]
2019-01-22 18:19   ` Jan Kiszka
2019-01-23 15:29     ` Henning Schild
2019-01-30 11:49 ` Maxim Yu. Osipov
2019-01-30 13:17   ` Jan Kiszka
2019-02-05 17:20 ` Maxim Yu. Osipov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190122180830.3aa8bef1@md1za8fc.ad001.siemens.net \
    --to=henning.schild@siemens.com \
    --cc=isar-users@googlegroups.com \
    --cc=jan.kiszka@web.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox