From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6647450695491387392 X-Received: by 2002:adf:fdcd:: with SMTP id i13mr293543wrs.32.1548264185709; Wed, 23 Jan 2019 09:23:05 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a7b:ce03:: with SMTP id m3ls11220wmc.10.canary-gmail; Wed, 23 Jan 2019 09:23:05 -0800 (PST) X-Google-Smtp-Source: ALg8bN42fkPVTpaoMZnx5PfLNrf6oT1JrGgOixI4Ys0Hyg9yWqN+FWHErdJkV5wWXJMQF1j9r02v X-Received: by 2002:a1c:6584:: with SMTP id z126mr336459wmb.18.1548264185325; Wed, 23 Jan 2019 09:23:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548264185; cv=none; d=google.com; s=arc-20160816; b=fCd9uAP4wtrUenVeouZdwaFjl4ehWo+WSmvtY5mF3RPNacHWtYfcm77IBbEXXCTeZr mPjQk//yMOm0adwquJzTnlbPsHZR8IveRnntwwqHC6RLurX/7W46PW8Cw4X1Pg8BSBxy 37TlI8QJ4yac8/S/lnopcos8O8SkP8/YeXKHLuJVodBXD0JjCuVUiKKy5beNUG7fibMg c945umrG94RGEl0GYdepK5rHaMUF91/vj7bB76I+IkzwA8k05xVrNxpYNpdV8sSkBL1P dcf/xgX7MPrFm8/jkDCcyw3ZsskjI5ba8xySWDLXU5E2e8ZccO2RrJCFZfJYMDq7yB15 vCUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:to:from:date; bh=9vR10fMBxYsVpkZxcwljf/NuAtQCnXaaUltUKeCmzBM=; b=QbN7qyVusWahgAg/eWfeOMtwQI+pLyiqudZTE13vsQYnag+5DbEHSBeljrpFKcu0uz ninMFtXPaeDBjD2TtnSC4LcnYpFRUGRKSyf+3lxKnVmT/g/xXgL+ynWPshuDhb8cZMqS DZ6AaXHYu/CWC87Bijbaw6SzpdnqxkxO8H4ZpDysjEOiAtzMK0nvy5jEHsDyiZmldUfe 3Pk7H+YzyVtC4W5pr2JWqOJ8X6xwZgGuVKd3j7jIBTzzBgeld6s2//RxgNNRODUcOzFi qsiD6XTZ9tO1qFSGNGV5onhR5/RupXvAZHVx3b45DPNmxEV1eMtcVechEsHq4rs/O80K wnNg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id k39si3360709wre.2.2019.01.23.09.23.05 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Jan 2019 09:23:05 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x0NHN49Q028893 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 23 Jan 2019 18:23:04 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.0.45]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x0NHN4Lu017496 for ; Wed, 23 Jan 2019 18:23:04 +0100 Date: Wed, 23 Jan 2019 18:23:03 +0100 From: Henning Schild To: isar-users Subject: Re: [PATCH] linux-custom: skip linux-libc-dev deployment on downgrade Message-ID: <20190123182303.4795f660@md1za8fc.ad001.siemens.net> In-Reply-To: <20190117130342.15743-1-henning.schild@siemens.com> References: <20190117130342.15743-1-henning.schild@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: ZTZKKQbGbW/J Ping Am Thu, 17 Jan 2019 14:03:42 +0100 schrieb Henning Schild : > From: Henning Schild > > A custom kernel usually deploys linux-libc-dev in the kernels version. > But some packages in the distribution depend on >= expected upstream > version of that package. If we deploy a linux-libc-dev in a lower > version, installing packages like build-essential will not be possible > anymore. > That is especially problematic since incremental builds will pull that > into our buildchroot and break package installation in there. > > If detecting a downgrade, do not deploy the package and issue a > warning. > > Signed-off-by: Henning Schild > --- > meta/recipes-kernel/linux/files/build-kernel.sh | 7 +++++++ > meta/recipes-kernel/linux/linux-custom.inc | 3 +++ > 2 files changed, 10 insertions(+) > > diff --git a/meta/recipes-kernel/linux/files/build-kernel.sh > b/meta/recipes-kernel/linux/files/build-kernel.sh index > dbd6162..e4a5d30 100644 --- > a/meta/recipes-kernel/linux/files/build-kernel.sh +++ > b/meta/recipes-kernel/linux/files/build-kernel.sh @@ -122,3 +122,10 > @@ rm -f linux-image-${PV}_${PV}-1_*.deb fakeroot dpkg-deb -b > ${REPACK_LINUX_HEADERS_DIR} \ > linux-headers-${KERNEL_NAME}_${PV}-1_${KERNEL_NAME}.deb rm -f > linux-headers-${PV}_${PV}-1_*.deb + > +# linux-libc-dev causes dependency problems if we downgrade > +# remove it after the build so the downgraded version does not get > deployed +LINUX_LIBC_DEV_V=`dpkg-query --show --showformat > '${Version}' linux-libc-dev` +if dpkg --compare-versions > $LINUX_LIBC_DEV_V gt $PV; then > + rm -f linux-libc-dev_${PV}*.deb > +fi > diff --git a/meta/recipes-kernel/linux/linux-custom.inc > b/meta/recipes-kernel/linux/linux-custom.inc index f33bb9d..ac37412 > 100644 --- a/meta/recipes-kernel/linux/linux-custom.inc > +++ b/meta/recipes-kernel/linux/linux-custom.inc > @@ -62,4 +62,7 @@ dpkg_runbuild() { > export > KERNEL_HEADERS_DEBIAN_DEPENDS="${KERNEL_HEADERS_DEBIAN_DEPENDS}" > sudo -E chroot --userspec=$( id -u ):$( id -g ) > ${BUILDCHROOT_DIR} ${PP}/build-kernel.sh ${PP}/${PPS} ${DISTRO_ARCH} > + if [ ! -f ${WORKDIR}/linux-libc-dev_${PV}*.deb ]; then > + bbwarn "Kernel downgrade detected, not deploying > linux-libc-dev" > + fi > }