From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6647450695491387392 X-Received: by 2002:a50:8eca:: with SMTP id x10mr656110edx.8.1548264640782; Wed, 23 Jan 2019 09:30:40 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a17:906:4acd:: with SMTP id u13-v6ls617734ejt.6.gmail; Wed, 23 Jan 2019 09:30:40 -0800 (PST) X-Google-Smtp-Source: ALg8bN6zsaZEVhPOYQkuZAo56+6WJerX0ST0E10mlo4xjZTPU6a0hGcet1kzb1dbWB0cMCuoQRrS X-Received: by 2002:a17:906:698c:: with SMTP id i12-v6mr580709ejr.10.1548264640379; Wed, 23 Jan 2019 09:30:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548264640; cv=none; d=google.com; s=arc-20160816; b=JkG5VtjCcwoooBaC+6kPnW0/LbPxdm18RkUI0483X3voOE9NVrIZAJIfltEa6LT0j1 am4anKOsYBR1CQ4OKR9beFPECIONSfVHO+mFlGyAUgmbLDRTgNb5vIIjVd8Thz2TCt8s HHiTXvIRIXHwpjosX6kCtBBeSZCENh9CqRTnhF4OmpjsxB7tDBHd3pQoNtuTXGodp0kg Tpg8yInj0Bv/IPYTvh+QAUPNaLUOXW3dSdG6I5tDOsAXTdkQ2meYh3A3+Oia0dQA5OLs ibs4jbyXF0wWskRX0pDFP3Iy9A+1xoa7vACNVmdJ6CXIvDtm606Ohdbjwhyh+VgI3Dy2 +2hA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=E5fyDTT37WCkynnrj0xUB2LmtaA4aUUiMqU8zhfQmbg=; b=eNekZg5seZHX/2cAZ+STfq7l6i7aTHOaBoOxq3K7jZnycMijk398iZgq/cX9GObEUE hs2cmeCMhngD105xAP5x8kEW7fIBwW/a2U4I8Xfu+37tAOkW6QZ3u5LpF1SMwB/9wkZh 6yvy3Ime12OR6QJo+ZNH0heqEN0r7BxihzplzT3IeHpQw3K+7rQcGncEwkeCH5C2YPph 2jl8wbdXUTyAkWHb2/hPA/lrbAvVQ+66kK3CluEwiVIFy+gMAUps1AIAR7YVT6tuojLC ccJxmI1mr6VerYI7dUFjLgP1Jo9VLN1SZVBgrkDv0S98WS1219+Guaa70846cmjS2QTI jB4w== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id h28si1401273edh.4.2019.01.23.09.30.40 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Jan 2019 09:30:40 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x0NHUdwQ010316 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 23 Jan 2019 18:30:39 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.0.45]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x0NHUdTe031029; Wed, 23 Jan 2019 18:30:39 +0100 Date: Wed, 23 Jan 2019 18:30:39 +0100 From: Henning Schild To: Jan Kiszka Cc: isar-users Subject: Re: [PATCH] linux-custom: skip linux-libc-dev deployment on downgrade Message-ID: <20190123183039.6b102065@md1za8fc.ad001.siemens.net> In-Reply-To: <14dc306a-4db0-a8d4-6839-a2369369f372@siemens.com> References: <20190117130342.15743-1-henning.schild@siemens.com> <20190123182303.4795f660@md1za8fc.ad001.siemens.net> <14dc306a-4db0-a8d4-6839-a2369369f372@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: rNEKKQvo9AjR Am Wed, 23 Jan 2019 18:26:08 +0100 schrieb Jan Kiszka : > On 23.01.19 18:23, [ext] Henning Schild wrote: > > Ping > > > > Looks good to me - what scenarios did you test? I know the breakages of buildchroot from layers, and the not deploying the kernel downgrade helped fix the issues. In this repo i honestly only tested the logic and whether the warning will pop up. Tested a qemuamd64 with the cip kernel inside Isar. Henning > Jan > > > Am Thu, 17 Jan 2019 14:03:42 +0100 > > schrieb Henning Schild : > > > >> From: Henning Schild > >> > >> A custom kernel usually deploys linux-libc-dev in the kernels > >> version. But some packages in the distribution depend on >= > >> expected upstream version of that package. If we deploy a > >> linux-libc-dev in a lower version, installing packages like > >> build-essential will not be possible anymore. > >> That is especially problematic since incremental builds will pull > >> that into our buildchroot and break package installation in there. > >> > >> If detecting a downgrade, do not deploy the package and issue a > >> warning. > >> > >> Signed-off-by: Henning Schild > >> --- > >> meta/recipes-kernel/linux/files/build-kernel.sh | 7 +++++++ > >> meta/recipes-kernel/linux/linux-custom.inc | 3 +++ > >> 2 files changed, 10 insertions(+) > >> > >> diff --git a/meta/recipes-kernel/linux/files/build-kernel.sh > >> b/meta/recipes-kernel/linux/files/build-kernel.sh index > >> dbd6162..e4a5d30 100644 --- > >> a/meta/recipes-kernel/linux/files/build-kernel.sh +++ > >> b/meta/recipes-kernel/linux/files/build-kernel.sh @@ -122,3 +122,10 > >> @@ rm -f linux-image-${PV}_${PV}-1_*.deb fakeroot dpkg-deb -b > >> ${REPACK_LINUX_HEADERS_DIR} \ > >> linux-headers-${KERNEL_NAME}_${PV}-1_${KERNEL_NAME}.deb rm -f > >> linux-headers-${PV}_${PV}-1_*.deb + > >> +# linux-libc-dev causes dependency problems if we downgrade > >> +# remove it after the build so the downgraded version does not get > >> deployed +LINUX_LIBC_DEV_V=`dpkg-query --show --showformat > >> '${Version}' linux-libc-dev` +if dpkg --compare-versions > >> $LINUX_LIBC_DEV_V gt $PV; then > >> + rm -f linux-libc-dev_${PV}*.deb > >> +fi > >> diff --git a/meta/recipes-kernel/linux/linux-custom.inc > >> b/meta/recipes-kernel/linux/linux-custom.inc index f33bb9d..ac37412 > >> 100644 --- a/meta/recipes-kernel/linux/linux-custom.inc > >> +++ b/meta/recipes-kernel/linux/linux-custom.inc > >> @@ -62,4 +62,7 @@ dpkg_runbuild() { > >> export > >> KERNEL_HEADERS_DEBIAN_DEPENDS="${KERNEL_HEADERS_DEBIAN_DEPENDS}" > >> sudo -E chroot --userspec=$( id -u ):$( id -g ) > >> ${BUILDCHROOT_DIR} ${PP}/build-kernel.sh ${PP}/${PPS} > >> ${DISTRO_ARCH} > >> + if [ ! -f ${WORKDIR}/linux-libc-dev_${PV}*.deb ]; then > >> + bbwarn "Kernel downgrade detected, not deploying > >> linux-libc-dev" > >> + fi > >> } > > >