From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6647450695491387392 X-Received: by 2002:a19:f60d:: with SMTP id x13mr281224lfe.12.1548266605321; Wed, 23 Jan 2019 10:03:25 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:9d8e:: with SMTP id c14-v6ls456293ljj.10.gmail; Wed, 23 Jan 2019 10:03:24 -0800 (PST) X-Google-Smtp-Source: ALg8bN5CRXbUwVzkf59ySC57srecpQKqXmeOtkBsrQfZbdE3q5/SpbHKqabLBTU91tLGYmFQ+jAe X-Received: by 2002:a2e:505a:: with SMTP id v26-v6mr297967ljd.5.1548266604840; Wed, 23 Jan 2019 10:03:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548266604; cv=none; d=google.com; s=arc-20160816; b=Lsr+YWqCSYZkp0zKYWNqu+qX9+QvbfQsn59EjIZUElyaqDflwL7Jmq9XZlQnjtFmT1 WWU6lRb70H1gKykCaeANzLzxHDBoPNlN5MxB9o1y7wtkKvVZMkSIjFJakcUOMW1SBWeT 74ZPa4Zg397jwn4ZBnm17g0ZgTo0RAcCKbeOfOHPfED/Pw/t5YICUHZdiyo0/dE27GPl mTUF6f6iJxUx6NXGYznQjljIuzXHDid10PS826VHZxwlu8NCOTHcq0Rmt9lCYwzMKtjE neg2oJsy2VouggyZtuTZ+cTAoTwXWswFVqyVfVQmQQEOzKfeltBRQDvzPwJulU4G6Hv0 V7Pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=wHiFWDa+igcJMCl2Ev8Njcky4gEDqA7bCbvxIwdlPwA=; b=VW3zgODC9V0zU8fehUsFkDjGuAQLELHPAdjVRAV/g9IWehkN4i8PxDGYF74Kjftdoj Gu0rPjxnPeXp/97H4hguZclNMV1MuN+M/nCeXldnFNdJgkf1oxaqfEyir27ejahYoE/X ngJvAjSkGsg7zHjdwbnx8Ah8GLIxu1TzmeK8X8Ge6wtuGu6tVRy9jLcQFOti1ylEdmuN jomFSArsZb8VmKS0N61NCUCGG5SGdAJuTHI2YClg4sfPlWb/CWhDGzbcLYTr6Bkohqfy KrxWZZtCxv/bqqVGEBgDpOHIP+S1WYCFvXWLsFiH8ZXewutDoc8fCm7u3ZYOu+x4H3TZ CViA== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from lizzard.sbs.de (lizzard.sbs.de. [194.138.37.39]) by gmr-mx.google.com with ESMTPS id w10si145286lfc.5.2019.01.23.10.03.24 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 23 Jan 2019 10:03:24 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) client-ip=194.138.37.39; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.39 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by lizzard.sbs.de (8.15.2/8.15.2) with ESMTPS id x0NI3NmN032113 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 23 Jan 2019 19:03:23 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.0.45]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x0NI3NV3026090; Wed, 23 Jan 2019 19:03:23 +0100 Date: Wed, 23 Jan 2019 19:03:23 +0100 From: Henning Schild To: Jan Kiszka Cc: isar-users Subject: Re: [PATCH] linux-custom: skip linux-libc-dev deployment on downgrade Message-ID: <20190123190323.5e346a25@md1za8fc.ad001.siemens.net> In-Reply-To: <471e7120-1541-5f07-1374-be86fc62d872@siemens.com> References: <20190117130342.15743-1-henning.schild@siemens.com> <20190123182303.4795f660@md1za8fc.ad001.siemens.net> <14dc306a-4db0-a8d4-6839-a2369369f372@siemens.com> <20190123183039.6b102065@md1za8fc.ad001.siemens.net> <471e7120-1541-5f07-1374-be86fc62d872@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: as7DILz66mhZ Am Wed, 23 Jan 2019 18:43:08 +0100 schrieb Jan Kiszka : > On 23.01.19 18:30, Henning Schild wrote: > > Am Wed, 23 Jan 2019 18:26:08 +0100 > > schrieb Jan Kiszka : > > > >> On 23.01.19 18:23, [ext] Henning Schild wrote: > >>> Ping > >>> > >> > >> Looks good to me - what scenarios did you test? > > > > I know the breakages of buildchroot from layers, and the not > > deploying the kernel downgrade helped fix the issues. > > In this repo i honestly only tested the logic and whether the > > warning will pop up. Tested a qemuamd64 with the cip kernel inside > > Isar. > > OK, but we also have a "should upgrade" kernel recipe in Isar: > linux-mainline_4.19.0. I just tested the "gt" operator of the comparator against the 4.9 that we get in debian 9. It worked there so there is no reason to think it will not work for 4.19. > > One question on second thought: > > > + > > +# linux-libc-dev causes dependency problems if we downgrade > > +# remove it after the build so the downgraded version does not get > > deployed +LINUX_LIBC_DEV_V=`dpkg-query --show --showformat > > '${Version}' linux-libc-dev` +if dpkg --compare-versions > > $LINUX_LIBC_DEV_V gt $PV; then > > + rm -f linux-libc-dev_${PV}*.deb > > +fi > > Isn't this assuming we have linux-libc-dev from Debian installed? Is > that always valid? Wouldn't it be better to query the Debian repo > specifically? Assuming you are installing only one kernel in your image, the command will operate on linux-libc-dev from all repos but ours ... debian. I guess if we are looking at images with multiple kernels, or incremental builds that downgrade against their own upgrade ... things could get tricky. Or actually not, in this case we want to get notified about the downgrade in our repo. Say your debian official kernel is 4.9, your layer adds 4.14.42 and you go back to 4.14.40 in an incremental build step. The upgrade from 4.9 to 4.14.42 will be done as usual, and you should now receive the warning about a downgrade that will not be performed. ... Not tested ... So i am guessing the logic is correct. For the multiple kernel case (does that even exist?) one might have to ignore the warning or enforce an install order with artificial dependencies. > Also: $(...) - `...` is old-style. Ok will fix. Henning > Jan >