From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6651523578180141056 X-Received: by 2002:a19:7510:: with SMTP id y16mr254313lfe.9.1548753287020; Tue, 29 Jan 2019 01:14:47 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:42c5:: with SMTP id h66-v6ls2539558ljf.7.gmail; Tue, 29 Jan 2019 01:14:46 -0800 (PST) X-Google-Smtp-Source: AHgI3IZCotNN06LIL6nFC9Duz1Gh8uJvqt2DmThPqcQeJfkDW4s7D6GzQueMNovenY80ZXV3GQWa X-Received: by 2002:a2e:9757:: with SMTP id f23-v6mr130132ljj.23.1548753286391; Tue, 29 Jan 2019 01:14:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548753286; cv=none; d=google.com; s=arc-20160816; b=vFsxmj6qgx+GOQlzg1d2V4VaU1l2NFa2dLaWa6SdfyXTsHjkKZ32zRXeGhaCe0AD/g 8IfNp9EM30TtpUi3UdiF9Ik88SjLaHaLItJtJat8jOTcZgZo86w9K/TsWmlxhY8i1klR UQO2hBAaVZ6GcmvLHxgk3F+L2/wgEj4T16EjQ1RJ6R77gwdonUUopPy+Mw5v5W406uYb Ln0ifCPEFQM27lZP678cVNsn7zIE7JBHBrFQquqAHxcGgrwLfWgR8QTIyuAbhMmaM6Gw GcIUnShVY/91b9wea+hH/Kdmeuk/Lx9d55S5MdBBZJ8r0LgqtsTkloMRPGCoKurzIMz4 auWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=6VmXmxMCRYC1D3//CYUIazHTWmTE/XUJrYaTsIQsx+k=; b=zCogWkIefxq9F2kjxCQkNIonoXNdpKr0HX3HiNXa+eebS9SuFphi0qOeOm11htA4hy sjSfC27eW0/73rM+bmQHpPzzWL/17EvzA2Mx1OuM9bZFUpPlcuCMFLy+pAjQhXZrTG4c yt+YFTw+OACkEfqems5r0a6bzcM3TXyQ4uviHq26lIkGuoOrTxlIA754mmMUML47g4qV mG2JGDaFozBVp6aEVtc7f9zb8MKyIyyWyFmjd7Zc2XROueGKFIiDlgUuhsQkT5u0V5Rz FfaRljGUKw4IdGYakSfekRDdEeOLm62CGiC91Ld0R4GE+FJRhyzpAWR0Up6gy5fu5WmR RRUQ== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id y27si552544lfb.0.2019.01.29.01.14.46 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 01:14:46 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x0T9Ej89014850 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 29 Jan 2019 10:14:45 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.0.30]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x0T9EhOG014857; Tue, 29 Jan 2019 10:14:43 +0100 Date: Tue, 29 Jan 2019 10:14:43 +0100 From: Henning Schild To: Claudius Heine Cc: , Claudius Heine Subject: Re: [PATCH 2/2] integrate ubifs image type Message-ID: <20190129101443.0bc7c819@md1za8fc.ad001.siemens.net> In-Reply-To: <2c60f6d1-5531-c05b-b0bd-677aad52e10a@siemens.com> References: <20190128122821.10002-1-claudius.heine.ext@siemens.com> <20190128122821.10002-3-claudius.heine.ext@siemens.com> <20190128140344.7bc5f072@md1za8fc.ad001.siemens.net> <20190128182237.04ab656b@md1za8fc.ad001.siemens.net> <5fab2f59-9f15-713f-f2c8-15886800a3dc@siemens.com> <2c60f6d1-5531-c05b-b0bd-677aad52e10a@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-TUID: lGZd7spJk8gp On Tue, 29 Jan 2019 09:24:38 +0100 Claudius Heine wrote: > On 29/01/2019 09.16, [ext] Claudius Heine wrote: > >>>>> +do_ubifs_image[stamp-extra-info] =3D "${DISTRO}-${MACHINE}" > >>>>> + > >>>>> +# Generate ubifs filesystem image > >>>>> +do_ubifs_image() { > >>>>> +=C2=A0=C2=A0=C2=A0 rm -f ${DEPLOY_DIR_IMAGE}/${UBIFS_IMAGE_FILE} > >>>>> + > >>>>> +=C2=A0=C2=A0=C2=A0 buildchroot_do_mounts > >>>>> + > >>>>> +=C2=A0=C2=A0=C2=A0 sudo flock ${MOUNT_LOCKFILE} -c ' \ > >>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mkdir -p ${BUILDROOT_DE= PLOY} ${BUILDROOT_ROOTFS} > >>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mount --bind ${DEPLOY_D= IR_IMAGE} ${BUILDROOT_DEPLOY} > >>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 mount --bind ${IMAGE_RO= OTFS} ${BUILDROOT_ROOTFS} > >>>>> +=C2=A0=C2=A0=C2=A0 ' =20 > >>>> > >>>> I think this mounting should also be required by a proper ext4 > >>>> class. On the other hand the wic one moves the image into the > >>>> final deploy folder. > >>>> Not sure what is best but maybe a good idea to go for "always > >>>> move" or "always mount". =20 > >>> > >>> Hmm.. In OE this task would not to touch the deploy directory and > >>> *copy* all artifacts in a dedicated task AFAIK. But OE has a > >>> completely different image creation pipeline and infrastructure > >>> than isar, so who knows how things should be done here. =20 > >> > >> We currently generate and deploy in one task. The fun thing is > >> that we need multiple commands and can probably end up in weird > >> states if we get interrupted or fail. > >> > >> Changing that general pattern is a discussion of its own, since it > >> would change the API. > >> > >> Staying in the current API i think the mount and generate directly > >> into deploy ... no more chmod/chown mv ... whatever. Would be the > >> cleanest way. We already have a reliable umount mechanism to clean > >> up if things go wrong. > >> > >> If you agree: Please include that deploydir/rootfs mount into the > >> common mounts and update your imager. I will do the same for wic > >> and maybe ext4. =20 > >=20 > > Ok. Will do that. =20 >=20 > Hmmm... You mean mounts that are done by `buildchroot_do_mounts`?=20 > Extending that function would cause deploydir and rootfs to be > mounted for every recipe. `rootfs` doesn't make sense for normal > recipes and mounting `deploydir` into every recipes workspace sound > bad as well... You are right, those should better not be mounted for every recipe. > Maybe we would need a image specific mount function and then switch=20 > every image type to this. But I guess that would be a feature on its > own. That might actually call for a changed task-chain for image-recipes. Maybe do_deploy_deb should actually be do_deploy, with a deb and a deploydir implementation. Forget me not liking the extra mount and let us remember this one as an item on the non-existing TODO list. Henning > Claudius >=20