From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6647496723618856960 X-Received: by 2002:a1c:ac87:: with SMTP id v129mr785347wme.20.1548859311863; Wed, 30 Jan 2019 06:41:51 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a1c:4987:: with SMTP id w129ls367217wma.13.gmail; Wed, 30 Jan 2019 06:41:51 -0800 (PST) X-Google-Smtp-Source: AHgI3IYEVPx0ho2kRjjyTa/s0kgoiAjYIlyhuSZU98C8nIV9E3i/g18uGW7Fe8US0lloKcwFyxrD X-Received: by 2002:a1c:f718:: with SMTP id v24mr731483wmh.4.1548859311472; Wed, 30 Jan 2019 06:41:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548859311; cv=none; d=google.com; s=arc-20160816; b=T7SDjP887+WWJteEpeznZrDc/p7Ge0eXznvuW9+zTMpbHu/7OhpEyFAFqZx/MvUWEK Bw+1lnGCmcaV3H+9aTlk26i14eFep/6DurJu1DFJz7OS7kFd5B7ju57RiRI0xB9jXCCr tNvM9cdTfHJLRxNswTizjNTxCvOVYZMPqZMrnPVG4Tdl1sqUZAa0lj3xepM2KYE7GsJ+ q8gO0Vzu2ocqOBCfML4n7FtSNeRhUhXj7gZ+o44+mgW44v3KBKxUUO3xer/lChPWLcUu J4PpGYcWwbzJqC0C7lCgXLgvw3T3UWhzzcAvkgp5NBDLk5Kvnbhf/CL1DuqgOz5jPOCe R/UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=zOnlauYJVRr8yFceownElCfQGOkW/pkor1ctp6SgUGo=; b=UaIsxxZEoOITT26tfJ0kTE3Af7Q+XckUGJEKiAoS30Ay2jAq04pt7jpGRB3MtNV+Jz W4trELfUNAheQuh9mKESUU6hVOZ+rsk5ffOkiqLx6Z8nxvl8MAQ90G2uA8YsVyldtGnt 11Dvsd1PexrkOFo059cm341P3vL7aIBHy+A8SksWJ+UcwycJmwHU2pU6fMa8vTG8j0I7 O9pFMsC6F14C8+6xRKkdLMwv/axNBacwEPQRdXZUH+xlmoFufJH8XXZIxlg7g5XBfC30 CMhWIO0Up3B7uaUWm/4yfJDOdI+o8WMXkBrdzz2XgooGLfo7yuI2a4XWaz1y3pTCtEJP qEvg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id 69si74477wrb.1.2019.01.30.06.41.51 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Jan 2019 06:41:51 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x0UEfo2C019600 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 30 Jan 2019 15:41:51 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.68.203]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x0UEfoOn003995; Wed, 30 Jan 2019 15:41:50 +0100 Date: Wed, 30 Jan 2019 15:41:50 +0100 From: Henning Schild To: "[ext] Jan Kiszka" Cc: "Maxim Yu. Osipov" , Subject: Re: [PATCH v2 2/6] dpkg-base: introduce an "apt-get source" fetch/unpack step Message-ID: <20190130154150.478a43ce@md1za8fc.ad001.siemens.net> In-Reply-To: References: <20190130065452.11589-1-mosipov@ilbers.de> <20190130065452.11589-3-mosipov@ilbers.de> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: Tieug1TZooaU On Wed, 30 Jan 2019 08:38:34 +0100 "[ext] Jan Kiszka" wrote: > On 30.01.19 07:54, Maxim Yu. Osipov wrote: > > From: Henning Schild > > > > This creates a new task to fetch/unpack debian sources from debian > > source mirrors. This is done using "apt-get source" and the new > > variable APT_SRC to control the arguments. > > > > An example where a original debian package gets rebuild will follow > > in a later commit. > > > > Signed-off-by: Cedric Hombourger > > This SOB is still wrong. > > > Signed-off-by: Henning Schild > > --- > > meta/classes/dpkg-base.bbclass | 19 +++++++++++++++++++ > > 1 file changed, 19 insertions(+) > > > > diff --git a/meta/classes/dpkg-base.bbclass > > b/meta/classes/dpkg-base.bbclass index f1b127c..2f324f9 100644 > > --- a/meta/classes/dpkg-base.bbclass > > +++ b/meta/classes/dpkg-base.bbclass > > @@ -20,6 +20,25 @@ do_adjust_git[stamp-extra-info] = > > "${DISTRO}-${DISTRO_ARCH}" inherit patch > > addtask patch after do_adjust_git before do_build > > > > +SRC_APT ?= "" > > + > > +do_apt_fetch[depends] = "buildchroot-target:do_build" > > + > > +do_apt_fetch() { > > + if [ -z "${@d.getVar("SRC_APT", True).strip()}" ]; then > > + exit > > + fi > > + dpkg_do_mounts > > + E="${@ bb.utils.export_proxies(d)}" > > + sudo -E chroot --userspec=$( id -u ):$( id -g ) > > ${BUILDCHROOT_DIR} \ > > + sh -c 'cd ${PP} && apt-get -y source ${SRC_APT}' > > + dpkg_undo_mounts > > +} > > + > > +addtask apt_fetch after do_unpack before do_patch > > +do_apt_fetch[lockfiles] += "${REPO_ISAR_DIR}/isar.lock" > > +do_apt_fetch[stamp-extra-info] = "${DISTRO}-${DISTRO_ARCH}" > > + > > def get_package_srcdir(d): > > s = d.getVar("S", True) > > workdir = d.getVar("WORKDIR", True) > > > > ...and I'm still wondering if we cannot extend bitbake (without > patching it) instead. I have one more trick in mind to at least get the interface right and keep the implementation that relies on another task instead of do_fetch. In fact the debian fetcher is an unpacker as well and has funny buildchroot dependencies ... not a "simple" bb fetcher. Henning > Jan >