From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6654882193514430464 X-Received: by 2002:a2e:8842:: with SMTP id z2-v6mr673990ljj.29.1549460504395; Wed, 06 Feb 2019 05:41:44 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:d9db:: with SMTP id s88ls2338496lfi.14.gmail; Wed, 06 Feb 2019 05:41:43 -0800 (PST) X-Google-Smtp-Source: AHgI3IaPY6vq0l6bTW5uy7mlXTUp8t+S0HF7dOgcfgPgcYWateaG4VXXEbGrQ4EjEdxyu8VngmtL X-Received: by 2002:a19:5519:: with SMTP id n25mr699531lfe.1.1549460503705; Wed, 06 Feb 2019 05:41:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549460503; cv=none; d=google.com; s=arc-20160816; b=x3q+sd/QldG34Mdd9byZW281HW3ZrLG80Z9xFMUjZZEhjjHq6qvqwnMi79yWCTzhlU R+HZdWLJGgZ9n7chKC4WwMwAQk1zcsxsQ5oIYuGoyEAZ1xW/YR4qDsEYkrhE6776pCQ6 ZRjXm9EoEUSaopo6AjFzAcedpR+HPzbIZnAcBYlE04WUqgje1+0ywfBRK13cIzTEUuHO 93U46JRgR93KsJpKIkHSQTIDJNErsCohr9pCMF0BlqhEk78b0UjxP5nASEOuTzlQH096 shig68/1tr6oPxmoSCSksVJ/PmYR4RvrZ/oLcqxcQYcNynb5MZ9q1QmZWBP+TvD4+2Dm vp/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from; bh=vgA2Qp7UbdSrPdiIqXQGojOYdq65WKg2UdZqHTfVl1M=; b=oyWWcc6A5WMvVHnFf0c6y+AFOvQaGX96Tm3y1A+I9YJEZGWRvkIW0c0S02icurZOZs ECosF7j7bq2oB/lOJec7tef5JYxCjhxgG71VlqKN1mEF10pAuWhrWfmrpawm8hEHk//j itDnQ7lOERqgRW4rBge/7B2SFDP68dI7PWFd4UiX/h7le+d6ZmCJYOxwlKC3/fxH8MfN NkZly23KUeu0PurQ2NNbCdEUI70hSJXQu3DT4g49GUZdqA21dswhLe2V4ViZiSZ2/olK E/dhezcgXtP8sBvpq6grHC+GgVNLPn2U96BTYU3N2wkP2hqcYlTm57/86nx8zVshJGEW zfRg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from thoth.sbs.de (thoth.sbs.de. [192.35.17.2]) by gmr-mx.google.com with ESMTPS id q13si353335lfd.2.2019.02.06.05.41.43 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Feb 2019 05:41:43 -0800 (PST) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) client-ip=192.35.17.2; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.2 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id x16DfgG7001638 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 6 Feb 2019 14:41:42 +0100 Received: from ring.ppmd.siemens.net (linux-ses-ext02.ppmd.siemens.net [139.25.69.181]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x16DfgHW027988; Wed, 6 Feb 2019 14:41:42 +0100 From: claudius.heine.ext@siemens.com To: isar-users@googlegroups.com Cc: Claudius Heine Subject: [PATCH 1/1] meta: add isar-cfg-rootpw recipe for setting root password Date: Wed, 6 Feb 2019 14:41:39 +0100 Message-Id: <20190206134139.1597-2-claudius.heine.ext@siemens.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190206134139.1597-1-claudius.heine.ext@siemens.com> References: <20190206134139.1597-1-claudius.heine.ext@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: YLYFNAPE04KB From: Claudius Heine The isar-cfg-rootpw recipe is a central point to set the root password for images. It provides the `CFG_ROOT_PW`, `CFG_ROOT_PW_ENC`, `CFG_ROOT_LOCKED` and variables, that can be set from any `.conf` file or via `isar-cfg-rootpw.bbappend`. This package is installed as a transient package to avoid leaking passwords set by it via the scripts in `/var/lib/dpkg/info/`. The `CFG_ROOT_PW` and `CFG_ROOT_PW_ENC` variables contain either a root password as clear text or encrypted, or are both empty, in which case login without password is possible. The encrypted password is preferred if both variables are set. The `CFG_ROOT_LOCKED` variable that can be set to "1" in order to lock the root account, other values leave the account unlocked. Unlocking the account at a later point will restore the password set by `CFG_ROOT_PW` or `CFG_ROOT_PW_ENC`. Signed-off-by: Claudius Heine --- RECIPE-API-CHANGELOG.md | 9 ++++++++ .../recipes-app/example-raw/files/postinst | 4 ---- meta/classes/isar-image.bbclass | 2 +- .../isar-cfg-rootpw/files/postinst.tmpl | 21 +++++++++++++++++++ .../isar-cfg-rootpw/isar-cfg-rootpw.bb | 20 ++++++++++++++++++ 5 files changed, 51 insertions(+), 5 deletions(-) create mode 100644 meta/recipes-support/isar-cfg-rootpw/files/postinst.tmpl create mode 100644 meta/recipes-support/isar-cfg-rootpw/isar-cfg-rootpw.bb diff --git a/RECIPE-API-CHANGELOG.md b/RECIPE-API-CHANGELOG.md index dcfbbee..7863e8a 100644 --- a/RECIPE-API-CHANGELOG.md +++ b/RECIPE-API-CHANGELOG.md @@ -136,3 +136,12 @@ files). Otherwise, default permissions are used. It's now sufficient to provide only kbuild rules. Makefile targets like modules or modules_install as well as KDIR and DESTDIR evaluation are no longer needed. + +### Remove setting of root passwords in custom packages + +Custom packages that are not installed via the IMAGE_TRANSIENT_PACKAGES and set +a root password, leak that password via its script in /var/lib/dpkg/info. + +Instead set the CFG_ROOT_PW or CFG_ROOT_PW_ENC variables to the password and use +the transient 'isar-cfg-rootpw' package (now installed as transient package per +default). diff --git a/meta-isar/recipes-app/example-raw/files/postinst b/meta-isar/recipes-app/example-raw/files/postinst index f60be8c..f48d993 100644 --- a/meta-isar/recipes-app/example-raw/files/postinst +++ b/meta-isar/recipes-app/example-raw/files/postinst @@ -15,8 +15,4 @@ fi chown -R isar:isar /var/lib/isar -# this wins over meta-isar/recipes-core/images/files/*configscript.sh -# but we take the same password for this example -echo "root:root" | chpasswd - echo "isar" > /etc/hostname diff --git a/meta/classes/isar-image.bbclass b/meta/classes/isar-image.bbclass index e2bae58..cdd1651 100644 --- a/meta/classes/isar-image.bbclass +++ b/meta/classes/isar-image.bbclass @@ -17,7 +17,7 @@ SRC_URI += "${@ cfg_script(d) }" DEPENDS += "${IMAGE_INSTALL} ${IMAGE_TRANSIENT_PACKAGES}" -IMAGE_TRANSIENT_PACKAGES += "isar-cfg-localepurge" +IMAGE_TRANSIENT_PACKAGES += "isar-cfg-localepurge isar-cfg-rootpw" WORKDIR = "${TMPDIR}/work/${DISTRO}-${DISTRO_ARCH}/${PN}" diff --git a/meta/recipes-support/isar-cfg-rootpw/files/postinst.tmpl b/meta/recipes-support/isar-cfg-rootpw/files/postinst.tmpl new file mode 100644 index 0000000..7634f6a --- /dev/null +++ b/meta/recipes-support/isar-cfg-rootpw/files/postinst.tmpl @@ -0,0 +1,21 @@ +#!/bin/sh +set -e + +if ! grep -q 'root:\*:' /etc/shadow; then + echo "ERROR:isar-cfg-rootpw: root password was set by a different package" >&2 + exit -1 +fi + +if [ -n "${CFG_ROOT_PW_ENC}" ]; then + echo "root:${CFG_ROOT_PW_ENC}" | chpasswd -e +elif [ -n "${CFG_ROOT_PW}" ]; then + echo "root:${CFG_ROOT_PW}" | chpasswd +else + passwd -d root +fi + +if [ "${CFG_ROOT_LOCKED}" = "1" ]; then + # Lock the account after setting the password, since unlocking it at some + # point later would set it to the back to the previous one. + passwd -l root +fi diff --git a/meta/recipes-support/isar-cfg-rootpw/isar-cfg-rootpw.bb b/meta/recipes-support/isar-cfg-rootpw/isar-cfg-rootpw.bb new file mode 100644 index 0000000..52bb153 --- /dev/null +++ b/meta/recipes-support/isar-cfg-rootpw/isar-cfg-rootpw.bb @@ -0,0 +1,20 @@ +# This software is a part of ISAR. + +DESCRIPTION = "Isar configuration package for root password" +MAINTAINER = "isar-users " +DEBIAN_DEPENDS = "passwd" + +SRC_URI = "file://postinst.tmpl" + +TEMPLATE_FILES = "postinst.tmpl" +TEMPLATE_VARS = "CFG_ROOT_PW CFG_ROOT_PW_ENC CFG_ROOT_LOCKED" + +CFG_ROOT_PW ??= "" +CFG_ROOT_PW_ENC ??= "" +CFG_ROOT_LOCKED ??= "0" + +inherit dpkg-raw + +do_install() { + echo "intentionally left blank" +} -- 2.20.1