From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6656673633724792832 X-Received: by 2002:a2e:9a59:: with SMTP id k25-v6mr2100178ljj.0.1549877730401; Mon, 11 Feb 2019 01:35:30 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a2e:90ce:: with SMTP id o14-v6ls1411820ljg.11.gmail; Mon, 11 Feb 2019 01:35:29 -0800 (PST) X-Google-Smtp-Source: AHgI3IYBxhQErMviys0VmKb+EVm0tt0Oi1QS/YaZTpQEziNWg1aSrWLesc2qRmKzxpzeEWK3sNUo X-Received: by 2002:a2e:9002:: with SMTP id h2-v6mr563855ljg.15.1549877729337; Mon, 11 Feb 2019 01:35:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549877729; cv=none; d=google.com; s=arc-20160816; b=zl821+FUJToIToep4F1Sk9nWdGYFNiHB1C8WVxpD1ow3jYlS+N8dGD7ZhxniWi6CLW b8FXnC+FkfN5J2ABFH0fixyYFAaiqcLhrdw9T1gTBW+nl7JmQquxcwfdfuq9Dm9qReCK BKhrHFNILPZLKisg8g+/Si6if5PL9Mfqpco5B/5SPwPTHMKSXmQYuYsDZIWc/ZnHJAx0 ds+eQxcsXf2yOizoZETggo2uVkwAApww69tI6xtFse7h3C7T5QkEQrNoD8hj2IeRndKQ e/s6mU29Q3LDwwMQbg2a+pSzUgBPyhWYlnHIzd7DogyotEKVGBAxjhwDIEH94epGN9wr 59Zw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:to:from:date; bh=VsiExviTmd88ylf4Lhq4ANwncs5rQCzlnpa0WmGBoeE=; b=u2Xq1AOvg2NB+5Z3rNz61E6VTnDnkDwoRfgwAOJ/p0fLUvjt2JBuYCcUWJkht7TyMj YowLhqDSqwTlMO3zhM00Eaf8ZRA42EhqssfpAkD6Q429+hVq746DlKxoBWR20rXIB3Ez JJtLZavItvjvlVhezvoOsYsBYJPV7vSoRs/ty2HZ4BFO9RPslLoCpxJD4rC5fzWNksWq zbRga8sjan4HSF4WQC58Gn1XsYMHaZ+dfySvKhM5OpQ+GVBg2TJkgpT8Uhfq8OeSLY7b icEfpB28DrYmyg8Sn4bK51JV4XkPjN2EEzXRnT38PX9FyvdDNvHdYH/jPdnWvwHXGuYW 65Aw== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from gecko.sbs.de (gecko.sbs.de. [194.138.37.40]) by gmr-mx.google.com with ESMTPS id t73si457476lfe.4.2019.02.11.01.35.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 11 Feb 2019 01:35:29 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) client-ip=194.138.37.40; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 194.138.37.40 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by gecko.sbs.de (8.15.2/8.15.2) with ESMTPS id x1B9ZSFU015800 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 11 Feb 2019 10:35:28 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.0.85]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x1B9ZS51024417 for ; Mon, 11 Feb 2019 10:35:28 +0100 Date: Mon, 11 Feb 2019 10:35:26 +0100 From: Henning Schild To: Subject: Re: [PATCH] dpkg-base: apt-get "update" before "source" Message-ID: <20190211103526.3d92babf@md1za8fc.ad001.siemens.net> In-Reply-To: <20190211093324.1444-1-henning.schild@siemens.com> References: <20190211093324.1444-1-henning.schild@siemens.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: KkmJMwehmQte Here i see an often repeating pattern. That "apt-get update" is now present in many entry points to the buildchroot. I guess we should factor it out and put it into a central place. And the rule of thumb probably is ... whenever you use anything apt, apt-get update before you do ... Henning Am Mon, 11 Feb 2019 10:33:24 +0100 schrieb Henning Schild : > From: Henning Schild > > When rebuilding we can run into an inconsistent view where buildchroot > assumes it could download the sources of a modified upstream package. > After a "reprepro ... remove" we always need to "apt-get update" to > not operate on an old version of the metadata. > > Signed-off-by: Henning Schild > --- > meta/classes/dpkg-base.bbclass | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/meta/classes/dpkg-base.bbclass > b/meta/classes/dpkg-base.bbclass index 175dc80..5425df8 100644 > --- a/meta/classes/dpkg-base.bbclass > +++ b/meta/classes/dpkg-base.bbclass > @@ -31,6 +31,10 @@ do_apt_fetch() { > fi > dpkg_do_mounts > E="${@ bb.utils.export_proxies(d)}" > + sudo -E chroot ${BUILDCHROOT_DIR} /usr/bin/apt-get update \ > + -o > Dir::Etc::sourcelist="sources.list.d/isar-apt.list" \ > + -o Dir::Etc::sourceparts="-" \ > + -o APT::Get::List-Cleanup="0" > sudo -E chroot --userspec=$( id -u ):$( id -g ) > ${BUILDCHROOT_DIR} \ sh -c 'cd ${PP} && apt-get -y source ${SRC_APT}' > dpkg_undo_mounts