From: Harald Seiler <hws@denx.de>
To: isar-users@googlegroups.com
Subject: [PATCH v2 0/5] Python refactoring
Date: Tue, 12 Feb 2019 17:56:32 +0100 [thread overview]
Message-ID: <20190212165637.19970-1-hws@denx.de> (raw)
This series contains a number of improvements to python code in isar:
* All instancess of subprocess.{call,Popen,check_call}() have been changed to
never use `shell=True`. This will hopefully prevent bugs in the future.
* The use of the % formatter was replaced by other methods, as % was deprecated
because it can behave weirdly. Unfortunately, as we have to support python
back to 3.5, we can not yet make use of f-Strings, so other options had to be
used. I decided to use string concatenation for simple cases where the use
of .format() would have been too verbose.
* A recursive call in get_image_name was removed in favor of an imperative code
style. This should make the respective function easier to read.
Changes in v2:
* Remove redundant encoding parameter
* Fix formatting
* Refactor a task that I previously missed
* Add a commit for general style fixes
Harald Seiler (5):
Remove all uses of subprocess.call(shell=True)
Use modern python formatting
image: Remove recursion in get_image_name
wic: Refactor fakeroot script
Fix python style
.../example-module/example-module.bb | 8 ++-
meta/classes/base.bbclass | 70 ++++++++++++++--------
meta/classes/image.bbclass | 22 +++++--
meta/classes/isar-bootstrap-helper.bbclass | 8 +--
meta/classes/isar-events.bbclass | 14 ++---
meta/classes/patch.bbclass | 13 ++--
meta/classes/wic-img.bbclass | 21 +++++--
.../isar-bootstrap/isar-bootstrap-host.bb | 9 ++-
.../isar-bootstrap/isar-bootstrap-target.bb | 5 +-
.../recipes-core/isar-bootstrap/isar-bootstrap.inc | 12 ++--
scripts/wic_fakeroot | 9 +--
11 files changed, 120 insertions(+), 71 deletions(-)
--
2.14.1
next reply other threads:[~2019-02-12 16:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-12 16:56 Harald Seiler [this message]
2019-02-12 16:56 ` [PATCH v2 1/5] Remove all uses of subprocess.call(shell=True) Harald Seiler
2019-02-12 16:56 ` [PATCH v2 2/5] Use modern python formatting Harald Seiler
2019-02-12 16:56 ` [PATCH v2 3/5] image: Remove recursion in get_image_name Harald Seiler
2019-02-12 16:56 ` [PATCH v2 4/5] wic: Refactor fakeroot script Harald Seiler
2019-02-12 16:56 ` [PATCH v2 5/5] Fix python style Harald Seiler
2019-02-12 17:14 ` [PATCH v2 0/5] Python refactoring Henning Schild
2019-02-18 13:29 ` Maxim Yu. Osipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212165637.19970-1-hws@denx.de \
--to=hws@denx.de \
--cc=isar-users@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox