public inbox for isar-users@googlegroups.com
 help / color / mirror / Atom feed
From: claudius.heine.ext@siemens.com
To: isar-users@googlegroups.com
Cc: Claudius Heine <ch@denx.de>
Subject: [PATCH v3 0/1] Template system
Date: Wed, 13 Feb 2019 16:13:45 +0100	[thread overview]
Message-ID: <20190213151346.2498-1-claudius.heine.ext@siemens.com> (raw)

From: Claudius Heine <ch@denx.de>

Hi,

so after having access to the ilbers ci I could find some issues with
this patch.

I will try to describe the issue I think happened here:

Initially I added the 'do_transform_template' task with a 'before
do_build' that normally just triggers the template generation process if
the default task 'do_build' is run. The 'do_transform_template' task has
the default '${DISTRO}-${DISTRO_ARCH}' stamp-extra-info that we have to
add to pretty much all new tasks in isar.

That might be ok for normal recipes, but the buildchroot-* recipes add
stuff to the virtual default `do_build` and that now depend on the
`do_transform_template` task and its dependencies.

Currently that is a bit to complex for me to exactly figure out how
those errors get triggered, but since that works in the internal CI, but
not on ilbers, that messes up the bitbake task order.

So my solution is to remove the 'before do_build', now
'do_transform_template' is no longer executed per default. 'dpkg-base'
and the image classes add their own dependencies if they need that task.

Currently the build a ilbers ci still fails, because apparently
gettext-base is not installed there. I added gettext-base as a
dependency to the user_manual.md

regards,
Claudius

Changes from v2:
 - put subprocess into context manager
 - added 'gettext-base' isar dependency
 - remove 'before do_build' from addtask

Changes from v1:
 - fixed spelling mistakes of documentation

Claudius Heine (1):
  meta: added do_transform_template task as templating system and switch

 doc/technical_overview.md                     | 25 ++++++++
 doc/user_manual.md                            |  1 +
 meta/classes/base.bbclass                     |  1 +
 meta/classes/dpkg-base.bbclass                |  2 +-
 meta/classes/template.bbclass                 | 62 +++++++++++++++++++
 .../debian/{changelog => changelog.tmpl}      |  2 +-
 meta/recipes-bsp/u-boot/files/debian/control  | 19 ------
 .../u-boot/files/debian/control.tmpl          | 19 ++++++
 meta/recipes-bsp/u-boot/u-boot-custom.inc     | 12 ++--
 .../debian/{changelog => changelog.tmpl}      |  2 +-
 .../linux-module/files/debian/control         | 11 ----
 .../linux-module/files/debian/control.tmpl    | 11 ++++
 meta/recipes-kernel/linux-module/module.inc   |  7 +--
 13 files changed, 130 insertions(+), 44 deletions(-)
 create mode 100644 meta/classes/template.bbclass
 rename meta/recipes-bsp/u-boot/files/debian/{changelog => changelog.tmpl} (74%)
 delete mode 100644 meta/recipes-bsp/u-boot/files/debian/control
 create mode 100644 meta/recipes-bsp/u-boot/files/debian/control.tmpl
 rename meta/recipes-kernel/linux-module/files/debian/{changelog => changelog.tmpl} (74%)
 delete mode 100644 meta/recipes-kernel/linux-module/files/debian/control
 create mode 100644 meta/recipes-kernel/linux-module/files/debian/control.tmpl

-- 
2.20.1


             reply	other threads:[~2019-02-13 15:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13 15:13 claudius.heine.ext [this message]
2019-02-13 15:13 ` [PATCH v3 1/1] meta: added do_transform_template task as templating system and switch claudius.heine.ext
2019-02-14  7:54 ` [PATCH v3 0/1] Template system Maxim Yu. Osipov
2019-02-14  8:07   ` Claudius Heine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190213151346.2498-1-claudius.heine.ext@siemens.com \
    --to=claudius.heine.ext@siemens.com \
    --cc=ch@denx.de \
    --cc=isar-users@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox