From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6652594697292218368 X-Received: by 2002:a1c:e308:: with SMTP id a8mr79417wmh.14.1550070836163; Wed, 13 Feb 2019 07:13:56 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:fb8c:: with SMTP id a12ls4062715wrr.2.gmail; Wed, 13 Feb 2019 07:13:55 -0800 (PST) X-Google-Smtp-Source: AHgI3IZ4nIPD819bi2YxixU/ADDnRMGxF7biTzHOaUFgK5C8U1zBGUiTYuorZ5OUZ7K/mxUkiED6 X-Received: by 2002:adf:b692:: with SMTP id j18mr77980wre.8.1550070835764; Wed, 13 Feb 2019 07:13:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550070835; cv=none; d=google.com; s=arc-20160816; b=0DHp6ike4o9Ekg9AePp8PLYWTi/xxfXnnr2xgGRAGE132sz2TttTPALx+Zgiap7YLV SAYB2GjQCMeiVmTdEHpyOiJ+vuYqWY4Y5NeYgY18ng0oRlJHPi6PV33w7iBMA86RtPS3 je0UAwno08+0EFCkUGyxbmIqQ10YC0QIauxh2h9fskmBdW9/ndX4jM9y6o2L/MpsOW5G h3scjcJZA7FWKn/L89qcE7wbIWSnW6Sd9RFeydhouC8Cp21KBmtdrK10dmVlTvbfKKLn 16WZAF9ZwOzJkOmQhVWctDec8/Qzp5za9ANptTJveoDYAkwvrai1xz5IGqOIg53t42l/ uonA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=Z7gD12J+/NxRjKZQQCaOCMvWDL5+aHN5m0mJkfmuJ1U=; b=AM58JRb+u7K3Bzs8NIbHqR2KWuTqF3Z1l21kk+9Vq6UNdAvKy8AupokATywU8XF17C 9MpFpFwcS48cHYarTzBcTGBvW4m4r03ASYHUnyRI2N5YVCPttlB6zwqBl8MNQZaHRkpG I3wssfHoYb0qHcHw6vb2WFeXcV08cWFR7AgPPgWcoQEp4vcZAZapoR6edET96awU/G1Y 5aLc3s+csO52RjObzc4eZy9mcDFNo6WPm4UmYzq2n4nEJkPdNpGEbLtRwKRkXd0Vl4J1 dqyNjCibon4VDj8qmhzrpiX+CpswlE8nq4meTHalX0t9eeSfIqntxrfwcxbLb0fgT75D IpPg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id t25si61160wmh.2.2019.02.13.07.13.55 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 13 Feb 2019 07:13:55 -0800 (PST) Received-SPF: pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of claudius.heine.ext@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=claudius.heine.ext@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x1DFDssn020049 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 13 Feb 2019 16:13:54 +0100 Received: from ring.ppmd.siemens.net (linux-ses-ext02.ppmd.siemens.net [139.25.69.181]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x1DFDsiN005696; Wed, 13 Feb 2019 16:13:54 +0100 From: claudius.heine.ext@siemens.com To: isar-users@googlegroups.com Cc: Claudius Heine Subject: [PATCH v3 0/1] Template system Date: Wed, 13 Feb 2019 16:13:45 +0100 Message-Id: <20190213151346.2498-1-claudius.heine.ext@siemens.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TUID: kHyfBru3v2D/ From: Claudius Heine Hi, so after having access to the ilbers ci I could find some issues with this patch. I will try to describe the issue I think happened here: Initially I added the 'do_transform_template' task with a 'before do_build' that normally just triggers the template generation process if the default task 'do_build' is run. The 'do_transform_template' task has the default '${DISTRO}-${DISTRO_ARCH}' stamp-extra-info that we have to add to pretty much all new tasks in isar. That might be ok for normal recipes, but the buildchroot-* recipes add stuff to the virtual default `do_build` and that now depend on the `do_transform_template` task and its dependencies. Currently that is a bit to complex for me to exactly figure out how those errors get triggered, but since that works in the internal CI, but not on ilbers, that messes up the bitbake task order. So my solution is to remove the 'before do_build', now 'do_transform_template' is no longer executed per default. 'dpkg-base' and the image classes add their own dependencies if they need that task. Currently the build a ilbers ci still fails, because apparently gettext-base is not installed there. I added gettext-base as a dependency to the user_manual.md regards, Claudius Changes from v2: - put subprocess into context manager - added 'gettext-base' isar dependency - remove 'before do_build' from addtask Changes from v1: - fixed spelling mistakes of documentation Claudius Heine (1): meta: added do_transform_template task as templating system and switch doc/technical_overview.md | 25 ++++++++ doc/user_manual.md | 1 + meta/classes/base.bbclass | 1 + meta/classes/dpkg-base.bbclass | 2 +- meta/classes/template.bbclass | 62 +++++++++++++++++++ .../debian/{changelog => changelog.tmpl} | 2 +- meta/recipes-bsp/u-boot/files/debian/control | 19 ------ .../u-boot/files/debian/control.tmpl | 19 ++++++ meta/recipes-bsp/u-boot/u-boot-custom.inc | 12 ++-- .../debian/{changelog => changelog.tmpl} | 2 +- .../linux-module/files/debian/control | 11 ---- .../linux-module/files/debian/control.tmpl | 11 ++++ meta/recipes-kernel/linux-module/module.inc | 7 +-- 13 files changed, 130 insertions(+), 44 deletions(-) create mode 100644 meta/classes/template.bbclass rename meta/recipes-bsp/u-boot/files/debian/{changelog => changelog.tmpl} (74%) delete mode 100644 meta/recipes-bsp/u-boot/files/debian/control create mode 100644 meta/recipes-bsp/u-boot/files/debian/control.tmpl rename meta/recipes-kernel/linux-module/files/debian/{changelog => changelog.tmpl} (74%) delete mode 100644 meta/recipes-kernel/linux-module/files/debian/control create mode 100644 meta/recipes-kernel/linux-module/files/debian/control.tmpl -- 2.20.1