From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6659325660443443200 X-Received: by 2002:a2e:2c1a:: with SMTP id s26mr1626275ljs.12.1550568358899; Tue, 19 Feb 2019 01:25:58 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:a19:ae17:: with SMTP id f23ls1457662lfc.2.gmail; Tue, 19 Feb 2019 01:25:58 -0800 (PST) X-Google-Smtp-Source: AHgI3IZB0hpvhreZ21ADTdrNy/yi9yocmctbCbr+/sOzN3+Smb4bMuY9bvjeyuTbg8pmxPljoOGH X-Received: by 2002:ac2:5215:: with SMTP id a21mr1560423lfl.5.1550568358378; Tue, 19 Feb 2019 01:25:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1550568358; cv=none; d=google.com; s=arc-20160816; b=w2nLG0MRlIxbCF4XxYcARZ/+L7jquaUputPElxMfOCqm4PVZsPRYhayfXH1ts1Mjy4 vc0jfc1lOvRkX8WwlLlSQmmmGSfumbzrS94A48cX4zNyblBA/cu3DHgBRy2O5mrHPr7O SRIYOV3lPdtuEAn/hBQNnqOBdGgUw0J/APfieK/vV8lk6wtqZkKFVyqV6vslXVpE+8xS WKbe1bzU2UddtUtU6x4nKufv8OxlkqGORDcbCEGmdfMcd+bqOm+zBcrLSLLAnck+LnDG VjisYqHyoqnBtdwIP+xIcKLhspVo3yCnKKqh7ALw6O60bXER8lb5Eu2JYuyhD8YRbQWS 4nyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=OToD69UPSC2QsElTpekRJ0uVZQMQ3yuZesv47LxeMEs=; b=HKFartmUBymx37FbMTYVdS+3T22egrRj4UxSw2uYIt1Qy/dIElytdoCKgngX8soTTO eYzk/dq7EnJLcgEcKXqQcZNNSPLgViqEMZ2+nT8ggXOPOKJGX1dEo8oRB7Pi9z5eATno GQRnBHIS0KmyjU59k4n8vTM50KUvS8u5crMtRuAGjORwk/p70AClr7caFtV0zw3Az5m+ nZpJUJRWfjODCQLbtP+M1jSj6OA1dmLzDsSzIbJYPK2rUhDkqpyl4pEO2IQ2CkpcJiAD UDZdYYvCDtHKI+hhA/g9/J3Hi0TwIwYq9JWbgptbqPRgBwdBtkrLV3IlBfnefe4F/AC4 W1eg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from goliath.siemens.de (goliath.siemens.de. [192.35.17.28]) by gmr-mx.google.com with ESMTPS id l25si718296lfh.4.2019.02.19.01.25.58 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Feb 2019 01:25:58 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) client-ip=192.35.17.28; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.28 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail2.sbs.de (mail2.sbs.de [192.129.41.66]) by goliath.siemens.de (8.15.2/8.15.2) with ESMTPS id x1J9PvEb004976 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Feb 2019 10:25:57 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.68.200]) by mail2.sbs.de (8.15.2/8.15.2) with ESMTP id x1J9PupR018099; Tue, 19 Feb 2019 10:25:56 +0100 Date: Tue, 19 Feb 2019 10:25:55 +0100 From: Henning Schild To: "[ext] claudius.heine.ext@siemens.com" Cc: , Claudius Heine Subject: Re: [PATCH 1/1] meta/ext4-img: refactor to fit current image creation methods Message-ID: <20190219102555.1ce22459@md1za8fc.ad001.siemens.net> In-Reply-To: <20190218130429.9881-2-claudius.heine.ext@siemens.com> References: <20190218130429.9881-1-claudius.heine.ext@siemens.com> <20190218130429.9881-2-claudius.heine.ext@siemens.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: 9Q112f2pyMqb Hi, did you do some research on ext4-usage, we might be able to just drop it and use wic instead. The qemus will have to switch from i.e. root=/dev/sda to /dev/sda1 ... sounds easy enough. As far as i can tell they are the only users in Isar. And outside a raw ext4 partition does not seem to be too useful either, we could always keep it as "deprecated" if we are afraid of that move. Henning On Mon, 18 Feb 2019 14:04:29 +0100 "[ext] claudius.heine.ext@siemens.com" wrote: > From: Claudius Heine > > EXT4_IMAGE_FILE does no longer contain the full path to the ext4 image > in the deploy directory. > > Signed-off-by: Claudius Heine > --- > meta-isar/classes/rpi-sdimg.bbclass | 2 +- > meta/classes/ext4-img.bbclass | 31 > +++++++++++------------------ 2 files changed, 13 insertions(+), 20 > deletions(-) > > diff --git a/meta-isar/classes/rpi-sdimg.bbclass > b/meta-isar/classes/rpi-sdimg.bbclass index 91b09cd..4e5d170 100644 > --- a/meta-isar/classes/rpi-sdimg.bbclass > +++ b/meta-isar/classes/rpi-sdimg.bbclass > @@ -15,7 +15,7 @@ BOOT_SPACE ?= "40960" > IMAGE_ROOTFS_ALIGNMENT = "4096" > > SDIMG = "${DEPLOY_DIR_IMAGE}/${PN}.rpi-sdimg" > -SDIMG_ROOTFS = "${EXT4_IMAGE_FILE}" > +SDIMG_ROOTFS = "${DEPLOY_DIR_IMAGE}/${EXT4_IMAGE_FILE}" > > do_rpi_sdimg () { > # Align partitions > diff --git a/meta/classes/ext4-img.bbclass > b/meta/classes/ext4-img.bbclass index 29e5f77..2620de9 100644 > --- a/meta/classes/ext4-img.bbclass > +++ b/meta/classes/ext4-img.bbclass > @@ -1,30 +1,23 @@ > # This software is a part of ISAR. > # Copyright (C) 2015-2017 ilbers GmbH > > -EXT4_IMAGE_FILE = "${DEPLOY_DIR_IMAGE}/${IMAGE_FULLNAME}.ext4.img" > +EXT4_IMAGE_FILE = "${IMAGE_FULLNAME}.ext4.img" > + > +IMAGER_INSTALL += "e2fsprogs" > > do_ext4_image[stamp-extra-info] = "${DISTRO}-${MACHINE}" > > # Generate ext4 filesystem image > do_ext4_image() { > - rm -f ${EXT4_IMAGE_FILE} > - > - dd if=/dev/zero of=${EXT4_IMAGE_FILE} bs=1k count=${ROOTFS_SIZE} > - > - sudo mkfs.ext4 -F ${EXT4_IMAGE_FILE} > - > - mkdir -p ${WORKDIR}/mnt > - sudo mount -o loop ${EXT4_IMAGE_FILE} ${WORKDIR}/mnt > - _do_ext4_image_cleanup() { > - ret=$? > - sudo umount ${WORKDIR}/mnt 2>/dev/null || true > - sudo rmdir ${WORKDIR}/mnt 2>/dev/null || true > - (exit $ret) || bb_exit_handler > - } > - trap '_do_ext4_image_cleanup' EXIT > - sudo cp -r ${IMAGE_ROOTFS}/* ${WORKDIR}/mnt > - _do_ext4_image_cleanup > + rm -f '${DEPLOY_DIR_IMAGE}/${EXT4_IMAGE_FILE}' > + > + truncate -s ${ROOTFS_SIZE}K > '${DEPLOY_DIR_IMAGE}/${EXT4_IMAGE_FILE}' + > + image_do_mounts > + > + sudo chroot ${BUILDCHROOT_DIR} /sbin/mke2fs ${MKE2FS_ARGS} \ > + -F -d '${PP_ROOTFS}' > '${PP_DEPLOY}/${EXT4_IMAGE_FILE}' } > > -addtask ext4_image before do_build after do_copy_boot_files > +addtask ext4_image before do_build after do_copy_boot_files > do_install_imager_deps do_ext4_image[prefuncs] = 'set_image_size'