From mboxrd@z Thu Jan 1 00:00:00 1970 X-GM-THRID: 6524996667803959296 X-Received: by 2002:a1c:7503:: with SMTP id o3mr1230552wmc.9.1551110584094; Mon, 25 Feb 2019 08:03:04 -0800 (PST) X-BeenThere: isar-users@googlegroups.com Received: by 2002:adf:a1c3:: with SMTP id v3ls1157464wrv.17.gmail; Mon, 25 Feb 2019 08:03:03 -0800 (PST) X-Google-Smtp-Source: AHgI3IZXei3t8kKom04H+l3RA1uVWGbdUEU96ziX42SRksEGCr8lDtirxubX9APRa2kqyS8rFia3 X-Received: by 2002:adf:9f42:: with SMTP id f2mr920501wrg.25.1551110583700; Mon, 25 Feb 2019 08:03:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1551110583; cv=none; d=google.com; s=arc-20160816; b=LCpGi9vjJwi5tMKDcxvZYtw2ZfMcM3tIrkYCzaD0tNSpPpgKpI80/iF96QVeSZQmt9 rF/r5BaY4sHkAVw4r8BcaShKGWD7IwqQ+aig8kj6bNkG4A9jFC4lQbNDFQH5W0JaQbux FtKdLTR6c/mUxb3FM89jU19ej/qh9Dd9Sxh+jcJHAtvagE+zk2YUMBe+ozdVgjiMiM3K zmpjvCHDDvD9YnuRIBCfAC3msJ6L9UKw8feFK/7b5fE5EEUdyodhdDBoauEleRAydrs9 0aMip+IeRd8aosNZrJVuNwn+pr+44EsFRqWUMKbn97VWMgryy37/TknfQs79a01CVMga SVmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date; bh=eCFl4SPtiuLa5nAkY8eTf6uTc4JrxU6fSf7eWGNDRWM=; b=buWa7L+CBK6ik6n2f+zytP618XpNDABNa77pYcD4oZw8Ee7uoyJhooWeo+WaFsSpMh LoLk80Vu6XJJ1SAwTAzDsv2MhueWraJxs1+evKBMm3Rb5os2O2f+1poPTZfVIsfwbkbY MQsm4WPXdqqdNMp3e5EF77IDGKeH5JCudHzJP3vSbiTF3OLJ3t8RR+j9yTwntvO25I9j 5G4X/6vfrxACOG9913hZQsCJirq24t2Rhtlz3cSFTKsMvBkkH7YnvW6F8XiEa5IelllX N+eJVVg5uH7Ut7OOrg1sJ4LSMmOw5JuHw4KdhxRHoAff0VdmcLAlRJKL5a0n7kq80pJb OvIg== ARC-Authentication-Results: i=1; gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Return-Path: Received: from david.siemens.de (david.siemens.de. [192.35.17.14]) by gmr-mx.google.com with ESMTPS id f2si483665wrq.5.2019.02.25.08.03.03 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Feb 2019 08:03:03 -0800 (PST) Received-SPF: pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) client-ip=192.35.17.14; Authentication-Results: gmr-mx.google.com; spf=pass (google.com: domain of henning.schild@siemens.com designates 192.35.17.14 as permitted sender) smtp.mailfrom=henning.schild@siemens.com Received: from mail1.sbs.de (mail1.sbs.de [192.129.41.35]) by david.siemens.de (8.15.2/8.15.2) with ESMTPS id x1PG33B9009101 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Feb 2019 17:03:03 +0100 Received: from md1za8fc.ad001.siemens.net ([139.25.68.188]) by mail1.sbs.de (8.15.2/8.15.2) with ESMTP id x1PG33pb003219; Mon, 25 Feb 2019 17:03:03 +0100 Date: Mon, 25 Feb 2019 17:03:02 +0100 From: Henning Schild To: Jan Kiszka Cc: Cedric Hombourger , Subject: Re: [PATCH 1/1] buildchroot: remove hard-coded distro names in the multistrap template Message-ID: <20190225170302.56f0fef2@md1za8fc.ad001.siemens.net> In-Reply-To: <554bc1a2-8772-5ca3-eb92-d310ce09b4ff@siemens.com> References: <20180221131924.4744-1-Cedric_Hombourger@mentor.com> <20180221131924.4744-2-Cedric_Hombourger@mentor.com> <20190222112638.31e77bd8@md1za8fc.ad001.siemens.net> <554bc1a2-8772-5ca3-eb92-d310ce09b4ff@siemens.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: E36yGGxMn7Rl Am Fri, 22 Feb 2019 11:32:57 +0100 schrieb Jan Kiszka : > On 22.02.19 11:26, [ext] Henning Schild wrote: > > Hi, > > > > unfortunately Isar is pretty inconsistent with debian naming. > > "Debian" is a distro, like "ubuntu" or "mint". "stretch" and > > "buster" are suites ... > > > > suite=distro is wrong > > > > Please choose another name for that variable. One point less to > > clean up when setting things straight. > > > > Henning > > > > Am Wed, 21 Feb 2018 13:19:24 +0000 > > schrieb Cedric Hombourger : > > Were you on a time ride, Henning? :) Oh, i guess Feb looked ok ;). I recently had to change mail clients, and thunderbird seriously messes with your mails if you just use it once a quarter.... Henning > Jan > > > > >> The multistrap configuration template assumes the distribution > >> will be "isar"; this may however be changed via the DEBDISTRONAME > >> variable. Add yet another variable substitution to the template > >> processing code. > >> > >> Signed-off-by: Cedric Hombourger > >> --- > >> meta/recipes-devtools/buildchroot/buildchroot.bb | 1 + > >> meta/recipes-devtools/buildchroot/files/multistrap.conf.in | 2 +- > >> 2 files changed, 2 insertions(+), 1 deletion(-) > >> > >> diff --git a/meta/recipes-devtools/buildchroot/buildchroot.bb > >> b/meta/recipes-devtools/buildchroot/buildchroot.bb index > >> 520daf9..12577c7 100644 --- > >> a/meta/recipes-devtools/buildchroot/buildchroot.bb +++ > >> b/meta/recipes-devtools/buildchroot/buildchroot.bb @@ -60,6 +60,7 > >> @@ do_build() { -e > >> 's|##DISTRO_APT_SOURCE_SEC##|${DISTRO_APT_SOURCE_SEC}|g' \ -e > >> 's|##DISTRO_SUITE##|${DISTRO_SUITE}|g' \ -e > >> 's|##DISTRO_COMPONENTS##|${DISTRO_COMPONENTS}|g' \ > >> + -e 's|##DEBDISTRONAME##|${DEBDISTRONAME}|g' \ > >> -e > >> 's|##CONFIG_SCRIPT##|./'"$WORKDIR_REL"'/configscript.sh|g' \ -e > >> 's|##SETUP_SCRIPT##|./'"$WORKDIR_REL"'/setup.sh|g' \ -e > >> 's|##DIR_HOOKS##|./'"$WORKDIR_REL"'/hooks_multistrap|g' \ diff > >> --git a/meta/recipes-devtools/buildchroot/files/multistrap.conf.in > >> b/meta/recipes-devtools/buildchroot/files/multistrap.conf.in index > >> 480a4b8..ee0ea09 100644 --- > >> a/meta/recipes-devtools/buildchroot/files/multistrap.conf.in +++ > >> b/meta/recipes-devtools/buildchroot/files/multistrap.conf.in @@ > >> -32,6 +32,6 @@ omitdebsrc=true [isar-apt] > >> source=file:///isar-apt > >> -suite=isar > >> +suite=##DEBDISTRONAME## > >> components=main > >> omitdebsrc=true > > >